Re: [PATCH 2/2] meta-isar: enable systemd-boot for qemuarm-bookworm

[Anton Mikanovich <amikan@ilbers.de>]

08.07.2022 14:04, Jan Kiszka wrote:
> On 08.07.22 10:48, Henning Schild wrote:
>> Am Thu,  7 Jul 2022 17:18:03 +0300
>> schrieb Anton Mikanovich <amikan@ilbers.de>:
>>
>>> Add WIC imagetype with wks which use systemd-boot bootloader for
>>> SYSTEMD_BOOTLOADER_INSTALL testing.
>>>
>>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
>>> ---
>>>   meta-isar/conf/multiconfig/qemuarm-bookworm.conf | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/meta-isar/conf/multiconfig/qemuarm-bookworm.conf
>>> b/meta-isar/conf/multiconfig/qemuarm-bookworm.conf index
>>> 0819236..b515e40 100644 ---
>>> a/meta-isar/conf/multiconfig/qemuarm-bookworm.conf +++
>>> b/meta-isar/conf/multiconfig/qemuarm-bookworm.conf @@ -2,3 +2,8 @@
>>>   
>>>   MACHINE ?= "qemuarm"
>>>   DISTRO ?= "debian-bookworm"
>>> +
>>> +IMAGE_FSTYPES_append = " wic"
>>> +WKS_FILE ?= "sdimage-efi-sd"
>>> +
>>> +IMAGE_PREINSTALL += "${SYSTEMD_BOOTLOADER_INSTALL}"
>> Unlike the other bootloaders this one comes from inside the target
>> rootfs, it is a PREINSTALL for the image, not an IMAGER_INSTALL ...
>> which kind of is a PREINSTALL for the build chroot.
>>
>> So i suggest to somehow cover that subtle difference i.e. by naming the
>> variable SYSTEMD_BOOTLOADER_PREINSTALL
> Why should systemd-boot be any different to other EFI bootloaders? Is
> our plugin different from all the others? The normal way is indeed
> installing it via IMAGER_INSTALL.
>
> Jan
>
As Henning already mentioned systemd-boot(systemd-boot-efi) files (like
systemd-bootx64.efi) supposed to be installed on target rootfs to be used
during the boot process, while IMAGER_INSTALL will place them on buildchroot
only.