[PATCH 0/1] Optional kernel

[PATCH 0/1] Optional kernel

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

Hi,

this might be the easiest solution to make kernels optional.

regards,
Claudius

Claudius Heine (1):
  meta-isar/isar-image-base: make kernel optional

 meta-isar/recipes-core/images/isar-image-base.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.16.3

[PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

Isar should also be able to build root file systems without a kernel,
for instance when using it via nfs or on systems where the kernel needs
to be deployed some where else, not as part of the directory tree.

With this patch setting "KERNEL_NAME" to an empty string or not setting
this variable at all, will not cause an error and no kernel will be
installed to the root file system.

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta-isar/recipes-core/images/isar-image-base.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb
index 6b0030b..d39a25e 100644
--- a/meta-isar/recipes-core/images/isar-image-base.bb
+++ b/meta-isar/recipes-core/images/isar-image-base.bb
@@ -16,7 +16,7 @@ PV = "1.0"
 inherit image
 inherit isar-bootstrap-helper
 
-IMAGE_INSTALL += "linux-image-${KERNEL_NAME}"
+IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME", True)) if d.getVar("KERNEL_NAME", True) else ""}"
 
 DEPENDS += "${IMAGE_INSTALL}"
 
-- 
2.16.3

Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Baurzhan Ismagulov]

On Thu, Apr 12, 2018 at 04:36:14PM +0200, claudius.heine.ext@siemens.com wrote:
> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb
> index 6b0030b..d39a25e 100644
> --- a/meta-isar/recipes-core/images/isar-image-base.bb
> +++ b/meta-isar/recipes-core/images/isar-image-base.bb
> @@ -16,7 +16,7 @@ PV = "1.0"
>  inherit image
>  inherit isar-bootstrap-helper
>  
> -IMAGE_INSTALL += "linux-image-${KERNEL_NAME}"
> +IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME", True)) if d.getVar("KERNEL_NAME", True) else ""}"

If I want to generate an NFS rootfs w/o the kernel and an SD image with one,
how would I proceed? Do I understand correctly, the latter recipe would list
this line, and the former would not?

With kind regards,
Baurzhan.

Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Claudius Heine]

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

On Fri, 2018-04-13 at 12:38 +0200, Baurzhan Ismagulov wrote:
> On Thu, Apr 12, 2018 at 04:36:14PM +0200, claudius.heine.ext@siemens.
> com wrote:
> > diff --git a/meta-isar/recipes-core/images/isar-image-base.bb
> > b/meta-isar/recipes-core/images/isar-image-base.bb
> > index 6b0030b..d39a25e 100644
> > --- a/meta-isar/recipes-core/images/isar-image-base.bb
> > +++ b/meta-isar/recipes-core/images/isar-image-base.bb
> > @@ -16,7 +16,7 @@ PV = "1.0"
> >  inherit image
> >  inherit isar-bootstrap-helper
> >  
> > -IMAGE_INSTALL += "linux-image-${KERNEL_NAME}"
> > +IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME",
> > True)) if d.getVar("KERNEL_NAME", True) else ""}"
> 
> If I want to generate an NFS rootfs w/o the kernel and an SD image
> with one,
> how would I proceed?

With two multiconfigs? That would be how I would probably do it.

>  Do I understand correctly, the latter recipe would list
> this line, and the former would not?

I don't understand your question here. What do you mean with 'latter'
and 'former recipe'?

regards,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

            PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                              Keyserver: hkp://pool.sks-keyservers.net

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Baurzhan Ismagulov]

On Fri, Apr 13, 2018 at 12:45:10PM +0200, Claudius Heine wrote:
> > If I want to generate an NFS rootfs w/o the kernel and an SD image
> > with one,
> > how would I proceed?
> 
> With two multiconfigs? That would be how I would probably do it.

One multiconfig (e.g, qemui386-stretch), product-image-base.bb,
product-nfs-base.bb.


> >  Do I understand correctly, the latter recipe would list
> > this line, and the former would not?
> 
> I don't understand your question here. What do you mean with 'latter'
> and 'former recipe'?

Include IMAGE_INSTALL += "..." in product-image-base.bb but not in
product-nfs-base.bb?


With kind regards,
Baurzhan.

Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Claudius Heine]

Hi Baurzhan,

On 2018-04-13 13:23, Baurzhan Ismagulov wrote:
> On Fri, Apr 13, 2018 at 12:45:10PM +0200, Claudius Heine wrote:
>>> If I want to generate an NFS rootfs w/o the kernel and an SD image
>>> with one,
>>> how would I proceed?
>>
>> With two multiconfigs? That would be how I would probably do it.
> 
> One multiconfig (e.g, qemui386-stretch), product-image-base.bb,
> product-nfs-base.bb.

You are right. Two multiconfigs would not be the best idea. Also since 
that would double the required resources. I haven't done this before, 
since I only create nfs root file systems for my project.

>>>   Do I understand correctly, the latter recipe would list
>>> this line, and the former would not?
>>
>> I don't understand your question here. What do you mean with 'latter'
>> and 'former recipe'?
> 
> Include IMAGE_INSTALL += "..." in product-image-base.bb but not in
> product-nfs-base.bb?

You could also just require the isar-image-base recipe on both images 
and set 'KERNEL_NAME' to "" in 'product-nfs-base.bb'. With this patch no 
kernel would be used.

AFAIK most people base their custom images on isar-image-base, so it 
makes sense to have this image parameterized. A general dependency like 
it was done before this patch is not that flexible.

Cheers,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Jan Kiszka]

On 2018-04-16 09:03, [ext] Claudius Heine wrote:
> Hi Baurzhan,
> 
> On 2018-04-13 13:23, Baurzhan Ismagulov wrote:
>> On Fri, Apr 13, 2018 at 12:45:10PM +0200, Claudius Heine wrote:
>>>> If I want to generate an NFS rootfs w/o the kernel and an SD image
>>>> with one,
>>>> how would I proceed?
>>>
>>> With two multiconfigs? That would be how I would probably do it.
>>
>> One multiconfig (e.g, qemui386-stretch), product-image-base.bb,
>> product-nfs-base.bb.
> 
> You are right. Two multiconfigs would not be the best idea. Also since
> that would double the required resources. I haven't done this before,
> since I only create nfs root file systems for my project.

Why would it double the used resources? If two multiconfigs use the same
machine and distro and only vary in the selected image, and that maybe
only in a small package set (image B is based on image A), that should
allow for massive sharing. Keep in mind that different multiconfig does
not mean at all different basis (machine, distro, base image).

Jan

Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Claudius Heine]

Hi Jan,

On 2018-04-16 09:09, Jan Kiszka wrote:
> On 2018-04-16 09:03, [ext] Claudius Heine wrote:
>> Hi Baurzhan,
>>
>> On 2018-04-13 13:23, Baurzhan Ismagulov wrote:
>>> On Fri, Apr 13, 2018 at 12:45:10PM +0200, Claudius Heine wrote:
>>>>> If I want to generate an NFS rootfs w/o the kernel and an SD image
>>>>> with one,
>>>>> how would I proceed?
>>>>
>>>> With two multiconfigs? That would be how I would probably do it.
>>>
>>> One multiconfig (e.g, qemui386-stretch), product-image-base.bb,
>>> product-nfs-base.bb.
>>
>> You are right. Two multiconfigs would not be the best idea. Also since
>> that would double the required resources. I haven't done this before,
>> since I only create nfs root file systems for my project.
> 
> Why would it double the used resources? If two multiconfigs use the same
> machine and distro and only vary in the selected image, and that maybe
> only in a small package set (image B is based on image A), that should
> allow for massive sharing. Keep in mind that different multiconfig does
> not mean at all different basis (machine, distro, base image).

Sorry, I am currently not that into the path structure of Isar. I just 
use the variables, but haven't looked at their values in detail.
I thought, without checking, that the multiconfig name was part of some 
of those paths. Since multiconfigs select the kernels so they have to be 
part of the image name and maybe other paths as well to not cause 
conflict if multiple multiconfigs use the same machine and distro but 
different kernels.

Best regards,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Henning Schild]

Am Fri, 13 Apr 2018 12:38:20 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Thu, Apr 12, 2018 at 04:36:14PM +0200,
> claudius.heine.ext@siemens.com wrote:
> > diff --git a/meta-isar/recipes-core/images/isar-image-base.bb
> > b/meta-isar/recipes-core/images/isar-image-base.bb index
> > 6b0030b..d39a25e 100644 ---
> > a/meta-isar/recipes-core/images/isar-image-base.bb +++
> > b/meta-isar/recipes-core/images/isar-image-base.bb @@ -16,7 +16,7
> > @@ PV = "1.0" inherit image
> >  inherit isar-bootstrap-helper
> >  
> > -IMAGE_INSTALL += "linux-image-${KERNEL_NAME}"
> > +IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME",
> > True)) if d.getVar("KERNEL_NAME", True) else ""}"  
> 
> If I want to generate an NFS rootfs w/o the kernel and an SD image
> with one, how would I proceed? Do I understand correctly, the latter
> recipe would list this line, and the former would not?

I think the answer would be with two image recipes that
inherit/override each other. So the main one that is probably derived
from isar-image-base and would be called product-nfs.bb and
product-wic.bb would overwrite some variables from the -nfs version.

That patch should be merged, i already heard from someone else who now
cherry-picked that into their fork.

Henning

> With kind regards,
> Baurzhan.
> 

Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Alexander Smirnov]

On 05/03/2018 06:58 PM, Henning Schild wrote:
> Am Fri, 13 Apr 2018 12:38:20 +0200
> schrieb Baurzhan Ismagulov <ibr@radix50.net>:
> 
>> On Thu, Apr 12, 2018 at 04:36:14PM +0200,
>> claudius.heine.ext@siemens.com wrote:
>>> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb
>>> b/meta-isar/recipes-core/images/isar-image-base.bb index
>>> 6b0030b..d39a25e 100644 ---
>>> a/meta-isar/recipes-core/images/isar-image-base.bb +++
>>> b/meta-isar/recipes-core/images/isar-image-base.bb @@ -16,7 +16,7
>>> @@ PV = "1.0" inherit image
>>>   inherit isar-bootstrap-helper
>>>   
>>> -IMAGE_INSTALL += "linux-image-${KERNEL_NAME}"
>>> +IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME",
>>> True)) if d.getVar("KERNEL_NAME", True) else ""}"
>>
>> If I want to generate an NFS rootfs w/o the kernel and an SD image
>> with one, how would I proceed? Do I understand correctly, the latter
>> recipe would list this line, and the former would not?
> 
> I think the answer would be with two image recipes that
> inherit/override each other. So the main one that is probably derived
> from isar-image-base and would be called product-nfs.bb and
> product-wic.bb would overwrite some variables from the -nfs version.
> 
> That patch should be merged, i already heard from someone else who now
> cherry-picked that into their fork.

Started test build, will apply afterwards.

But, I've looked at this patch again, and I think that this line should 
go to image class instead of recipe, it's already generic enough. 
Otherwise you have to copy this magic expression to every new image 
recipe (if you not inherit isar-image-base).

Alex

Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Henning Schild]

Am Thu, 3 May 2018 19:18:42 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> On 05/03/2018 06:58 PM, Henning Schild wrote:
> > Am Fri, 13 Apr 2018 12:38:20 +0200
> > schrieb Baurzhan Ismagulov <ibr@radix50.net>:
> >   
> >> On Thu, Apr 12, 2018 at 04:36:14PM +0200,
> >> claudius.heine.ext@siemens.com wrote:  
> >>> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb
> >>> b/meta-isar/recipes-core/images/isar-image-base.bb index
> >>> 6b0030b..d39a25e 100644 ---
> >>> a/meta-isar/recipes-core/images/isar-image-base.bb +++
> >>> b/meta-isar/recipes-core/images/isar-image-base.bb @@ -16,7 +16,7
> >>> @@ PV = "1.0" inherit image
> >>>   inherit isar-bootstrap-helper
> >>>   
> >>> -IMAGE_INSTALL += "linux-image-${KERNEL_NAME}"
> >>> +IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME",
> >>> True)) if d.getVar("KERNEL_NAME", True) else ""}"  
> >>
> >> If I want to generate an NFS rootfs w/o the kernel and an SD image
> >> with one, how would I proceed? Do I understand correctly, the
> >> latter recipe would list this line, and the former would not?  
> > 
> > I think the answer would be with two image recipes that
> > inherit/override each other. So the main one that is probably
> > derived from isar-image-base and would be called product-nfs.bb and
> > product-wic.bb would overwrite some variables from the -nfs version.
> > 
> > That patch should be merged, i already heard from someone else who
> > now cherry-picked that into their fork.  
> 
> Started test build, will apply afterwards.
> 
> But, I've looked at this patch again, and I think that this line
> should go to image class instead of recipe, it's already generic
> enough. Otherwise you have to copy this magic expression to every new
> image recipe (if you not inherit isar-image-base).

Ok, i just wanted to vote for the cause, not the implementation.

Henning

> Alex
> 

Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Alexander Smirnov]

On 05/03/2018 07:27 PM, Henning Schild wrote:
> Am Thu, 3 May 2018 19:18:42 +0300
> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> 
>> On 05/03/2018 06:58 PM, Henning Schild wrote:
>>> Am Fri, 13 Apr 2018 12:38:20 +0200
>>> schrieb Baurzhan Ismagulov <ibr@radix50.net>:
>>>    
>>>> On Thu, Apr 12, 2018 at 04:36:14PM +0200,
>>>> claudius.heine.ext@siemens.com wrote:
>>>>> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb
>>>>> b/meta-isar/recipes-core/images/isar-image-base.bb index
>>>>> 6b0030b..d39a25e 100644 ---
>>>>> a/meta-isar/recipes-core/images/isar-image-base.bb +++
>>>>> b/meta-isar/recipes-core/images/isar-image-base.bb @@ -16,7 +16,7
>>>>> @@ PV = "1.0" inherit image
>>>>>    inherit isar-bootstrap-helper
>>>>>    
>>>>> -IMAGE_INSTALL += "linux-image-${KERNEL_NAME}"
>>>>> +IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME",
>>>>> True)) if d.getVar("KERNEL_NAME", True) else ""}"
>>>>
>>>> If I want to generate an NFS rootfs w/o the kernel and an SD image
>>>> with one, how would I proceed? Do I understand correctly, the
>>>> latter recipe would list this line, and the former would not?
>>>
>>> I think the answer would be with two image recipes that
>>> inherit/override each other. So the main one that is probably
>>> derived from isar-image-base and would be called product-nfs.bb and
>>> product-wic.bb would overwrite some variables from the -nfs version.
>>>
>>> That patch should be merged, i already heard from someone else who
>>> now cherry-picked that into their fork.
>>
>> Started test build, will apply afterwards.
>>
>> But, I've looked at this patch again, and I think that this line
>> should go to image class instead of recipe, it's already generic
>> enough. Otherwise you have to copy this magic expression to every new
>> image recipe (if you not inherit isar-image-base).
> 
> Ok, i just wanted to vote for the cause, not the implementation.
> 

This patch will stay as it is, for sure :-)

Alex

Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional

[Alexander Smirnov]

On 04/12/2018 05:36 PM, claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> Isar should also be able to build root file systems without a kernel,
> for instance when using it via nfs or on systems where the kernel needs
> to be deployed some where else, not as part of the directory tree.
> 
> With this patch setting "KERNEL_NAME" to an empty string or not setting
> this variable at all, will not cause an error and no kernel will be
> installed to the root file system.
> 

Applied to next, thanks!