Re: [PATCH 2/5] ccache: fix CCACHE_DIR owner for sbuild

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

On Mon, 2022-12-19 at 16:23 +0100, Henning Schild wrote:
> Am Mon, 19 Dec 2022 17:29:30 +0300
> schrieb Anton Mikanovich <amikan@ilbers.de>:
> 
> > If CCACHE_DIR do not exist before sbuild execution it is created
> > with
> > root privelegies. This results in permissions issues during the
> > next
> > usage by the imager. Create CCACHE_DIR before sbuild to fix that.
> > 
> > Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> > ---
> >  meta/classes/sbuild.bbclass | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/meta/classes/sbuild.bbclass
> > b/meta/classes/sbuild.bbclass
> > index a29b745b..b49eae79 100644
> > --- a/meta/classes/sbuild.bbclass
> > +++ b/meta/classes/sbuild.bbclass
> > @@ -129,6 +129,7 @@ EOSUDO
> >  }
> >  
> >  schroot_configure_ccache() {
> > +    [ ! -e ${CCACHE_DIR} ] && mkdir -p ${CCACHE_DIR}
> 
> I guess just the mkdir -p is enough since that will not complain if
> existing.

Agree. And please put ${CCACHE_DIR} in quotes to support directories
with spaces.

Felix

> 
> Henning
> 
> >      sudo -s <<'EOSUDO'
> >          set -e
> >  
>