From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6605860083084558336 X-Received: by 2002:a1c:d085:: with SMTP id h127-v6mr1031653wmg.24.1538047234021; Thu, 27 Sep 2018 04:20:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:4d06:: with SMTP id o6-v6ls1790650wmh.10.gmail; Thu, 27 Sep 2018 04:20:33 -0700 (PDT) X-Google-Smtp-Source: ACcGV63jTaciXT3GqMCdhLsk+7Ju6DQNiFmT+YvAD6UuuHUSM1tZVr4IFX7tD9eUO+7WdyGozJcw X-Received: by 2002:a1c:760f:: with SMTP id r15-v6mr157797wmc.17.1538047233637; Thu, 27 Sep 2018 04:20:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538047233; cv=none; d=google.com; s=arc-20160816; b=bYaO30f9gchdBmwj9AfnXOUvr+QTBQX1vx0VEAJczzZSl/Xw3P2lJI4apdB8Fou9GS htl/5f5BPZGFtnpZR4aazQ+0RvT3HDA5Ya8brnPNCkoc6V43JSK5NdVSZ+llHyPiQVGc NTuKngMUOnTvW7mijI1Q7abhVzEh5VDdnN63evcH026Rtr4ckf4XPo90I8PIn00f/mib eTRQmceYGHKmBzBFRJ6K7PX+UIrQn3YMeiDzTq5AAlNDRRHac81aD86z6RfLlcd8ZoDI MQJk94zAfXzk7s5UV3T0Z/8lYX2M1y2qZg1jXMkkeN7CQm+4gO9XellknfeUeanTf4OA Vt3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=gRx5mVua/F0T3W3dos9uMpdCuP+sfVeS40jnnGkqgxg=; b=Mk58Qf3n1MNEXFrMbAXcKxCwgHRBVgUYfkpQaAT/MIlJ+pg2McIrWB1XJ0FvTyzan4 5oLgQXToFHPFZ4o99XBQmeI9PcRzgHJubpYlVL7CsYFWM7iEPxlBcsZXL45bb3Dk8A9C rRSp/vg9AbOZBbUjVAZ2y1B4dR0tpfMVAJ5OXPCPnmgRtjN/ZyqFClW6Xcdjw1sibBbw S9O1WQhvR3wd1ared6wPyVXVUwmkBvyZZXCCk4zvxBTXVnoXfD4Df4DBvBqiI+trMiSq Km2DL6Iv6Hs7ZAkM/7shE6lNN/fXfNeu/43rjVc9EvHIfHbBGDSdGB6bbg38MlCJg3zw gMdQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id f2-v6si60984wrp.5.2018.09.27.04.20.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Sep 2018 04:20:33 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id w8RBKW4W007202 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Sep 2018 13:20:33 +0200 Received: from [139.25.69.181] (linux-ses-ext02.ppmd.siemens.net [139.25.69.181]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w8RBKWeH013586; Thu, 27 Sep 2018 13:20:32 +0200 Subject: Re: [PATCH 2/2] sdk: Check if directories are mounted before unmounting To: "[ext] Jan Kiszka" , "Maxim Yu. Osipov" , isar-users@googlegroups.com References: <20180927111039.16872-1-mosipov@ilbers.de> <20180927111039.16872-3-mosipov@ilbers.de> From: Claudius Heine Message-ID: Date: Thu, 27 Sep 2018 13:20:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: iiqu0tR4p2MV Hi, On 9/27/18 1:16 PM, [ext] Jan Kiszka wrote: > ...because it generates an error otherwise? > > On 27.09.18 13:10, Maxim Yu. Osipov wrote: >> Signed-off-by: Maxim Yu. Osipov >> --- >> meta/classes/image.bbclass | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >> index 1db2394..3206877 100644 >> --- a/meta/classes/image.bbclass >> +++ b/meta/classes/image.bbclass >> @@ -98,6 +98,16 @@ addtask copy_boot_files before do_build after do_rootfs >> do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" >> do_copy_boot_files[stamp-extra-info] = "${DISTRO}-${MACHINE}" >> >> +is_mounted() { >> + dir_dev=`stat -c '%D' "$1"` >> + parent_dev=`stat -c '%D' "$1/.."` >> + if [ $dir_dev != $parent_dev ]; then >> + return 0 >> + else >> + return 1 >> + fi >> +} >> + >> SDKCHROOT_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/sdkchroot-${HOST_DISTRO}-${HOST_ARCH}" >> >> do_populate_sdk() { >> @@ -107,8 +117,10 @@ do_populate_sdk() { >> # Purge apt cache to make image slimmer >> sudo rm -rf ${SDKCHROOT_DIR}/rootfs/var/cache/apt/* >> >> + is_mounted ${SDKCHROOT_DIR}/rootfs/dev && sudo umount ${SDKCHROOT_DIR}/rootfs/dev >> + is_mounted ${SDKCHROOT_DIR}/rootfs/proc && sudo umount ${SDKCHROOT_DIR}/rootfs/proc >> + >> # Create SDK archive >> - sudo umount ${SDKCHROOT_DIR}/rootfs/dev ${SDKCHROOT_DIR}/rootfs/proc > > Wouldn't it suffice to append "|| true" then? There is also `mountpoint(1)` from util-linux. Claudius > > Jan > >> sudo tar -C ${SDKCHROOT_DIR} --transform="s|^rootfs|sdk-${DISTRO}-${DISTRO_ARCH}|" \ >> -c rootfs | xz -T0 > ${DEPLOY_DIR_IMAGE}/sdk-${DISTRO}-${DISTRO_ARCH}.tar.xz >> >> > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de