public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
To: benbrenson89@googlemail.com, isar-users <isar-users@googlegroups.com>
Subject: Re: WIC doesn't touch fstab for partition /boot
Date: Thu, 19 Sep 2019 14:32:40 +0200	[thread overview]
Message-ID: <cad7e3c8-0fd9-f87c-57c8-8955d69ccc7a@siemens.com> (raw)
In-Reply-To: <e17f2f53-cacc-45b7-8522-d3df0b8a53d3@googlegroups.com>



On 9/19/19 1:48 PM, benbrenson89 via isar-users wrote:
> Hi guys,
> 
> is there any particular reason why WIC doesn't touch the fstab file if  
> a partition with the mountpoint "/boot" is specified?
> 
> 
> I created a *.wks file with:
> 
> part /boot --source bootimg-partition --ondisk mmcblk0 --fstype=vfat 
> --label boot --active --align 4 --size 200
> 
> The --ondisk parameter should trigger the fstab update but in the 
> direct.py plugin the following snippet indicates that in this case
> the update is skipped.
> 
> def_update_fstab(self, fstab_lines, parts):
> """Assume partition order same as in wks"""
> updated =False
> forpart inparts:
> ifnotpart.realnum ornotpart.mountpoint \
> orpart.mountpoint in("/", "/boot"):
> continue
> 
> 
> Any ideas?
> 
> 
> 

According to the commit ae4ee4d51158eb43f770debf6e41646ef8ed9817 in poky 
there was no reason. We should update wic to current version.
"
wic: add /boot mount point to fstab by default

wic avoided adding /boot to fstab for no reason.
This exception was hardcoded in the wic code.

There is no need for this as mountpoint in .wks file is an optional
field. It can be used only if user wants to have partitions
automatically mounted on system boot.

[YOCTO #11662]

(From OE-Core rev: 2376b05512ddb8c4ec3aaf1df11071f536a76bd9)

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
"

Quirin




      reply	other threads:[~2019-09-19 12:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 11:48 benbrenson89
2019-09-19 12:32 ` Quirin Gylstorff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cad7e3c8-0fd9-f87c-57c8-8955d69ccc7a@siemens.com \
    --to=quirin.gylstorff@siemens.com \
    --cc=benbrenson89@googlemail.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox