From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6738347277421641728 X-Gmail-Labels: Topic type: DISCUSSION X-Received: by 2002:a17:906:959:: with SMTP id j25mr13686500ejd.51.1568896403700; Thu, 19 Sep 2019 05:33:23 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:7ac5:: with SMTP id k5ls694873ejo.14.gmail; Thu, 19 Sep 2019 05:33:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxAJOrfSDT1H5O5Q5EbmJK9WGwg/hT3np9m8gZSCIE3XXTMScPzS5dJH7QHFe6Qi6Mev4U0 X-Received: by 2002:a7b:c203:: with SMTP id x3mr2820405wmi.8.1568896403239; Thu, 19 Sep 2019 05:33:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568896403; cv=none; d=google.com; s=arc-20160816; b=Fp7KucWkqkkNqqviye0qzBD3khSDiXyzCyxFoxAJhT/QY1F2b1tem/X/SWNYTptwV/ KgVJ5nZv0mdOXq4TDUnO6tnTWQ31Aysp1RCr4vMld3AiLC5K7Lv5fhQ9ZyhlySEUQOM1 q1piivcTu0wsCMEtGRGI9Ss4YsGDxc2A7h4n4QxsXJfwxIaF1UkP42h+raUFrC9B7Tg6 c+WlNawG9YAQAwxQ/H4l0RzmbSLNLp3pmKiULY3Fgu8nVBV8TJlhYXDOIN1HYRTt7VYS TVIBvAc9jR+PqRXk99Yet+wfbi2/5WasJMdIZ56fsZB2LgdEwBf0HD6VzGAT7J86oQi1 lqTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=O/vbWe/8/W3gu/n5uQAccRzHM7yT43vShkF2ZoB7Fww=; b=OrpJcG1eFsB/4iGsGfAmIN2sphonIUGeFjXYmOXSqHlz+zWh84QW6QTyZWVlM41VOb yG5TFsq586YU8Ropj/p5CwfzY0Da5o0mV0lPHvB6pRpLFfZ4SJ5Eb9Yn6k8x9Wd9ZVgh 733QOUZX/wHGf4wZ2EU2T0hvwIG3QYUYS3RosmpNyyQPTqv5LHnxNXwfxE5srl5NWjzm 5p4qh5e+B8/3Uuz0HEqnJWlB+34dp4/IYFxnHaTF3DdnzrKi8ll5yrzLPYq1HHWGQ/mq /xnt0ILhlk6ba1SJXd4TTPsUf3dgaMWBgdQwDGmN5oYePD3PbeQltEOJ8Wes8jW7TQ3v KM1g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id x8si361399wmk.2.2019.09.19.05.33.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Sep 2019 05:33:23 -0700 (PDT) Received-SPF: pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x8JCXM0D028530 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Sep 2019 14:33:23 +0200 Received: from [139.25.69.120] ([139.25.69.120]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x8JCXMN7015821; Thu, 19 Sep 2019 14:33:22 +0200 Subject: Re: WIC doesn't touch fstab for partition /boot To: benbrenson89@googlemail.com, isar-users References: From: Quirin Gylstorff Message-ID: Date: Thu, 19 Sep 2019 14:32:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: tY0X9zJNCiWf On 9/19/19 1:48 PM, benbrenson89 via isar-users wrote: > Hi guys, > > is there any particular reason why WIC doesn't touch the fstab file if > a partition with the mountpoint "/boot" is specified? > > > I created a *.wks file with: > > part /boot --source bootimg-partition --ondisk mmcblk0 --fstype=vfat > --label boot --active --align 4 --size 200 > > The --ondisk parameter should trigger the fstab update but in the > direct.py plugin the following snippet indicates that in this case > the update is skipped. > > def_update_fstab(self, fstab_lines, parts): > """Assume partition order same as in wks""" > updated =False > forpart inparts: > ifnotpart.realnum ornotpart.mountpoint \ > orpart.mountpoint in("/", "/boot"): > continue > > > Any ideas? > > > According to the commit ae4ee4d51158eb43f770debf6e41646ef8ed9817 in poky there was no reason. We should update wic to current version. " wic: add /boot mount point to fstab by default wic avoided adding /boot to fstab for no reason. This exception was hardcoded in the wic code. There is no need for this as mountpoint in .wks file is an optional field. It can be used only if user wants to have partitions automatically mounted on system boot. [YOCTO #11662] (From OE-Core rev: 2376b05512ddb8c4ec3aaf1df11071f536a76bd9) Signed-off-by: Ed Bartosh Signed-off-by: Richard Purdie " Quirin