WIC doesn't touch fstab for partition /boot

WIC doesn't touch fstab for partition /boot

[benbrenson89]

[-- Attachment #1.1: Type: text/plain, Size: 677 bytes --]

Hi guys,

is there any particular reason why WIC doesn't touch the fstab file if  a 
partition with the mountpoint "/boot" is specified?


I created a *.wks file with:

part /boot --source bootimg-partition --ondisk mmcblk0 --fstype=vfat 
--label boot --active --align 4 --size 200

The --ondisk parameter should trigger the fstab update but in the direct.py 
plugin the following snippet indicates that in this case
the update is skipped.

def _update_fstab(self, fstab_lines, parts):
"""Assume partition order same as in wks"""
updated = False
for part in parts:
if not part.realnum or not part.mountpoint \
or part.mountpoint in ("/", "/boot"):
  continue


Any ideas?






[-- Attachment #1.2: Type: text/html, Size: 3501 bytes --]

Re: WIC doesn't touch fstab for partition /boot

[Quirin Gylstorff]

On 9/19/19 1:48 PM, benbrenson89 via isar-users wrote:
> Hi guys,
> 
> is there any particular reason why WIC doesn't touch the fstab file if  
> a partition with the mountpoint "/boot" is specified?
> 
> 
> I created a *.wks file with:
> 
> part /boot --source bootimg-partition --ondisk mmcblk0 --fstype=vfat 
> --label boot --active --align 4 --size 200
> 
> The --ondisk parameter should trigger the fstab update but in the 
> direct.py plugin the following snippet indicates that in this case
> the update is skipped.
> 
> def_update_fstab(self, fstab_lines, parts):
> """Assume partition order same as in wks"""
> updated =False
> forpart inparts:
> ifnotpart.realnum ornotpart.mountpoint \
> orpart.mountpoint in("/", "/boot"):
> continue
> 
> 
> Any ideas?
> 
> 
> 

According to the commit ae4ee4d51158eb43f770debf6e41646ef8ed9817 in poky 
there was no reason. We should update wic to current version.
"
wic: add /boot mount point to fstab by default

wic avoided adding /boot to fstab for no reason.
This exception was hardcoded in the wic code.

There is no need for this as mountpoint in .wks file is an optional
field. It can be used only if user wants to have partitions
automatically mounted on system boot.

[YOCTO #11662]

(From OE-Core rev: 2376b05512ddb8c4ec3aaf1df11071f536a76bd9)

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
"

Quirin