public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "[ext] Henning Schild" <henning.schild@siemens.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH 1/3] meta-isar/recipes-app: change SRC_URIs of hello rebuild example
Date: Thu, 19 Sep 2019 19:36:37 +0200	[thread overview]
Message-ID: <cc1fa2b9-51fc-0a47-841a-d58cac1d7c65@siemens.com> (raw)
In-Reply-To: <20190919172234.22447-2-henning.schild@siemens.com>

On 19.09.19 19:22, [ext] Henning Schild wrote:
> From: Henning Schild <henning.schild@siemens.com>
> 
> A following change will require the PV to be the exact match of the
> upstream PV. So "2.10" will not work because upsteam is at "2.10-2", and
> similar for "2.9".
> We do not want the examples to rebuild an exact version, but rather the
> most recent from the suite. The "=" was in there mainly to document the
> choosing feature, which is now done by the comment.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>   meta-isar/recipes-app/hello/hello.inc | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-isar/recipes-app/hello/hello.inc b/meta-isar/recipes-app/hello/hello.inc
> index 747b96b..92402d2 100644
> --- a/meta-isar/recipes-app/hello/hello.inc
> +++ b/meta-isar/recipes-app/hello/hello.inc
> @@ -6,7 +6,9 @@
>   inherit dpkg
>   
>   # this will fetch and unpack the sources from upstream debian

Let's make this a sentence ("This ... Debian.").

> -SRC_URI = "apt://${PN}=${PV}"
> +# not that you can also choose a version but have to pick the exact one

"Note that ..."

> +# i.e. "apt://hello=2.10-2"
> +SRC_URI = "apt://${PN}"
>   
>   MAINTAINER = "isar-users <isar-users@googlegroups.com>"
>   CHANGELOG_V = "${PV}-99+isar"
> 

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2019-09-19 17:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 17:22 [PATCH 0/3] test apt:// fetcher test Henning Schild
2019-09-19 17:22 ` [PATCH 1/3] meta-isar/recipes-app: change SRC_URIs of hello rebuild example Henning Schild
2019-09-19 17:36   ` Jan Kiszka [this message]
2019-09-19 17:22 ` [PATCH 2/3] dpkg-base: ignore binary packages for "apt-get source" Henning Schild
2019-09-19 17:37   ` Jan Kiszka
2019-09-19 17:22 ` [PATCH 3/3] ci: add rebuilding hello to test apt:// fetching Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc1fa2b9-51fc-0a47-841a-d58cac1d7c65@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox