From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6543937367387930624 X-Received: by 2002:a2e:8447:: with SMTP id u7-v6mr1613648ljh.7.1525422749741; Fri, 04 May 2018 01:32:29 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:94cd:: with SMTP id r13-v6ls1854037ljh.15.gmail; Fri, 04 May 2018 01:32:29 -0700 (PDT) X-Google-Smtp-Source: AB8JxZro9HIBzMSLB4Ck4Fp2t4J3g+jO6u+GbbiglYeiEVrE7Yn+C6avvZ+kRhlPmetRhYqqOfhP X-Received: by 2002:a2e:9355:: with SMTP id m21-v6mr1114568ljh.28.1525422749229; Fri, 04 May 2018 01:32:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525422749; cv=none; d=google.com; s=arc-20160816; b=X97g/BujewY3p70Lo22qTbRqdtfS7ECKyz8WlPacOhjmYWju8CCD4D/6n3FrAxgORc DB3azm/eCiRTtrpzsuL2j5nviU2+oe8Bacsope0hYwHcNinSZOaGCQV/7GghTKzbg/bw iK5bV8jbZPOHhuasT8AlrwDAYyuUzYhpkuAXvoRnPeYyKN1xdtpaU1QfJvKKJgfE0YNF 8NTesQsq0w0OYodgIlXIEZAtAs2UbOAZAsw7hn0iX7+8E8kDcsVFMykmjS1N8bIlIARt IgSGOJdvO9jkXg1wALk8C+k0s6Z6Qo8df5J/m98DeGDdxomePbw0KdsJc7zdFgOEOVqs 6Ylw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=d7pEckguRACZrU76yq9M4t4pwzTQyGrAuuCvIMfQUM8=; b=yvOiuL5X9tLYzrdCA9xZal3zDH16HF2L4qvGicjAzcKvT38sAkiH4YkxfmkH0HKxpE sCApUxdqUxpqqrSDeTezc7aD3aiY/mA5+s82nmcyb7h2DzAoN9BVwJwBdmrnz+RN1/Nj IT13VeNzyT25BEaTrUW9GctdZ44hs4eysqamL73QYKdmIIGN8k9tlKAb6CCiguPG0zRf P8fTZuJaiHx494p4d6m7N39zkOmCEj6xT7XLswfCT7CaZZD7nsUaeN8A/nRMghqpgBcD wsICjES0qDE2xx2FuRRW2bgVMyZQcsz0goq5svtmF+543ejwlIZ5I9b8jPFRYGfrTYwF dL0Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id j197-v6si402959lfg.3.2018.05.04.01.32.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 May 2018 01:32:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w448WPjj030227 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 4 May 2018 10:32:27 +0200 Subject: Re: [PATCH v2 00/16] wic integration To: Henning Schild Cc: isar-users@googlegroups.com, Claudius Heine References: <87bf460d-034c-d3ec-3027-2698f728ca17@ilbers.de> <20180503183244.68403f81@md1pvb1c.ad001.siemens.net> <20180504101631.2d373e08@md1pvb1c.ad001.siemens.net> From: Alexander Smirnov Message-ID: Date: Fri, 4 May 2018 11:32:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180504101631.2d373e08@md1pvb1c.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: rSnzk5M0rNht Hi, On 05/04/2018 11:16 AM, Henning Schild wrote: > Am Thu, 3 May 2018 19:39:39 +0300 > schrieb Alexander Smirnov : > >> On 05/03/2018 07:32 PM, Henning Schild wrote: >>> Am Tue, 1 May 2018 22:23:01 +0300 >>> schrieb Alexander Smirnov : >>> >>>> On 04/13/2018 05:18 PM, Henning Schild wrote: >>>>> This series does the follow things: >>>>> >>>>> 1. revert all changes that where made to wic so Isar uses an >>>>> unmodified version of it >>>>> 2. Introdcue an image-class that will create wic images >>>>> automatically 3. enable testing that in CI >>>>> 4. update docs >>>>> >>>>> Patches 1 to 7 just deal with getting back to an unmodified >>>>> version of wic. >>>>> Patch 11 - the big one - provides the real functionality. >>>>> >>>>> I will provide some more information on what is going on here by >>>>> replying to p11. >>>>> >>>>> Major changes to the first series: >>>>> - rebase on recent Isar >>>>> - wic is now running in buildchroot, as root >>>>> - calling wic manually not supported any longer >>>>> - distros before stretch are not supported either (see p11 >>>>> discussion for why) >>>>> - CI can now test wic for the first time >>>> >>>> Applied to next, thanks! >>> >>> Thank you. I have one outstanding change i wanted to squash with >>> p11, originated from a review from Claudius. Should that get >>> squashed or go on top? >>> https://github.com/henning-schild-work/isar/commit/75bbea59fe2e4174f4eaf0f782792d208672fad6 >>> >> >> I'd prefer on top, could you please send this patch on the list? > > And now i remember another "open" point. Claudius suggested to split > the forking of the plugins into two steps. One that just copies them, > and a second to apply the Isar-specific changes. > That would make it easier to see what needed to change to make them > work under Isar, which could become increasingly interesting when we > version-bump our wic some day. > > I could do that on top as well, sort of two no-op patches. But in this > case a rebase would probably be the better option. Or we do not do that > at all. How would you like to proceed? > If you specify the commit to drop and provide two patches, I could force the history. But in general I'd prefer updates-on-top, because this way has lower probability of mistake. I know that current head is fully functional and incrementally tested. If something is updated in the middle of history - I have to check that this doesn't corrupt patches above. Alex