Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

["Maxim Yu. Osipov" <mosipov@ilbers.de>]

On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> isar-bootstrap-host only supports bootstrapping Debian root file
> systems. Therefore deactivate any DISTRO_APT_KEYS from other
> distributions.
> 
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
>   meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> index 08b068f..3e96281 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>   ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>   
>   require isar-bootstrap.inc
> +# We only build debian host buildchroot environments
> +DISTRO_APT_KEYS = ""

 From the first glance this modification limits functionality.
It looks like a hack and I would suggest to avoid this modification.

Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to 
avoid confusion between target and host apt keys.


Maxim.



>   inherit isar-bootstrap-helper
>   
>   do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov