Re: [PATCH v5 04/12] rootfs: Copy the newly created initrd.img to the work directory

["'cedric.hombourger@siemens.com' via isar-users" <isar-users@googlegroups.com>]

On Thu, 2025-10-30 at 10:44 +0100, Quirin Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> 
> This allows to change the permissions of the initrd to 0644. And
> all followup steps do not need sudo.
> 
> This is necessary as dracut creates the initrd with 0600 permissions.
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>  meta/classes/rootfs.bbclass | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/meta/classes/rootfs.bbclass
> b/meta/classes/rootfs.bbclass
> index 1f2ad80b..6b30744b 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -594,17 +594,11 @@ rootfs_generate_initramfs() {
>              echo "Total number of modules: $mods_total"
>              echo "Generating initrd for kernel version:
> $kernel_version"
>              sudo -E chroot "${ROOTFSDIR}" sh -c ' \

you may want to add "set -e" here

I have created a negative test where I forcefully made the dracut
command fail and the build succeeded (while
ROOTFS_INITRAMFS_GENERATOR_CMDLINE had failed, the find command
succeeded as find does not complain if there are no matches)


> -                ${ROOTFS_INITRAMFS_GENERATOR_CMDLINE};'
> +                ${ROOTFS_INITRAMFS_GENERATOR_CMDLINE}; \
> +                find /boot -name "initrd.img-$kernel_version*" -exec
> install --mode 0644 {} /isar-work/initrd.img \; \
> +                '
>          done
> -        if [ -n "${INITRD_DEPLOY_FILE}" ]; then
> -            if [ -f "${ROOTFSDIR}/initrd.img" ]; then
> -                # debian (mkinitramfs)
> -                cp ${ROOTFSDIR}/initrd.img
> ${DEPLOYDIR}/${INITRD_DEPLOY_FILE}
> -            else
> -                # ubuntu (dracut)
> -                cp ${ROOTFSDIR}/boot/initrd.img
> ${DEPLOYDIR}/${INITRD_DEPLOY_FILE}
> -            fi
> -        fi
> +        install --owner $(id -u) --group $(id -g)
> ${WORKDIR}/initrd.img ${DEPLOYDIR}/${INITRD_DEPLOY_FILE}
>      else
>          echo "no kernel in this rootfs, do not generate initrd"
>      fi

-- 
Cedric Hombourger
Siemens AG
www.siemens.com

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/cd2c4a2649734f2feb9b06993c509939d0ae3a25.camel%40siemens.com.