From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 30 Jun 2026 11:55:42 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-lj1-f188.google.com (mail-lj1-f188.google.com [209.85.208.188]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 65U9tgBf029941 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 30 Jun 2026 11:55:42 +0200 Received: by mail-lj1-f188.google.com with SMTP id 38308e7fff4ca-39ad7fb6c57sf27496751fa.3 for ; Tue, 30 Jun 2026 02:55:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1782813336; cv=pass; d=google.com; s=arc-20260327; b=YSfE2qajxtUchXWI+d67V4U9HOzV2/xE/5FtcFjMYjMwt7IoSbwj2ywIl/5cY6Tlg/ +GRldLc72V8P6+Km66b387MBWr1aNIm85yI5ioakzc4FAuRwYjRhR9XK1LQpcutmfnic uhiEKGbmRUdhIawka+bWxhT62mAZkAvWhhEqSf2glruJ5Mr+SRgWH4ziE4TROrLjuNMc WSRZoNmvkNINCje8RjL6LQ/JVtGz/1z/pMhDmoyYRp+ecrJOEgVmIkDT+66phAD2tb66 Kgfvsc4LxnryaH6lo0YNHHxMT0ByFMtgIAKvh8yJV4mAmy8E8d4M8XH+Kk6zDWQHDmpi 7SPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:date:to:from:subject:message-id :dkim-signature; bh=PIL9xRz7he3zOjNZ0qt2D4BQNNresNfZHY7+FZf6+PY=; fh=WRNAslOJIaZkcfj0MvRceq1QGNPD0lsh0yW6v1P2+vA=; b=WKqtIvTc7UzeeXvykPOvOupb3OSgKXy8mONVGgu/GWoSYQ9YWQbq6hfC90uu631EVs zBZHEppt8vvU4MrNvuyQbi7U8EtB+RGYhk8C4cKktpbntmtZYc8AVGs7u9uBLE+jDqzp 2OkXOmnsVmMwYYs0HEWfZIJOxegmW1QA68bxJtYCD68sHvVwP7SvSXFjWAcXDXPJ0/dG qPfPoPmlA18C6LlfXKE2CYYkkrJ8e9hsbcole6PL2S5hq2euF5hyVohYl0Sp9J8Yy5xS Ke5XA8Ut8BlZsr2V0zKmf+O1/8BnxwabnRN3v/f4XRMJvVpzeoAaJKL3NUNWoSPpz9MS 7g2g==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=WyKdIjb7; spf=pass (google.com: domain of fm-68982-202606300955310d82e41c8a0002076f-hhkwmr@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-68982-202606300955310d82e41c8a0002076f-hhKWMr@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1782813336; x=1783418136; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:date:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PIL9xRz7he3zOjNZ0qt2D4BQNNresNfZHY7+FZf6+PY=; b=bMdz3qDNg+m5OAYR6h0Sulf/bRLBtIXU9ryhz+qN9HWglgCvYYWfkuZ+OKbAwt+0tb dRAllAy1v2ICn/UY1ixqWk6JdLHZNU4F8WY/T4z2mBqaIPazD9b0uGnY5kJ/aH9ffaSI H3dpHi5t5rYUny6ZhHKEXLzKiAIUh7Qy5pjNKas5giTRvDDSbAkSC2wbIb34G7mM7E3I 5c9e9rKP/eOQ+DkkTZ/Yk+opa/yKUxYU3y8L6hglZGXLuez8mzl8ntx3Fw47J2spcjyf DYdbAZ3dRX1LCXQG/NoW31e70duTB7dNwG+2euS6xmfXMII7WJNLJDr0YTf5TOcsxM7y 04ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782813336; x=1783418136; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:date:to:from:subject:message-id :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PIL9xRz7he3zOjNZ0qt2D4BQNNresNfZHY7+FZf6+PY=; b=K/7CXuZmG9piZJOxJrBuHl82Wt+Y4Jpu33GlDOjczd2t/nmboPeKjGLpdGuL66eTSm BtxkeRcedxEhQ2R3uwdt5LPF+vRys6UqaFJIePnlN0CFt0qDtNaqlvKEtjB8oaDpmaki /9oh7ZlHutvREZWBQzLeBr7mDVBpPw0JdJyqkIgRqzYrOuLF/5cZLlFzQBhQm8cuGGW5 370CqqxpQFUWDLaQsFfHM52zPgLoS4ysmGNaIyJd5JQZIdEwHo7JJ5r6AXeVTcCcfMDy jkjhD9nH+GHqUMxAVj6NLadF3PzgPQUG9GyNYIXYyhtH3PzzHOhWsa7HVKGRSLH9fGSA z2mg== X-Forwarded-Encrypted: i=2; AHgh+RoycSWiqn6sx9VSzClW8Pbm+/7Cey1v3Iw/nADSH+u2gDQslMOIr9NEPepXCfb+azBDNZWK@ilbers.de X-Gm-Message-State: AOJu0Yy6bl6NsY1Ni9hJ/BiSVlKJeSIpl9cIhe8WSPonBT/vpkhYqfF6 KarSPQDynA4FaofwNq3ktc87A92Wrc1+9SKeEJCUDQqGHPst3LlMa5WM X-Received: by 2002:a05:6512:340c:b0:5ae:b7d4:b68 with SMTP id 2adb3069b0e04-5aebdb7df68mr648250e87.2.1782813336392; Tue, 30 Jun 2026 02:55:36 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AX0PUUehdII46+1G7fjX6MHE6UVfLYMDwbZm7BBRyq3CMdnEDQ==" Received: by 2002:a05:651c:4387:20b0:396:6761:b4ac with SMTP id 38308e7fff4ca-3998a2d88dals9807111fa.0.-pod-prod-09-eu; Tue, 30 Jun 2026 02:55:32 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+RoWbRtgWd9OE25hm6EbsT9sJ7UrfNEMzm33FNOpruE/5y9H+6wl5G78VXVgkiJq4hMfgAheomaqP7Sa@googlegroups.com X-Received: by 2002:a2e:9fc2:0:b0:396:7db0:ef3d with SMTP id 38308e7fff4ca-39b1da429c2mr6177421fa.10.1782813332625; Tue, 30 Jun 2026 02:55:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782813332; cv=none; d=google.com; s=arc-20260327; b=eh5/ibBdBbNycOIwddpOPkMYTd3HqSxDZps0TaVxgXxk4C7tRn9Qj6h64WWmDN0tC0 8tOuDlShmKiTjgjZMUZcfmdOs2nU0aLEgtdx83bcl7ZSX3e/TwkPfIlzfLPD+aE5zHfb oX52hGkEdvBQj3fNSLUx3qtrNG0OIsnMqborXr9mODG9wjamS6lu+DF+vDLn3j9RP+/M zG6Rf05jDUB8XXUhKpd/3yZCSJMulsb/3ZcD1m9dQWEV8jWasgdG4fMwx7d4MuVyHzCa IFvdMbh/fYZmgNX6ZbNbtPA7BGMLwKGaAl2UFjbdN91qGjallMHtsdFLthnmCy2kuGZK PDDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=feedback-id:mime-version:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:dkim-signature; bh=vI/kBmVdddlmJ7P8TT1iZN4TrHtDP1MaGLh1BiJRSO8=; fh=ez+yYIN2+t1/A1KtVD1essDQ6+anTTnZTbSXjuK9WaU=; b=DJ0jDqSg4ZxFQ+EXlvJWEoF7I8Xhmil8fadzL+4tQJLs1/9qnDi4y3hV8VnWI+D0gD poFpCMlOQOxOERrTcAfkupAab07FdlRlIJovdbm4mq1HywhN7Ad7aOQtZ/V22r6O4pZw hbkgAVOyCk7Ehj8h5yaN6aVmDlKXuOdZypsTn6i2yKHVZALNzwVkiCkLQG5TZexO5ZEW MH/xrlX5FQR6/6bNp/LXayrY1jbn1XdgMsgTRIRga4/XQFW0nQVk4AF9fQ6gXFFYoaGJ /xfC+Gb+fo+GT39VBSVmj+wMd/czOOh6HY8x/MVEgHPNq+wP8MptF/SXzX7thg0woFe5 8Fpw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=WyKdIjb7; spf=pass (google.com: domain of fm-68982-202606300955310d82e41c8a0002076f-hhkwmr@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-68982-202606300955310d82e41c8a0002076f-hhKWMr@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-225.siemens.flowmailer.net (mta-64-225.siemens.flowmailer.net. [185.136.64.225]) by gmr-mx.google.com with ESMTPS id 38308e7fff4ca-39b1d83faadsi439261fa.2.2026.06.30.02.55.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jun 2026 02:55:32 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-68982-202606300955310d82e41c8a0002076f-hhkwmr@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) client-ip=185.136.64.225; Received: by mta-64-225.siemens.flowmailer.net with ESMTPSA id 202606300955310d82e41c8a0002076f for ; Tue, 30 Jun 2026 11:55:31 +0200 Message-ID: Subject: Re: [PATCH 1/1] fix(rootfs): close progress reporter after last step finished From: "'Florian Bezdeka' via isar-users" To: Felix Moessbauer , isar-users@googlegroups.com Date: Tue, 30 Jun 2026 11:55:31 +0200 In-Reply-To: <20260629150437.2980426-1-felix.moessbauer@siemens.com> References: <20260629150437.2980426-1-felix.moessbauer@siemens.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-68982:519-21489:flowmailer X-Original-Sender: florian.bezdeka@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=WyKdIjb7; spf=pass (google.com: domain of fm-68982-202606300955310d82e41c8a0002076f-hhkwmr@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-68982-202606300955310d82e41c8a0002076f-hhKWMr@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Florian Bezdeka Reply-To: Florian Bezdeka Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: aU2SVFefnOHV On Mon, 2026-06-29 at 17:04 +0200, Felix Moessbauer wrote: > We currently stop the progress reporter after each step. This is > incorrect, as finish must only be called after the last step. However, > the impact is quite limited. Currently the only observable effect is > that - when running in debug mode - a summary of all previous execution > times is printed per step (instead of once). > > We further want to call finish also if a step raises, hence we move it > to the finally block. > > Fixes: eae54341 ("rootfs: Add missing umounts in rootfs ...") > Signed-off-by: Felix Moessbauer Haven't checked that in depth now, but at first glance it seems that the problem existed even before the commit referenced as Fixes: Anyway: Reviewed-by: Florian Bezdeka > --- > meta/classes-recipe/rootfs.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass > index a58ad031..8e45c10d 100644 > --- a/meta/classes-recipe/rootfs.bbclass > +++ b/meta/classes-recipe/rootfs.bbclass > @@ -458,8 +458,8 @@ python do_rootfs_install() { > > if "release-after" in (d.getVarFlag(cmd, 'isar-apt-lock') or ""): > bb.utils.unlockfile(lock) > - progress_reporter.finish() > finally: > + progress_reporter.finish() > bb.build.exec_func('rootfs_do_umounts', d) > } > addtask rootfs_install before do_rootfs_postprocess after do_unpack > -- > 2.53.0 -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/cd989eeb92d64a7b8e7e577279564b707ccd5408.camel%40siemens.com.