public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] ci: Update kas image
@ 2021-04-19 20:50 Jan Kiszka
  2021-04-27 16:48 ` Henning Schild
  2021-04-28 11:16 ` Anton Mikanovich
  0 siblings, 2 replies; 5+ messages in thread
From: Jan Kiszka @ 2021-04-19 20:50 UTC (permalink / raw)
  To: isar-users

From: Jan Kiszka <jan.kiszka@siemens.com>

The project moved to github's container registry, so we were pulling
stale images for a while.

This update also unbreaks building latest container images with Isar
which was cause by missing packages in older kas-isar.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 1437bd7..7fc1612 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,4 +1,4 @@
-image: kasproject/kas-isar:latest
+image: ghcr.io/siemens/kas/kas-isar:latest
 
 variables:
   GIT_STRATEGY: clone
-- 
2.26.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ci: Update kas image
  2021-04-19 20:50 [PATCH] ci: Update kas image Jan Kiszka
@ 2021-04-27 16:48 ` Henning Schild
  2021-04-28 11:54   ` Jan Kiszka
  2021-04-28 11:16 ` Anton Mikanovich
  1 sibling, 1 reply; 5+ messages in thread
From: Henning Schild @ 2021-04-27 16:48 UTC (permalink / raw)
  To: [ext] Jan Kiszka; +Cc: isar-users

Am Mon, 19 Apr 2021 22:50:11 +0200
schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> The project moved to github's container registry, so we were pulling
> stale images for a while.
> 
> This update also unbreaks building latest container images with Isar
> which was cause by missing packages in older kas-isar.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  .gitlab-ci.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 1437bd7..7fc1612 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -1,4 +1,4 @@
> -image: kasproject/kas-isar:latest
> +image: ghcr.io/siemens/kas/kas-isar:latest

Not sure about "latest", docker does not have version tracking and that
might be true for CI runners as well. On the other hand a number needs
to be tracked manually.

Otherwise, LGTM, please follow up and merge ASAP.

regards,
Henning

>  variables:
>    GIT_STRATEGY: clone


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ci: Update kas image
  2021-04-19 20:50 [PATCH] ci: Update kas image Jan Kiszka
  2021-04-27 16:48 ` Henning Schild
@ 2021-04-28 11:16 ` Anton Mikanovich
  1 sibling, 0 replies; 5+ messages in thread
From: Anton Mikanovich @ 2021-04-28 11:16 UTC (permalink / raw)
  To: Jan Kiszka, isar-users

19.04.2021 23:50, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The project moved to github's container registry, so we were pulling
> stale images for a while.
>
> This update also unbreaks building latest container images with Isar
> which was cause by missing packages in older kas-isar.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Applied to next, thanks.

-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ci: Update kas image
  2021-04-27 16:48 ` Henning Schild
@ 2021-04-28 11:54   ` Jan Kiszka
  2021-04-28 16:43     ` Henning Schild
  0 siblings, 1 reply; 5+ messages in thread
From: Jan Kiszka @ 2021-04-28 11:54 UTC (permalink / raw)
  To: Henning Schild; +Cc: isar-users

On 27.04.21 18:48, Henning Schild wrote:
> Am Mon, 19 Apr 2021 22:50:11 +0200
> schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
> 
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> The project moved to github's container registry, so we were pulling
>> stale images for a while.
>>
>> This update also unbreaks building latest container images with Isar
>> which was cause by missing packages in older kas-isar.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  .gitlab-ci.yml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 1437bd7..7fc1612 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -1,4 +1,4 @@
>> -image: kasproject/kas-isar:latest
>> +image: ghcr.io/siemens/kas/kas-isar:latest
> 
> Not sure about "latest", docker does not have version tracking and that
> might be true for CI runners as well. On the other hand a number needs
> to be tracked manually.
> 

For the time being, we need latest as there is no kas-isar release with
the container tools included yet.

Jan

> Otherwise, LGTM, please follow up and merge ASAP.
> 
> regards,
> Henning
> 
>>  variables:
>>    GIT_STRATEGY: clone
> 


-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ci: Update kas image
  2021-04-28 11:54   ` Jan Kiszka
@ 2021-04-28 16:43     ` Henning Schild
  0 siblings, 0 replies; 5+ messages in thread
From: Henning Schild @ 2021-04-28 16:43 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: isar-users

Am Wed, 28 Apr 2021 13:54:36 +0200
schrieb Jan Kiszka <jan.kiszka@siemens.com>:

> On 27.04.21 18:48, Henning Schild wrote:
> > Am Mon, 19 Apr 2021 22:50:11 +0200
> > schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
> >   
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> The project moved to github's container registry, so we were
> >> pulling stale images for a while.
> >>
> >> This update also unbreaks building latest container images with
> >> Isar which was cause by missing packages in older kas-isar.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >>  .gitlab-ci.yml | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> >> index 1437bd7..7fc1612 100644
> >> --- a/.gitlab-ci.yml
> >> +++ b/.gitlab-ci.yml
> >> @@ -1,4 +1,4 @@
> >> -image: kasproject/kas-isar:latest
> >> +image: ghcr.io/siemens/kas/kas-isar:latest  
> > 
> > Not sure about "latest", docker does not have version tracking and
> > that might be true for CI runners as well. On the other hand a
> > number needs to be tracked manually.
> >   
> 
> For the time being, we need latest as there is no kas-isar release
> with the container tools included yet.

I do not feel strong about it, but creating such a release would be in
your hands and possible if you feel my comment makes sense.

Henning

> Jan
> 
> > Otherwise, LGTM, please follow up and merge ASAP.
> > 
> > regards,
> > Henning
> >   
> >>  variables:
> >>    GIT_STRATEGY: clone  
> >   
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-04-28 16:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-19 20:50 [PATCH] ci: Update kas image Jan Kiszka
2021-04-27 16:48 ` Henning Schild
2021-04-28 11:54   ` Jan Kiszka
2021-04-28 16:43     ` Henning Schild
2021-04-28 11:16 ` Anton Mikanovich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox