From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 02 Oct 2024 10:31:15 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-il1-f188.google.com (mail-il1-f188.google.com [209.85.166.188]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 4928VEf7017940 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 2 Oct 2024 10:31:15 +0200 Received: by mail-il1-f188.google.com with SMTP id e9e14a558f8ab-3a344da7987sf70147275ab.1 for ; Wed, 02 Oct 2024 01:31:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1727857868; cv=pass; d=google.com; s=arc-20240605; b=lEzpqlygiYsHndZ3VeZcznO/0RnC/GinpDHceBfRfv/AwmoaoWrfq0Gp70tfMWoIq/ 0om2fYSIIz/tGcxSXGcXLd+1SIzZbJtuT9o6eIp+q1r7xJGngaqx10PJsWDyVj9WAm14 K7/09H+QSrfVbm1q84JBcjmMGtMUKt4x1HFUXM8L2cxjEWlVKncMX91SJy/MqdutI+Lg Z8Uzl+ZE54vm5tMq29covZjoivsMw3Ws2vpVFb/bWvP4IyV8K1Vma7vyoC/1lwpDEYtc 3GnYsY2M2gtA0nM3L/koWJKxYYOSuwVR0pbtLHejo52afXcnnkF1RF4kYq7j56lejW/t MaMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:dkim-signature; bh=ijg73H+8mJClwm8KxMA1tNRJD6CThyXof1qznwIxMGg=; fh=PZP2vtE2Mq62KUYMzE5xBAZW8uaTFuNKvNSkJ4CNYKY=; b=cRvOCvDOHdj1j0ZWBiQwRDBBvWU1fQgoSs5GKaILPSHWuT6w9G9VxQrxMUybaFMneQ gNUX6OmlpobbG/CVkkgUcfAt0s1/woDNW5U9eO9xGoomSfiPQwEY3qLf/AkZjvGVtFM+ 4DUabZHnxzbjjVOUa8Tmi7p2ApxJtbJS0AgLy1ngck4Wh9UAbZO7c+rg5aktIBQqjk43 Otech8ziLqmHoJtuqvHg27OiZCZFMpVs//FF2U/tVfF8n/7kATc1z2c91UnLUuUIXRIA 6BMUV4RZ31ElZw1fLFX/OA8AegEcHOk6Rh5TXamZnpby1aQ6GSUoTmm6XtINVQUTOhLX 2i9w==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=QUZQ5wgX; spf=pass (google.com: domain of fm-68982-2024100208310520fcbee9bd952d9bf3-bw1zjd@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-68982-2024100208310520fcbee9bd952d9bf3-bW1zjd@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1727857868; x=1728462668; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:content-transfer-encoding:references:in-reply-to:date :to:from:subject:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ijg73H+8mJClwm8KxMA1tNRJD6CThyXof1qznwIxMGg=; b=csIeOLKEIx3MHU7RiSvqdAyBNHOHE+DrQIgfy6bP1G3fVQO2AOLyhI/SAUSIiSCJwH Qi5tUWGlEjVhO9Xd8+xiOals5cGmVcNCllMLsZmyxVhoS1dMAjsKXwh9W8gEkz/469su 4Lc+ttuDUY+Ey/zi/2p5UoiGA+ZBFurt8P590xDvSBzDfwW0AUeyBsKMaf4wjDf5VLd1 yKFs01vQp6blrY3emNiJbOiZ04c2WZrPBY9x0rOemnbF+DCPBWNpFsDInFj5NAI/J//R XC6YvPNQ2LQ4CIJm2fchOjk3GsOLPj3j3w1jbHQcfwK2M05Iw5XpgKk4ysH4ncfrxgu2 4bdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727857868; x=1728462668; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:content-transfer-encoding:references:in-reply-to:date :to:from:subject:message-id:x-beenthere:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ijg73H+8mJClwm8KxMA1tNRJD6CThyXof1qznwIxMGg=; b=J7lLcu9eQpPgBshgp01tsFTkWRGGsYHWc3K+7dxlrQlZqSGoVaZjcFRTfbhM13qwH0 qC4YWFlY/FsmZMKPFgIxBg0VLPnYfm0Y5J5Z1atL3Dvt4dmiLrUV/1jFLa1Evw5VDXtu oTjDTC+UGWQWsIopxmhxD4yTlemKW9Zvw2pAIPTwMaTCNfsv3HpWqndzVKgSSqkLERQn GJPhFAPH18yyF2tp9qBW+LW2z2MZBMXIda5R8Kyyvs2/Pk8boxKHTPm/7cgGTC/wkzgI w6DYSk8QAkFeMSTYValejMsvabF2LztLRkc63H68hzxKwm80D46T1ZmOLqOYp1T6eA5u 3lnA== X-Forwarded-Encrypted: i=2; AJvYcCWcjGGaxDPB0vYevZA+fa8VZtSCf5Od/cYra68d7+n+wV3Qh1tjiTcZw8UfcifzhfdTdJZ0@ilbers.de X-Gm-Message-State: AOJu0Yw2SnJi0GY8igi+NI0P4rk8QYYeIVdxxzhk3ei1FaNliPFPXfMQ J5yUXbgciwn2dVqk08+ISjH48ms0HaM6Je0tjJzNG1NEWFeZQTqL X-Google-Smtp-Source: AGHT+IEC37cROn+zesVKMgxhVkFlgEHW8b5Pb2vDIZm3ouaIn+XU7hCt77ieHLN7u2Qex0S87jlGJQ== X-Received: by 2002:a05:6e02:156c:b0:3a0:9fd8:f70b with SMTP id e9e14a558f8ab-3a36591b2eemr25440925ab.6.1727857868400; Wed, 02 Oct 2024 01:31:08 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6e02:1546:b0:3a0:9043:59b0 with SMTP id e9e14a558f8ab-3a2768e9043ls43017605ab.1.-pod-prod-01-us; Wed, 02 Oct 2024 01:31:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW7cjeG+hDn1on8/E0ethJXpeSQK1fG1TBCcehUdemszpZoBmnEiMLTeMhXZBWwfLK9QLXRDdNmJxc2@googlegroups.com X-Received: by 2002:a05:6e02:1a4e:b0:3a3:41cf:f594 with SMTP id e9e14a558f8ab-3a36592aea4mr23683005ab.12.1727857867604; Wed, 02 Oct 2024 01:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727857867; cv=none; d=google.com; s=arc-20240605; b=b0vNpThROOUiTr80lmH+EBRB+rU0/lXY9muZRcT7Bm0aFMDBfrN9XfiX51viozEYx1 W0fwQxWu7zleI4UKB7KZNS+sLO6oncYEX+Pj3ze6axc3CUgsE/yUG4x6YxPhFQQFzjN7 mectwwBOAJ2/7sdmnKfElTZPhOQYrW3MkVj3Izb8Fr6Dsh+ctFVz8cUb12bGRRTAYxZu Q9cCZEDCReY696JxqKtGSnHpFkm+8B0Wy+iN1DgQ3Y+De16mW04slmPvVzQo84oiwetS SOI84iYGJyQAiQaz2bqxc8IOBIK2s9mQikRiS3FhpwcdNezycNmgYMEhMe5aF/xRm84Y AdvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:mime-version:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:dkim-signature; bh=ZVXaz2F+DBVW316yjtZaD4C9MaMPwx4eA3oQLWew8y4=; fh=jvYxwxBQgtgU44CT7SDnebPco7buBFqduqvn6kvyOj4=; b=lDOjkkkTWNcuvdjwb6yjaQIGCJCf8q4mmUng/ZzTcLwiI0MwTp8Iap2gSAvXuChwwu 4I24gl/fZR5GA9S0rxIYzLzuCp5RLQOVBHdkadpiE6kDqpYh9E4Mm81dt+txNezwendY dosxxvFaVB4nty5FXmQMeBJFTx6wmcYXKtzMnezppvr5SqOnXpZvdprPBZ24b3sXj8hz 51vpuIp04DqcZGY+50dGy3ycSZmRutEIbY4rOLZEsvpPtth01ltVD4BuciAhGuC/m8sy +6jCweqs/6nad0Hl875hmFJKOGmtf/TjqGA2mgu1jNYgDk8SB5fHns3ZdvKt33pNQufx mE/A==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=QUZQ5wgX; spf=pass (google.com: domain of fm-68982-2024100208310520fcbee9bd952d9bf3-bw1zjd@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-68982-2024100208310520fcbee9bd952d9bf3-bW1zjd@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-226.siemens.flowmailer.net (mta-64-226.siemens.flowmailer.net. [185.136.64.226]) by gmr-mx.google.com with ESMTPS id e9e14a558f8ab-3a344d621fdsi5272045ab.1.2024.10.02.01.31.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Oct 2024 01:31:07 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-68982-2024100208310520fcbee9bd952d9bf3-bw1zjd@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) client-ip=185.136.64.226; Received: by mta-64-226.siemens.flowmailer.net with ESMTPSA id 2024100208310520fcbee9bd952d9bf3 for ; Wed, 02 Oct 2024 10:31:05 +0200 Message-ID: Subject: Re: [PATCH] initramfs: Add missing umounts after generation From: "'Florian Bezdeka' via isar-users" To: Jan Kiszka , "Moessbauer, Felix (T CED OES-DE)" , "isar-users@googlegroups.com" Date: Wed, 02 Oct 2024 10:31:03 +0200 In-Reply-To: <4271f8a5-45d8-4e75-9a39-7c11a3411ef6@siemens.com> References: <1646de44-c244-43b3-ad57-b3bf702608b0@siemens.com> <855415c409c8a24b672ed64dba8f3227edf23355.camel@siemens.com> <4271f8a5-45d8-4e75-9a39-7c11a3411ef6@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-68982:519-21489:flowmailer X-Original-Sender: florian.bezdeka@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=QUZQ5wgX; spf=pass (google.com: domain of fm-68982-2024100208310520fcbee9bd952d9bf3-bw1zjd@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-68982-2024100208310520fcbee9bd952d9bf3-bW1zjd@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Florian Bezdeka Reply-To: Florian Bezdeka Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: DPd50J0j//YD On Tue, 2024-10-01 at 12:04 +0200, 'Jan Kiszka' via isar-users wrote: > On 01.10.24 09:38, Moessbauer, Felix (T CED OES-DE) wrote: > > On Mon, 2024-09-30 at 21:42 +0200, 'Jan Kiszka' via isar-users wrote: > > > From: Jan Kiszka > > >=20 > > > Failing to unmount what was mounted via rootfs_do_mounts can cause > > > troubles on rebuilds. > >=20 > > Why is that not caught by the cleanup handler in [1]? > > I'm just wondering as the mounting and unmounting does not happen in > > the same task, hence we will run into problems on partial rebuilds. > >=20 > > [1]https://github.com/ilbers/isar/blob/51462e82e4a108c9c94ba4099465f5a1= 9a7125a6/meta/classes/isar-events.bbclass#L53 >=20 > I didn't analyze that yet, but it is a valid question why our diagnostic > framework failed as well. Taken from the cleanup handler referenced above: with open('/proc/mounts') as f: for line in f.readlines(): if basepath in line: bb.debug(1, '%s left mounted, unmounting...' % line.split()= [1]) subprocess.call( ["sudo", "umount", line.split()[1]], stdout=3Dsubprocess.DEVNULL, stderr=3Dsubprocess.DEVNULL, ) Problems: - bb.debug() will not make it to stdout as long as the log level is not =C2=A0 set accordingly. By default the level is not set to debug, so nobody will notice. - The cleanup handler is executed in "build" context, not "task"=20 context. (Naming might be wrong bitbake wise...). With that there is no log file where bb.debug() will write to. Nobody will notice (again...). - subprocess.call() might fail silently, there is no error checking. In my case: "target is busy.\n" - The cleanup handler is called twice. Not sure if that is correct... At the end our "(u)mount mistake detection mechanism" seems broken. As first step I would vote for a bb.debug() -> bb.warn() migration. Manual inspection of stdout still required... Florian >=20 > Jan >=20 > --=20 > Siemens AG, Technology > Linux Expert Center --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/= isar-users/ce41863a20176bee41fabdd7963d132ad53fe505.camel%40siemens.com.