From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7057909071463055360 X-Received: by 2002:a05:6512:68f:: with SMTP id t15mr22450183lfe.124.1643809386725; Wed, 02 Feb 2022 05:43:06 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:a782:: with SMTP id c2ls3799551ljf.4.gmail; Wed, 02 Feb 2022 05:43:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxlANyPZZJQaT5bz2v4F28twXXUnLdep3a59aM2jNGuBgVeYfVDUli+vqHv6rDyM3sIpWB0 X-Received: by 2002:a05:651c:a0b:: with SMTP id k11mr15056907ljq.266.1643809385731; Wed, 02 Feb 2022 05:43:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643809385; cv=none; d=google.com; s=arc-20160816; b=aYG/V2HYMN5nFPwTHnsfaKUKZQPJuoC4HByLWzngr8k4wEgThbrr3DyuwLS+fv+JJt tV30Wzf/i8g1CxdmrXNL4P0WPU4pNvF3Jsd8qtxRZnnm3N+xLH+Eeb9tAK7PxD+v6IOp k0vk58eFYFmXNxzzCTxVxc1quUJJ3vpCS0eErjfa7axYLFk9zKg1EI3bYFv4Krx5NrSJ SbFB3MxRACvvaru6e8lIR85L2mlE/6IkO5qXwP7cW1TxjPmz6BZZB6HnLBemFN9WkwnV aEnimYiJlXrwM9VbMSXTzMyV5oe1yxjNKHsFs0QnnOkseSbEwkc6ttkt5PswdxcN0hZ/ CddA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=z6Xa7cZw2pIQOAGjL+HtNijKb0CXZkkc81BSSeKukmY=; b=gNwQDfYoech02E/uUQM2CSnF+6/4tJwZh20NlB10fuizOE/9zjFVpKwoCbmjY/RhHk 6xSspG+WqIyJw0L4xCoi7FEIBvwlzzPyOJNWFeBkZll86iLhVdekjmBxH4csmGT+V140 89LBGjVxQvxhlOMWl+Me0RMOGKELn6pwq68D9fDN0AWvRb42mWKeP9I8a9w4NbptXnyd oMRgqXoRmNJTd5O8lm0Q4Kvfr0RFdQEERUDxWMm3iiVmbahrprPyebeKFTcLQ7BsLnnt kiDZUBnjrWzjyKIl1odoBcZcjeGCBe450dGKmllXwlwaxkK7UO34RvDwyuBksre300JJ +Kqg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id w7si749509lfr.2.2022.02.02.05.43.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 Feb 2022 05:43:05 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 212DgwPN024468 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 2 Feb 2022 14:42:59 +0100 Subject: Re: [PATCH v7 0/1] add support for debian build profiles To: Felix Moessbauer , isar-users@googlegroups.com Cc: vijaikumar.kanagarajan@gmail.com, jan.kiszka@siemens.com References: <20220201161619.726934-1-felix.moessbauer@siemens.com> From: Anton Mikanovich Message-ID: Date: Wed, 2 Feb 2022 16:42:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220201161619.726934-1-felix.moessbauer@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: h4dHKe1J0OCc Looks good, this will probably be the first patchset to be merged after some CI testing. 01.02.2022 19:16, Felix Moessbauer wrote: > Changes since v6: > > - always expand ISAR_CROSS_COMPILE variable when used in debian build profiles / options > - rebased onto next > > Changes since v5: > > - squash into a single commit to ensure atomicity of patch (review comment from Jan Kiszka) > > Changes since v4: > > - fix devshell (glitch introduced in v3) > > Changes since v3: > > Set variables via export shell directive instead of setting via os.environ. > This change is required as os.environ sets the environment of the whole bitbake run, hence affects other tasks as well. > As we have to use export, there is no way for us to check if the variable is already exported. > Also checking the current env-vars in isar_deb_build_profiles does not help as the bb function is called prior to the invocation of the shell function that does the compiling. > I added a statement to the RECIPE-API-CHANGELOG about that. > > Changes since v2: > > - only provide DEB_BUILD_PROFILES variable (no _CROSS variable) > - add "cross" directly to env variable when cross-compiling > - add DEB_BUILD_OPTIONS bitbake variable > (profiles like "nocheck" must also add "nocheck" to DEB_BUILD_OPTIONS) > - update API changelog > - use DEB_BUILD_OPTIONS in hello.bb example > > Changes since v1: > > - fix erronous code removal reported by Vijai > - only use value of DEB_BUILD_PROFILES_CROSS when cross-compiling (no combination of values) > - improve API changelog docs > - rebased onto next > - use DEB_BUILD_PROFILES infrastructure in linux-custom.inc > > > Felix Moessbauer (1): > add support for debian build profiles and options > > RECIPE-API-CHANGELOG.md | 8 ++++++++ > meta-isar/recipes-app/hello/hello.bb | 8 ++------ > meta/classes/dpkg-base.bbclass | 19 +++++++++++++++++++ > meta/classes/dpkg.bbclass | 7 ++++++- > .../libubootenv/libubootenv_0.3-3.bb | 5 +---- > meta/recipes-kernel/linux/linux-custom.inc | 13 ++++++++----- > 6 files changed, 44 insertions(+), 16 deletions(-) >