public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH] scripts: Do not used set in sourced script
Date: Mon, 17 Jun 2024 08:24:24 +0300	[thread overview]
Message-ID: <ced59a557ed06da4c09ad4e61fcfc6da9b0b24c3.camel@ilbers.de> (raw)
In-Reply-To: <20240610100255.47239-1-amikan@ilbers.de>

On Mon, 2024-06-10 at 13:02 +0300, Anton Mikanovich wrote:
> Adding 'set -e' in the sourcing script makes it apply on running
> console/chroot. This results in closing current console/chroot in
> case
> of Isar build failure.
> Partly revert 4f9b6419 removing this case for isar-buildenv-internal.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  scripts/isar-buildenv-internal | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/scripts/isar-buildenv-internal b/scripts/isar-buildenv-
> internal
> index 817387cf..bf8c3387 100755
> --- a/scripts/isar-buildenv-internal
> +++ b/scripts/isar-buildenv-internal
> @@ -21,8 +21,6 @@
>  
>  # It is assumed ISARROOT is already defined when this is called
>  
> -set -e
> -
>  if [ -z "$ISARROOT" ]; then
>      echo >&2 "Error: ISARROOT is not defined!"
>      return 1
> -- 
> 2.34.1
> 

Applied to next.

-- 
Best regards,
Uladzimir.

      reply	other threads:[~2024-06-17  5:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 10:02 Anton Mikanovich
2024-06-17  5:24 ` Uladzimir Bely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ced59a557ed06da4c09ad4e61fcfc6da9b0b24c3.camel@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox