* [PATCH] scripts: Do not used set in sourced script
@ 2024-06-10 10:02 Anton Mikanovich
2024-06-17 5:24 ` Uladzimir Bely
0 siblings, 1 reply; 2+ messages in thread
From: Anton Mikanovich @ 2024-06-10 10:02 UTC (permalink / raw)
To: isar-users; +Cc: Anton Mikanovich
Adding 'set -e' in the sourcing script makes it apply on running
console/chroot. This results in closing current console/chroot in case
of Isar build failure.
Partly revert 4f9b6419 removing this case for isar-buildenv-internal.
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
scripts/isar-buildenv-internal | 2 --
1 file changed, 2 deletions(-)
diff --git a/scripts/isar-buildenv-internal b/scripts/isar-buildenv-internal
index 817387cf..bf8c3387 100755
--- a/scripts/isar-buildenv-internal
+++ b/scripts/isar-buildenv-internal
@@ -21,8 +21,6 @@
# It is assumed ISARROOT is already defined when this is called
-set -e
-
if [ -z "$ISARROOT" ]; then
echo >&2 "Error: ISARROOT is not defined!"
return 1
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scripts: Do not used set in sourced script
2024-06-10 10:02 [PATCH] scripts: Do not used set in sourced script Anton Mikanovich
@ 2024-06-17 5:24 ` Uladzimir Bely
0 siblings, 0 replies; 2+ messages in thread
From: Uladzimir Bely @ 2024-06-17 5:24 UTC (permalink / raw)
To: Anton Mikanovich, isar-users
On Mon, 2024-06-10 at 13:02 +0300, Anton Mikanovich wrote:
> Adding 'set -e' in the sourcing script makes it apply on running
> console/chroot. This results in closing current console/chroot in
> case
> of Isar build failure.
> Partly revert 4f9b6419 removing this case for isar-buildenv-internal.
>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> scripts/isar-buildenv-internal | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/scripts/isar-buildenv-internal b/scripts/isar-buildenv-
> internal
> index 817387cf..bf8c3387 100755
> --- a/scripts/isar-buildenv-internal
> +++ b/scripts/isar-buildenv-internal
> @@ -21,8 +21,6 @@
>
> # It is assumed ISARROOT is already defined when this is called
>
> -set -e
> -
> if [ -z "$ISARROOT" ]; then
> echo >&2 "Error: ISARROOT is not defined!"
> return 1
> --
> 2.34.1
>
Applied to next.
--
Best regards,
Uladzimir.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-17 5:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-10 10:02 [PATCH] scripts: Do not used set in sourced script Anton Mikanovich
2024-06-17 5:24 ` Uladzimir Bely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox