From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7378813025950629888 X-Forwarded-Encrypted: i=2; AJvYcCVWp/8Jj1MP7glwx/r4QXSUk2Ap5fzaqg/V33dhc/mk5kDAIZPDW4M8DvUSoAvbwibiEykT0tfM+sZxXkVpmopmDCAv6KWgrM/WwB4= X-Received: by 2002:a05:6512:3708:b0:52c:8fe4:b153 with SMTP id 2adb3069b0e04-52ca6e6d51fmr5467060e87.32.1718601871598; Sun, 16 Jun 2024 22:24:31 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3e1b:b0:52c:a18b:6b3e with SMTP id 2adb3069b0e04-52ca1a77391ls1865694e87.0.-pod-prod-04-eu; Sun, 16 Jun 2024 22:24:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX94rcZQ78eBZcLwpNl6kB0eGrkdhygRvjTNe3S+IjqT1OQdOoFgp+xIDcWb5pIjj+qqTnVmEORz5RwUgaRYMnrYAdqqxlBgU8S8HM= X-Google-Smtp-Source: AGHT+IGQ+ncuNQHgTc6LQKibBACAHPFOoacmM/Xwazh3UKWx7yo9t24tI5WeS2cRWchMs6HwZKNw X-Received: by 2002:a19:5e10:0:b0:52b:8ef7:bf1f with SMTP id 2adb3069b0e04-52ca6e6550amr5014589e87.17.1718601867914; Sun, 16 Jun 2024 22:24:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718601867; cv=none; d=google.com; s=arc-20160816; b=F56nowaKjGcYMeDBroANxj3hpXcggwwireYdE3IMrSMwJyXuZFetfXt5UDsVkoHOhF PZOAx+iMbKDETVhHtyz4u5Ub3eraq1XY2D7yG0VEoHPp8t5Cq4jffdbHJkYzzimfPHRC um26CXHKTPTLIxLxWhiWCbEWR07IkSG2+cz9b17W2E2lroC9nhQ9e2qBzuK5/DxrgToh hVtUSXMqLzYvmvz8Xh8KMhklaMu82r83kiEU1+7rF7jv98GDLU4g/4Lpbvd5L6j1dsQ5 WMvsiK+tXbDorHNJ+FBhK4cabdEY3Tmka8ujdBon+RJL7J+VELuPFywY1MbG91GwTNR8 uakA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=jI36CPLUyqO8bbtDsSLyXim1eY51Q9frm72l+j0jXvk=; fh=JZvUnqoG0jWph92hWpw0EINycbLveqkIcdkusZDYok4=; b=h56ddtcr+PCO45wt38HXOG++u3GVtKK+THi9ZebE06UUHwBRuPgRta5aWwWcG06nty G4qDCaIodJkZlFOlTjP7JfbfGEr3SWKXU3OR0tjej0MP4SRBSJgAS1Drx9A2F3pZ8a76 E1c824z5TjwfzjJoFzc4RHoQ3jTwv/F+jrOUwsqJEU6zKWCBl7jqwRyNM+x7Ozq4TDje v65Tb1XZrfX/bq+nNtZRcOwIB9l3NkUbdSNlOH/ql2dB8OhKakrxzCZkEKD6mSxg0FC+ MQK3hXGyAqd/tqnVG2o3hOwB0Ed9rkfNJ7O7enJq91NF3XNWjELhB5tFuA7VSoh7ScQ1 YNSg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 5b1f17b1804b1-4246d5db4b6si128045e9.0.2024.06.16.22.24.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 16 Jun 2024 22:24:27 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 45H5OOxI013618 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2024 07:24:26 +0200 Message-ID: Subject: Re: [PATCH] scripts: Do not used set in sourced script From: Uladzimir Bely To: Anton Mikanovich , isar-users@googlegroups.com Date: Mon, 17 Jun 2024 08:24:24 +0300 In-Reply-To: <20240610100255.47239-1-amikan@ilbers.de> References: <20240610100255.47239-1-amikan@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.2 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: LgtI2krv7Q3X On Mon, 2024-06-10 at 13:02 +0300, Anton Mikanovich wrote: > Adding 'set -e' in the sourcing script makes it apply on running > console/chroot. This results in closing current console/chroot in > case > of Isar build failure. > Partly revert 4f9b6419 removing this case for isar-buildenv-internal. >=20 > Signed-off-by: Anton Mikanovich > --- > =C2=A0scripts/isar-buildenv-internal | 2 -- > =C2=A01 file changed, 2 deletions(-) >=20 > diff --git a/scripts/isar-buildenv-internal b/scripts/isar-buildenv- > internal > index 817387cf..bf8c3387 100755 > --- a/scripts/isar-buildenv-internal > +++ b/scripts/isar-buildenv-internal > @@ -21,8 +21,6 @@ > =C2=A0 > =C2=A0# It is assumed ISARROOT is already defined when this is called > =C2=A0 > -set -e > - > =C2=A0if [ -z "$ISARROOT" ]; then > =C2=A0=C2=A0=C2=A0=C2=A0 echo >&2 "Error: ISARROOT is not defined!" > =C2=A0=C2=A0=C2=A0=C2=A0 return 1 > --=20 > 2.34.1 >=20 Applied to next. --=20 Best regards, Uladzimir.