public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Cc: Cedric Hombourger <Cedric_Hombourger@mentor.com>
Subject: [PATCH 3/3] Remove redundant recursive umounts
Date: Wed,  5 Dec 2018 10:29:50 +0100	[thread overview]
Message-ID: <cefed5fa3d684c0c3ce7e55742c634e6e4d7d6ee.1544002190.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1544002190.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1544002190.git.jan.kiszka@siemens.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

Lazily umounting also ensures that depending mounts are removed.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/isar-image.bbclass                     | 4 ++--
 meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
index 23b3a99..14b97dd 100644
--- a/meta/classes/isar-image.bbclass
+++ b/meta/classes/isar-image.bbclass
@@ -59,9 +59,9 @@ isar_image_cleanup() {
               -maxdepth 1 -name 'qemu-*-static' -type f -delete
     sudo umount -l ${IMAGE_ROOTFS}/isar-apt
     sudo rmdir ${IMAGE_ROOTFS}/isar-apt
-    sudo umount -R -l ${IMAGE_ROOTFS}/dev
+    sudo umount -l ${IMAGE_ROOTFS}/dev
     sudo umount -l ${IMAGE_ROOTFS}/proc
-    sudo umount -R -l ${IMAGE_ROOTFS}/sys
+    sudo umount -l ${IMAGE_ROOTFS}/sys
     sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf"
     if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
         sudo umount -l ${IMAGE_ROOTFS}/base-apt
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index da077d0..811d50e 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -254,9 +254,9 @@ isar_bootstrap() {
             chroot "${ROOTFSDIR}" /usr/bin/apt-get dist-upgrade -y \
                                   -o Debug::pkgProblemResolver=yes
 
-            umount -R -l "${ROOTFSDIR}/dev"
+            umount -l "${ROOTFSDIR}/dev"
             umount -l "${ROOTFSDIR}/proc"
-            umount -R -l "${ROOTFSDIR}/sys"
+            umount -l "${ROOTFSDIR}/sys"
             umount -l "${ROOTFSDIR}/base-apt" || true
 
             # Finalize debootstrap by setting the link in deploy
-- 
2.16.4


  parent reply	other threads:[~2018-12-05  9:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05  9:29 [PATCH 0/3] umount fixes and cleanups Jan Kiszka
2018-12-05  9:29 ` [PATCH 1/3] ci: Wait for bitbake worker to finish before deleting artifacts Jan Kiszka
2018-12-05  9:52   ` Hombourger, Cedric
2018-12-05  9:59   ` Maxim Yu. Osipov
2018-12-05 10:04     ` Jan Kiszka
2018-12-05  9:29 ` [PATCH 2/3] isar-events: Improve umount handler Jan Kiszka
2018-12-05  9:29 ` Jan Kiszka [this message]
2018-12-05 11:12 ` [PATCH 0/3] umount fixes and cleanups Maxim Yu. Osipov
2018-12-05 11:32   ` Hombourger, Cedric
2018-12-05 12:14   ` Jan Kiszka
2018-12-05 12:31     ` Hombourger, Cedric
2018-12-05 12:35       ` Jan Kiszka
2018-12-05 12:48         ` Hombourger, Cedric
2018-12-05 12:54           ` Jan Kiszka
2018-12-05 14:26     ` Maxim Yu. Osipov
2018-12-05 14:52       ` Jan Kiszka
2018-12-05 23:08         ` Jan Kiszka
2018-12-07 13:46 ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cefed5fa3d684c0c3ce7e55742c634e6e4d7d6ee.1544002190.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox