From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6716855539805978624 X-Received: by 2002:a17:906:2ecc:: with SMTP id s12mr6382465eji.110.1563894536473; Tue, 23 Jul 2019 08:08:56 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:942d:: with SMTP id p42ls10177898eda.1.gmail; Tue, 23 Jul 2019 08:08:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwPxZTVcvDOk63LzPsCj+ThBuY84KpbqTvsXHxjFucgWwVIydMaQ8FsgVZ5XJxgJdkKoGcO X-Received: by 2002:a50:89a2:: with SMTP id g31mr66706928edg.93.1563894536006; Tue, 23 Jul 2019 08:08:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563894536; cv=none; d=google.com; s=arc-20160816; b=RVW9TPNFVsjn9pDYKRKDnCXNosMDS5KUktOFoWPN7FLkfPZ44QRqRZPEGBgQASR9Jz c20/Bs9CaxK+cG+af3xzp6Fpw+8BfzpeMzrUNzmQB1M8GA2Yc6tZua1dD5RZmuXvhDxG pqMv9H5Ri9c0b9CVi1Tc7/ifK/LwCAxoqWveSYmgcEh7OzrUzE3KKqtmceD+XXvTApMq OJYc8cOAXFzAobdr6OdN1lH9iBB8fEWD32+qnxE3rwlg1WtyUtoyX80LEvldfPGktDx7 qkVGU8ngkExwrjJwiyIxwXy9GXIWSitULsMr3d36Df7lq6BraaqqiQ/GH1n7y/bGEoOh cX/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=RNJGJBGWdFwLryor0mWPeSWJeo2NxCSVyATuSag7RIE=; b=gexp+bIYUiGThady+8BCH3yfUAcgq72D4CnvtQsSeqR61qm26BE28khDTBLdBk+5VR odmUlABzg1NuGgMyDIrJ0P4Ki470F+gAZPKxXyOVS3xVxNnhbLbIFHwSgp7VIG5qJlh+ 1odaryxhKUqnUAbnHen+A1VpG1jbXBIeiBAUbjJp6f7XE5qYgJ+sbcjVg+K90iPekaGK 1Oy03qPABatMGqWeqGrufnw6Oo0HZeAyuollGVFNMLL4cJebmmRYzVwMpKjNIzDdzwyT ODX1cjLRgPt+vHNh6iUyP3Cf43nnpMaRlayRr0XMgbnEvrfFmKfOjapW2h7OiS/U+eMd V0Hg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id jz14si1891684ejb.0.2019.07.23.08.08.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jul 2019 08:08:55 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x6NF8thj002586 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 23 Jul 2019 17:08:55 +0200 Received: from [139.25.69.208] (linux-ses-ext02.ppmd.siemens.net [139.25.69.208]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x6NF8tfr011438; Tue, 23 Jul 2019 17:08:55 +0200 Subject: Re: [PATCH v2] meta/classes:Add wic tooling for related images To: "[ext] Quirin Gylstorff" , isar-users@googlegroups.com References: <20190723134947.20714-1-quirin.gylstorff@siemens.com> <20190723150445.31970-1-quirin.gylstorff@siemens.com> From: Claudius Heine Message-ID: Date: Tue, 23 Jul 2019 17:08:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190723150445.31970-1-quirin.gylstorff@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Wgu30DQEmJMf Hi Quirin, On 23/07/2019 17.04, [ext] Quirin Gylstorff wrote: > The dependencies for wic are only added if IMAGE_TYPE > is equal to "wic-img". If a image type depends on the > wic-image class it is no longer possible to build a > wic image. > > Signed-off-by: Quirin Gylstorff > --- > meta/classes/image-tools-extension.bbclass | 6 ------ > meta/classes/wic-img.bbclass | 4 ++++ > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/meta/classes/image-tools-extension.bbclass b/meta/classes/image-tools-extension.bbclass > index b8672d5..ca94d49 100644 > --- a/meta/classes/image-tools-extension.bbclass > +++ b/meta/classes/image-tools-extension.bbclass > @@ -14,12 +14,6 @@ IMAGER_INSTALL ??= "" > IMAGER_BUILD_DEPS ??= "" > DEPENDS += "${IMAGER_BUILD_DEPS}" > > -python () { > - if d.getVar('IMAGE_TYPE', True) == 'wic-img': > - d.appendVar('IMAGER_INSTALL', > - ' ' + d.getVar('WIC_IMAGER_INSTALL', True)) > -} > - > do_install_imager_deps[depends] = "buildchroot-target:do_build" > do_install_imager_deps[deptask] = "do_deploy_deb" > do_install_imager_deps[lockfiles] += "${REPO_ISAR_DIR}/isar.lock" > diff --git a/meta/classes/wic-img.bbclass b/meta/classes/wic-img.bbclass > index 94f0b02..f3c29dc 100644 > --- a/meta/classes/wic-img.bbclass > +++ b/meta/classes/wic-img.bbclass > @@ -11,6 +11,9 @@ do_copy_wks_template () { > cp -f '${WKS_TEMPLATE_PATH}' '${WORKDIR}/${WKS_TEMPLATE_FILE}' > } > > + > + > + Well that looks odd ;) Cheers, Claudius > python () { > import itertools > import re > @@ -78,6 +81,7 @@ python () { > > inherit buildchroot > > +IMAGER_INSTALL += "${WIC_IMAGER_INSTALL}" > # wic comes with reasonable defaults, and the proper interface is the wks file > ROOTFS_EXTRA ?= "0" > > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de