From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7071266692367646720 X-Received: by 2002:adf:fa87:0:b0:203:f28e:76c3 with SMTP id h7-20020adffa87000000b00203f28e76c3mr18388672wrr.579.1647957708544; Tue, 22 Mar 2022 07:01:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:15ce:b0:1f1:dc97:d9c4 with SMTP id y14-20020a05600015ce00b001f1dc97d9c4ls190970wry.3.gmail; Tue, 22 Mar 2022 07:01:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6LBBWiVixSqBxrKM+1+ULsdh6VIZakzOi534aq56FhHiWHEb/4u6KYpiKOq6SQNdtebvV X-Received: by 2002:adf:f442:0:b0:203:e0ef:32c9 with SMTP id f2-20020adff442000000b00203e0ef32c9mr22847387wrp.53.1647957707540; Tue, 22 Mar 2022 07:01:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647957707; cv=none; d=google.com; s=arc-20160816; b=dteVi+kWdZwHqvK8YAqtvliY2RZF3DLXTjneTt/vZMZybjQuoytGGMT5Jw+zz5NuGk Tj2C1YL5iFM0drpBmm/OZAABFIUj8f2g8dhPNGKhX2Pbn1yV956oL4tuBbUsR/mqWhLO jHG61zD7nLdWGqWj2dtFsJKH9LNaKowlLhof/MA6HuRiGqKG0/NMuCJdjnh96eBsxb9l HjmmFx/y/+WaXEM50mfm2n43oP/iL6yAKcxstPPMQ/DMVZhrPmlrA08SIl/4hqkZ4xXB Fzc1VcxLC2u2t9hof3kup29kx1bQsfiiZT1tAJhqz0m9rCUueBVljyoSPp25fVQZDabn +yZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id; bh=qDWMyixCiF3vgjtD3shOPc9eyLXvw9kP7F8W/Zm/jes=; b=BmsagNyfUj/F1ku1OHfCqrr25spbSMFchdTSq1MwIm8KlY7Xsplvj5AY6pHpKxVP2i R5/GQd3f9RE1vUuRoBt2sXptpQk2WPCSJ2jTLLhgUKl8TT35o2EbbB5GDg5Eu5hLRXC5 Cz5sYMu0DfXmiHCxl4eBs9DKSGcZJi1Mg8LF3E1JsENDClY1C7iYiiq0CV7eQicPgA95 EEWyQkclpwtrhIFYNKrn1RqqhxnzXXMau1/06Kou2Q6anPPfJZqO7CTpgBlvTi8WWFwg IBLStopupTZePHT82sGSyWRWzgBfh7NmYgjo1rsiTokL3uV/pXYo582OBeKTuU50hUFK CSdw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id h81-20020a1c2154000000b003819dad2a19si201596wmh.2.2022.03.22.07.01.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Mar 2022 07:01:47 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 22ME1i6N017672 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Mar 2022 15:01:46 +0100 Message-ID: Date: Tue, 22 Mar 2022 17:01:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 0/6] Add support for dual bios + efi disk generation Content-Language: en-US To: Felix Moessbauer , isar-users@googlegroups.com Cc: henning.schild@siemens.com, adriaan.schmidt@siemens.com, jan.kiszka@siemens.com References: <20220307064252.651695-1-felix.moessbauer@siemens.com> From: Anton Mikanovich In-Reply-To: <20220307064252.651695-1-felix.moessbauer@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: VzILrMPyCGTq 07.03.2022 09:42, Felix Moessbauer wrote: > This patch ports the bios + efi disk support from OE to ISAR. > By that, the generated disk can be booted both with EFI as well > as with PCBIOS. > > Please note, that patches 2 and 3 do not work independently, > but are split for easier refactoring of the isarpluginsbase class. > > Changes since v1: > > - minimize changes to bootimg-biosplusefi-isar.py > - replace erronous commit message of hennings commit > - rework efi-plus-pcbios WKS file to not include any bios-only options > - update start_vm script to support modern debian distros > - test boot of both efi and bios of efi + bios test target > > Best regards, > Felix > > Felix Moessbauer (5): > Add ISAR version of biosplusefi WIC plugin > test: add target for efi-plus-pcbios image type > add support for current debian distros in start_vm.py > Add pcbios option to start_vm > run vm_boot_test against EFI and PC BIOS > > Henning Schild (1): > wic: make import isarpluginbase work when plugins use each other > > meta-isar/conf/multiconfig/qemuamd64-buster.conf | 2 ++ > .../scripts/lib/wic/canned-wks/efi-plus-pcbios.wks | 6 ++++++ > .../wic/plugins/source/bootimg-biosplusefi-isar.py | 8 ++++---- > .../lib/wic/plugins/source/bootimg-efi-isar.py | 6 ++++-- > .../lib/wic/plugins/source/bootimg-pcbios-isar.py | 6 ++++-- > testsuite/start_vm.py | 14 +++++++++----- > testsuite/vm_boot_test/vm_boot_test.py | 7 +++++-- > 7 files changed, 34 insertions(+), 15 deletions(-) > create mode 100644 meta-isar/scripts/lib/wic/canned-wks/efi-plus-pcbios.wks > It looks like 'Copy efi-plus-pcbios script from OE' patch was missed from v1. Please also rebase CI changes on top of the latest 'Unify build and run test cases' patchset that will probably be merged to next tomorrow.