From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH 6/6] patch: Replace custom implementation with OE-core solution
Date: Wed, 11 Dec 2019 15:26:30 +0100 [thread overview]
Message-ID: <cfea847b-9d55-4965-ad7d-5106e64ba6eb@siemens.com> (raw)
In-Reply-To: <20191211142139.6xe6ot7lwnqrxrow@yssyq.m.ilbers.de>
On 11.12.19 15:21, Baurzhan Ismagulov wrote:
> On Tue, Dec 10, 2019 at 07:34:25PM +0100, Jan Kiszka wrote:
>> diff --git a/meta/lib/oe/patch.py b/meta/lib/oe/patch.py
> ...
>> +def should_apply(parm, d):
> ...
>> + if "minver" in parm:
>> + pv = d.getVar('PV')
>> + if bb.utils.vercmp_string_op(pv, parm["minver"], "<"):
>> + return False, "applies to later version"
>> +
>> + return True, None
>> +
>
> Applying: patch: Replace custom implementation with OE-core solution
> .git/rebase-apply/patch:478: trailing whitespace.
>
> .git/rebase-apply/patch:1167: new blank line at EOF.
> +
> warning: 2 lines add whitespace errors.
Might be upstream imported. Then we should not deviate. If not, I'll
send v2.
Jan
>
> Will have a look at the other patches. If there is nothing else, I could fix
> this one in my branch.
>
> With kind regards,
> Baurzhan.
>
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2019-12-11 14:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 18:34 [PATCH 0/6] OE alignments, including patch.bbclass Jan Kiszka
2019-12-10 18:34 ` [PATCH 1/6] lib/oe/path.py: Add GPLv2 header Jan Kiszka
2019-12-10 18:34 ` [PATCH 2/6] oe/path.py: copyhardlinktree: don't overwrite existing symlinks Jan Kiszka
2019-12-10 18:34 ` [PATCH 3/6] lib/oe/path.py: Align with OE-core regarding sparseness preservation Jan Kiszka
2019-12-10 18:34 ` [PATCH 4/6] lib/oe/terminal.py: fix gnome-terminal start behavior Jan Kiszka
2019-12-10 18:34 ` [PATCH 5/6] oe.types.path: Use with to control file handle lifetime Jan Kiszka
2019-12-10 18:34 ` [PATCH 6/6] patch: Replace custom implementation with OE-core solution Jan Kiszka
2019-12-11 14:16 ` Jan Kiszka
2019-12-11 14:21 ` Baurzhan Ismagulov
2019-12-11 14:26 ` Jan Kiszka [this message]
2019-12-27 12:50 ` [PATCH 0/6] OE alignments, including patch.bbclass Baurzhan Ismagulov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfea847b-9d55-4965-ad7d-5106e64ba6eb@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox