From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6768880775710375936 X-Received: by 2002:a2e:80cc:: with SMTP id r12mr2278414ljg.154.1576074393208; Wed, 11 Dec 2019 06:26:33 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:82cb:: with SMTP id n11ls336502ljh.11.gmail; Wed, 11 Dec 2019 06:26:32 -0800 (PST) X-Google-Smtp-Source: APXvYqzV6XTez0zOutv1xOfxT9PMFfKz1UVa4S+2T9MPvJ384CpXa8Y3QpyjM9fqp1o1BD1Ug5Rr X-Received: by 2002:a05:651c:321:: with SMTP id b1mr2317162ljp.62.1576074392545; Wed, 11 Dec 2019 06:26:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576074392; cv=none; d=google.com; s=arc-20160816; b=Ktu1O+i+nTuGVsKMNIqJ6oREuiOcqeskG0AayiwkYAn5V0/riz2BIqoKFS0LOcIFjn P/tthzHufRsj1xWtDi+OPum+QmdNcIkUz/DKrhOK1GTj97MUmIRhWjLq8ySYUV84Cdfn 6QQk0ltWB90IOOz5IRiVOc41PjHltu4f6BzbD6blaWZ1KXSSdlkYgqbCPf1MqSsFdKzy pFCkeymp4frl5+uWsAP0VuKTSLjhvuTNrAaMdP/TGzpSk/kauDNiw0/e9JsbiO5yfVRP 1rSLs0+S4PBHGFB0aLtyh2mKRvdfpVPauV2K90vGV51SZsBE/DL88MSuJlKWju2v2xF+ m5Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=2ysrE8HX0WR6xTSXOnzEfRslwYREVBKQY4PHb2xuDCc=; b=n5/ssL4TmKyEq+IlU7y37v9zisZoX+uN9o8YcXvg46+au2AKz6S+Yq5QJ+xI8/MgK0 fcwRlMsYJDNiN/ZdAcB5pI17hu/cr+Zqt5DA71tIGurRcvbkCepzfMQjQ4lwoOpBzR/4 jJsSqszZWrCeKHGCkOtcRnfC5zypoiVJOzEgYsVXQcK1GPNbWtoE+zhK9DpBUizy+Bv4 Ov1gjgwmFeJwVNmAbx4XXw+773QDKEYyU6B55HGoDmvVPbCIGLTZD3jggkJXa4Zap9+4 fM4TtJkQoan15BaCydKcyiUyofGwEdHdzCuuyRMqiK2V3Ryl3wbyPXGI1984RbKo3Hd3 axBg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id o193si82133lff.4.2019.12.11.06.26.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Dec 2019 06:26:32 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id xBBEQVIC029532 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 11 Dec 2019 15:26:31 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id xBBEQVrv000444 for ; Wed, 11 Dec 2019 15:26:31 +0100 Subject: Re: [PATCH 6/6] patch: Replace custom implementation with OE-core solution To: isar-users References: <20191211142139.6xe6ot7lwnqrxrow@yssyq.m.ilbers.de> From: Jan Kiszka Message-ID: Date: Wed, 11 Dec 2019 15:26:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191211142139.6xe6ot7lwnqrxrow@yssyq.m.ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: DXImnnKFFV9z On 11.12.19 15:21, Baurzhan Ismagulov wrote: > On Tue, Dec 10, 2019 at 07:34:25PM +0100, Jan Kiszka wrote: >> diff --git a/meta/lib/oe/patch.py b/meta/lib/oe/patch.py > ... >> +def should_apply(parm, d): > ... >> + if "minver" in parm: >> + pv = d.getVar('PV') >> + if bb.utils.vercmp_string_op(pv, parm["minver"], "<"): >> + return False, "applies to later version" >> + >> + return True, None >> + > > Applying: patch: Replace custom implementation with OE-core solution > .git/rebase-apply/patch:478: trailing whitespace. > > .git/rebase-apply/patch:1167: new blank line at EOF. > + > warning: 2 lines add whitespace errors. Might be upstream imported. Then we should not deviate. If not, I'll send v2. Jan > > Will have a look at the other patches. If there is nothing else, I could fix > this one in my branch. > > With kind regards, > Baurzhan. > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux