From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750187537661165568 X-Received: by 2002:a5d:46d2:: with SMTP id g18mr3881071wrs.245.1572023709385; Fri, 25 Oct 2019 10:15:09 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:12ca:: with SMTP id l10ls6520608wrx.16.gmail; Fri, 25 Oct 2019 10:15:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqy9cn3zJyyuX96HloGVgEZGYvH1IpRJhDnc0Z5dCaaxCkUeEJVFeMKbkrUEWrPP8XpZABJE X-Received: by 2002:a5d:4902:: with SMTP id x2mr4280945wrq.374.1572023708698; Fri, 25 Oct 2019 10:15:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572023708; cv=none; d=google.com; s=arc-20160816; b=BP3dL9ItlJ2XPNJ5EN8qXiubf/SUv2+wqWD0EOXFZeHSA9pKzjXa6Fx39MBvbfFWrj hElO2r1i2nF1WNudIXgtHwZij1R5I3KOye88YJSeYoUG5Zau3qBvXBtTOFNe2qIpfGId zpUBXc2XOslnPBrIJiQenBySPD3Jz9r9fEf6fZ9X6k+45KaOHwyURrt2jQzxFtARgyjt huNJHZ2PLw5rqEMWksJDiVPVIr46X9ZpYB3SsSkopoX+sEsJlHPLzqERgW/js3KwfOVK 5kBiRMX+6uj+8VNwtZJu15hjKtm6jOaVk6GWdZ2GAFu3HwpPIT5nqeIJeTl6x/oRyOIX E9nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=gsKtCke7RYcyrzwEtR1iqnBIxjhCN8BlBfH0t62tjKY=; b=WfrTB0nc33+LxFGQFKL8i7bPSoHkk0KpS9ldrIAxpwIMfpLbCKJZh3rD1xT1qtGmWi cGbTur0CvjvVG7Od469O5BlLDyNivNz9tfEGxl+X17n+zYDUTyGttwTMK/tufNmHNpU2 diTFaLDIHi2yw+bSQvVZyq87ArZv/em1h1w5sZ6JwhXWAKKnp+JzAm6F1FeIWzToFUK0 dkTwhKxyOgBaCgrtD0SJvTqGUV6Fh+1td3EZPeY+mmAYmluHJzu/O03PlPb2lq2mfQLd BzMmu4eBvfhtaRHteiz8yjArdAcjMMjqTaOO659lYJQTyi4osudIojKb69iihgiW4DxS 9G7Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id z8si144759wmi.1.2019.10.25.10.15.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Oct 2019 10:15:08 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x9PHF8Cf019165 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2019 19:15:08 +0200 Received: from [167.87.2.122] ([167.87.2.122]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x9PHF7Mv000721; Fri, 25 Oct 2019 19:15:07 +0200 Subject: Re: [PATCH 4/4] patch: suffix patch files copied to .applied_patches with "~" To: Cedric Hombourger , Henning Schild Cc: isar-users@googlegroups.com References: <1571650494-572-1-git-send-email-Cedric_Hombourger@mentor.com> <1571650494-572-5-git-send-email-Cedric_Hombourger@mentor.com> <20191021132652.2de4c080@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: Date: Fri, 25 Oct 2019 19:15:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: pF9qFAScl0GP On 21.10.19 13:36, Cedric Hombourger wrote: > Hi Henning > > On 10/21/2019 1:26 PM, Henning Schild wrote: >> I think that whole patching keeps the files so we can roll back and i >> think Jan wanted to somehow continue working on it using quilt. > > Ok the last I heard from him is that he felt that the approach he had > implemented and upstream'ed was far easier than having to implement > something ala Yocto. I guess we can let him comment? I was wrong, the current implementation is too broken. You can trigger that by patching a tarball archive and then triggering an unpack followed by a (re-)patch. That's why we need a mechanism with more robust rollback support - i.e. OE quilt. That said, this suffixing is Debian/Isar-specific and will "only" need adjustment when porting the OE patch class over. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux