From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7174822613449965568 X-Received: by 2002:aa7:c719:0:b0:46a:bfd0:f816 with SMTP id i25-20020aa7c719000000b0046abfd0f816mr21646262edq.277.1670587011858; Fri, 09 Dec 2022 03:56:51 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:4413:b0:46d:d0c2:969c with SMTP id y19-20020a056402441300b0046dd0c2969cls682739eda.1.-pod-prod-gmail; Fri, 09 Dec 2022 03:56:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf65EXho5aNf8if8S2HlbS8KGOHv83EgM86sDNqrYWuts/FgUSjDd8WmZkdzVIAT/1KjLjPh X-Received: by 2002:a05:6402:2b8b:b0:468:58d4:a0f2 with SMTP id fj11-20020a0564022b8b00b0046858d4a0f2mr4336732edb.23.1670587010462; Fri, 09 Dec 2022 03:56:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1670587010; cv=pass; d=google.com; s=arc-20160816; b=DahbkbE3XQJVh7fuV444/iCypFswGXxu18ERCP9gHe5hx4QHr8L0SUlq65Ns5EKwpi ZAuzikRTIptNI1ogYOwoWb+Hk+TXeYhOd5QOtlzy6F49kgef/D37Tkto1Mu/VZyRNAQZ mhcRcPISAca7W1dOYkY85sPXI51KvzaOzBSgyxwpshZuUa/7/zDexoznQVjDdH5/yPv1 IhUIG3MQWow6GAhwneOCQzHMKY2L13EYCxLK2sxUJYTRwZ4PwomwOrjwUB3I0PD/Tpog qJTeIU8eljgo5b6EeGp4zGzcadfUX0K5XVE4Q33p/rHjD4wH+fJTfXNhtEl76du23Zr4 moOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=CTHrXfTVVuoaMiuWlkvmsesciEiAMIPYOs3CtODqt7g=; b=NkmN8QVkl5IeeMT4Hp4jParkvmqKxSQQJW1gt0IQJYiOUX1s7xV2sOF4aYBPcEEhjO RtN3B9ujw+MB2iFZpCB55pP3HWm2ETX8Jzt91/VYNzFC0z23HIGlmGyImfgDCYYCg5eO 3q7Sh8WrOB21GdMKKQuiGBE7r1K+bOx9OLzuxMXFStg9qm5qOuIcYXOaVSqJCxXtPDzv TOiYOaUiWmJ1HfUs4HtOdilh/tKz7+giI/9hmOa7452IfXBMaIfcHCbTOHgymSp77CxJ +3nmm3ZsaDm8OykS3N3AY1Hs2zSwEiu89aR3SSA32fDARmM6P+VM7w/VpE4pzkhsfA4p lq1w== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=Qi2uwQmu; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::615 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20615.outbound.protection.outlook.com. [2a01:111:f400:7d00::615]) by gmr-mx.google.com with ESMTPS id bc15-20020a056402204f00b0046c3ce626bdsi66632edb.2.2022.12.09.03.56.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Dec 2022 03:56:50 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::615 as permitted sender) client-ip=2a01:111:f400:7d00::615; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=Qi2uwQmu; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7d00::615 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aTyKU569vnDNeWP4nYbL1P6gg6kkRFMBT6P4DePTIdKKmtB3SFdwS8hby5/cdfilf48p77dJQ/25ncEIYeIpiwPzn5boyFEhrPS3mx4wwGu1HD9+QOuHC1eBEwo93W2Oat3fvKL+YVRK5rgf+IsKHpChoOceGfS/6FdLboUKSVaf1hSIw/MoToPIC0WUNFt+1Be5F2/kEx+B+ccEqDBW5OOPSa4xtYp6tHwhLh5wVDjD4KD822IR9yAoNDEBLe9I+LoGsSP9zWUdvrj6TW8m31uQ26OwS/YwfVMj+TVQ79AXolOnNOMio/cYQ9Q0SSp0+9PU7qcriN+2bAMt7H3Ytg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CTHrXfTVVuoaMiuWlkvmsesciEiAMIPYOs3CtODqt7g=; b=mFWZhXLkAZCpagv4m6nmn5/7F/iv4Q9Nt5twDBWqlm7bhx3vcAWk4moZuULP5r3HFYC3LH1E2fTEV1+CTQt2WZUuPlDiNPjrZ0AgS/zqMoEfdKzdMmJSbANjRQ3VAi2l54tP4cXfyvM9gPK0kalXTlMUFO+3LXtAnLFKoe2vDtSqnqdMdSzCPJfNSg51EIBd60B2z6Ud5rVG18fg6RLOntrei1dxUpjAkNxkwrZ08e615d9dTmidvGcc9iN3qv/C8ZUIMUvkhM1ocpVDhI/21WyPWXTrrw8BeqZLiT+Ptt3EQTOne1Kd5OBJLaBuOLp6GIfZHZ6WDFexIhRuwYLS6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTHrXfTVVuoaMiuWlkvmsesciEiAMIPYOs3CtODqt7g=; b=Qi2uwQmumcdOUtZ093YVs6VjAILji50q2T2v8U28yaWsVShnwlUi6X3vgrpvW7bagOEFEvkQ4hAZdW62TI+2PDbmvnpmLg4pjtLiwJjDRXmwkQufaBnW5trCF857scsUoGijmthZcTmHJ/GOOePwRuIphPteB7/DeHIcNP3Fx07JIo508Sa6BYvoEf1Kuk5HqaT/7fO16oGYCg4PHIlEb7cZq/S2qvFukegGLHLOV6hoMX+zmejW80Da6JQ3AL94y3aJiG4T4G1Kq6Mj9c62s+7qODPPYVsYDImfUH8yywv8uQaLf3ZAhl2wUy8LhLE869n5bvqDuV9OU8RXgiNdxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by AS1PR10MB5192.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:4a6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Fri, 9 Dec 2022 11:56:48 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::2957:50e8:8ce6:124a]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::2957:50e8:8ce6:124a%9]) with mapi id 15.20.5880.014; Fri, 9 Dec 2022 11:56:48 +0000 Message-ID: Date: Fri, 9 Dec 2022 12:56:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 1/1] expand-on-first-boot: wait for udev to create symlink Content-Language: en-US To: "T. Schaffner" , isar-users@googlegroups.com Cc: henning.schild@siemens.com, felix.moessbauer@siemens.com, roberto.foglietta@gmail.com References: <20221209112441.87669-1-tobias.schaffner@siemens.com> <20221209112441.87669-2-tobias.schaffner@siemens.com> From: Jan Kiszka In-Reply-To: <20221209112441.87669-2-tobias.schaffner@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0027.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::14) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|AS1PR10MB5192:EE_ X-MS-Office365-Filtering-Correlation-Id: 338b83c3-6bb6-48e2-96b7-08dad9dc735d X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: od99vC4/aIwmUD4OYPcms/eAAgeY3ZpARPhOnbL53l1l0RE5cFStc19mVLPs/ZSe99eiOOPjzg0haL2hqyb5EaJQOajHfHrGb19zzwr7UrpWj1RB/S88dRJzx9fXWolxmawM+JGufHRO0I/BlJAjy5+qPmcitTrHci3bk10qIO0QnCKF8TUcGkXsTGLHi2P3IvK3tYICd0bD01YfMadQidf0PaGBJo70O7t8wSnpCbAwgkuc8C/EGcs/jliP2e3GJ+iXI5sJ5/Hy4TTYCJCqNfiBWhecg0P5KnxpWsL+8sspMojjYHcJK33famS0LeBov5cAjqqZ4xVt2Kaegijt73J2PPdRg4ZftDB/B4S/nLmVRZKG9mJAEJafI3mHOM2uqd9GtERCNPQ0BrzHKmniSR2u+e2HMseovVFXYWCMN0J51/lzZU4U7BGcgfC+iuEVLOUp5N8R8hqR/97eZVEou03xYeWy9CQE0FmCVP8gu4L7CG3LBnUf6rKu0BO575J6I1VcyHxRmNVNam+lPeT8t5KTG3Wr40IQ4znBhXftpFLexoPqB9PSAf1DupXAdpvnDcKWOB8PRlGuPnomfpmvCadibBkdc9DVHsRUGO/vj7tQSKWgHODiiOm/29bXe5x31SLrNALhwNrBmYfqTEkvzClxbcqkFZPghBRywik4hhc8VjEJkZI+BXpPbn02T+dh87xfGC9RsDdPGA7Bu7vF0a12yQzPnPQ+bOmdOEtVHG4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199015)(83380400001)(44832011)(41300700001)(86362001)(8936002)(38100700002)(31696002)(4326008)(6486002)(2906002)(5660300002)(6666004)(8676002)(53546011)(186003)(6506007)(26005)(66946007)(6512007)(478600001)(66556008)(2616005)(82960400001)(66476007)(316002)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3NQaTlMUUhVSDBQMU11VHovVXl5M1pMeDdVY2RZblJHV2hGMDZOMFJpd2Vt?= =?utf-8?B?QjVML2NmNGU2eFVJZHcwL2pVbnJoUC9ZMkdHZC8yTktlOE5CNmpxaXJBY0lS?= =?utf-8?B?WXpHbjBvSTJkV1lUbG1IL0tYbVF4alZQVEozTjVmVWFmSWZtc1pNY2Y3U0Vv?= =?utf-8?B?TEphY0g0M2FxUzRrKzdLUkt2RmlzYTF2bEdzOHhkaTduMGJJYWF5ZkFmUWwx?= =?utf-8?B?bkpoZ0tBU2NFV1pzc0VONzl2MzdVTGcwN2NRbllwTlNDcjVDS3JuNkZCQ3Yw?= =?utf-8?B?c3VvUWtwZUVLcGtHTE9yV0luTnh0bVJhU0tIK05kUm1HRFk5alFDWS9qc3ZZ?= =?utf-8?B?Y3VIVUJtVE9YazF0Z3BQc3NVaGRiWGRBK3lNYlJXMjJOc1pVbFl1b3JmbHl2?= =?utf-8?B?YjBpdExTTTk2dGVtZkgxYXloaC9MV1lodGtVVHpWSWsrWCs0YnQrYmEwT2ZL?= =?utf-8?B?K2ptUjdHcnE1S2h4dXFSUUJBZGs3V1Q0clUwS240MFNhWmhmc3ZHWkN3U1Zo?= =?utf-8?B?THRCLzlkUUlvaFFGZ0FKUTdpbFBqRFZpZWw5VVAxZWNROWk3dXZ6ckVrSVQy?= =?utf-8?B?bldxWDVHdzdXcHE2bWhJMmhXbHZLeUlHSTFrWS9EUDRQTjk5RmVrUWFaL2lS?= =?utf-8?B?V0NnZUN2ZTZ3NUxQSjZxVmZ0SzJ3dnVlOG12MjZ1NE1Pcms3am4rK25KS3Y1?= =?utf-8?B?U1hULzRmQzRlUGV2ZUdMdVUzMDdOUTZsNlhUeXVRcldWOU55dngreWd4RG85?= =?utf-8?B?ZkV3NDJBRFZpR0hFMS9BTm5XMmxKYk9oRHVZd0dYWFhrWEZqbWgxTVRpcnZm?= =?utf-8?B?T3dnR1lPdC9PUXl5Z0VtQ2RIeGcwT3p2WGhFNlVFOHVVTFNVN1I3aFhQZUhZ?= =?utf-8?B?R1hZOXBuNXFxNTRLam1tdU9RR3pucU9EYi9PWmVyYlNTdTZBV0toZlVWZk80?= =?utf-8?B?b081Vm9jcTU0MkhQaWN4VVZKOWRHc2hyTFNmam5UamJjTW5FZEoxejhRaGpL?= =?utf-8?B?VldtODdLeDVlVmZqU1NjaDliVkp6Q3p4akE4MnlsdDgyaVJJbXBrZGdwZkl3?= =?utf-8?B?TGszVzkrc1A3R2VVUHR0QUJ0MGVZSmkxR0hUdm9VWlRnNzlOdVNLdEd0cTFq?= =?utf-8?B?U21tME00eWl3dmJSYmN4ei9aME50TmxSTHpyV1dQVWtaNVlmZUJIWFVtb0Ev?= =?utf-8?B?cW15VUU0N01rYUVSL3A4SEl5THdJRHVyaWc4V1JuMlZEdnlzT2xCOFl2b0tu?= =?utf-8?B?YkhjMkpsdnFJcTJ4SWw5Sm50NVAxQUI0Tk9nODB6UUgxMmVTcElzd2FwNGVh?= =?utf-8?B?eEd2QlhpS1gyczdaOVJsY0lVam9CMnNBWjdoN01PRzdOb2szRmNpMnVmWnY5?= =?utf-8?B?Z0l5QVY1Nmt5NitQN2NnUll0ZGt5TXVyQUFrbXA2SnQvRlVHMlZCekRMb2M1?= =?utf-8?B?MTJWSUhFblVEblNxNUFFVWRKY213NmlHdFkvOU1laGljUDB0TGpVTW5EWmhw?= =?utf-8?B?ZXRlTmhyejJ0WklWbTMzM1RtWmVUR3ozL3hsbVcycFh4cW4zSlFpY0RiS0Zl?= =?utf-8?B?S1ppQW5McHNadjR0QWlMY2VOaWgyeWYyUmFQMjhFVmJjM1VXTitrUkQzek11?= =?utf-8?B?UlV0eHo4R3pqODQ1VlV6YXdtMmM2TUFjNkM3RHlzR2xaRmJ3SVY4VnNqeXAw?= =?utf-8?B?ZGJqOWE0WEtqbENiQnNSYTVBZ2Q3bUtPSnk5bEowNGRZdm5VbHpBS2NLMkJo?= =?utf-8?B?YkNydlEyL1JxSWNSN0NIVm9Hck1HZ2c5K1BPWnBoRjlqcS9aU3VmaGJUVkJO?= =?utf-8?B?WWxJNGlLR3pjRDhWUFN4NlZTMjRUSld2VjFHdkNybGY3RDBGczFnYVlISnpV?= =?utf-8?B?NXpQUkQwLyswNmZWc1R5WjNOZjlIb3ltUmV4bGxsQmJTRVBKSm5Dc1gwZkV4?= =?utf-8?B?dkRCRVE5YlUrNUlzTjd1TW5Sd2FxTVdNU1BwMW04WSttWVhkSlZJUndUZUE1?= =?utf-8?B?K1pGWXkySFErN0VjYU5LUHZDZFpqemNJVTlmQ2RHK0VoSWc3anZUU0tnQjU1?= =?utf-8?B?c3QxV050Mm83RXJmSEtpSW0zN3QzZFM5WUQxZ3ltLzlmYTFWQU9aUXVCdXVi?= =?utf-8?B?QzZ5eVdoQzlGemJhQmRBemphYnNqcWZUNEJBM2ExMnFWVHZpYlBoTGxKdWtQ?= =?utf-8?B?eFE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 338b83c3-6bb6-48e2-96b7-08dad9dc735d X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 11:56:47.9454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1nw85ndXFQoBkSvFiOtMuYt8qUypf+n9uCFrUu7+znJP1czcmcarUrIJS3rvbA/x7B5D1md0/Ghp2n43CLDjMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR10MB5192 X-TUID: FzTick1/trEG On 09.12.22 12:24, T. Schaffner wrote: > From: Tobias Schaffner > > systemd-growfs depends on a symlink to the partition of the filesystem > that should be resized. This symlink is created by udev in /dev/block/. > > If this symlink is not yet created for example because systemd-udev is > not up yet systemd-growfs will fail. > > We could use Require and After to depend on the systemd-udev service > but this could again create a race condition if udev is up but not > fast enough after the partx -u. > > Run systemd-growfs periodically until the symlink appears. > > Signed-off-by: Tobias Schaffner > --- > .../files/expand-last-partition.sh | 21 ++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > index 57055cc..4d78e4f 100755 > --- a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > +++ b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > @@ -80,6 +80,25 @@ if [ ! -d "${MOUNT_POINT}" ]; then > fi > > mount "${LAST_PART}" "${MOUNT_POINT}" > -/lib/systemd/systemd-growfs "${MOUNT_POINT}" > + > +EXIT_CODE=1 > +# If systemd-udevd if not up yet or was not fast enough the symlinks in > +# /dev/block/ might be missing. Retry in that case. > +# This retry logic is only needed up to systemd-version 252 > +for run in $(seq 0 50); do > + if GROWFS_OUTPUT=$(/lib/systemd/systemd-growfs "${MOUNT_POINT}" 2>&1); then > + EXIT_CODE=0 > + break > + else: ^^^ ? And why else at all? You break the loop anyway. Jan > + if ! echo ${GROWFS_OUTPUT} | grep -q "^Failed to open \"/dev/block/.*\": No such file or directory$"; then > + break > + fi > + fi > + sleep 0.1 > +done > + > +echo "${GROWFS_OUTPUT}" > umount "${MOUNT_POINT}" > rmdir "${MOUNT_POINT}" > +exit ${EXIT_CODE} > + -- Siemens AG, Technology Competence Center Embedded Linux