Re: [PATCH v2 0/3] One-shot configuration packages

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Henning,

On 2018-05-23 16:03, Henning Schild wrote:
> Nice patchset. It follows the "everything that enters the rootfs should
> come from a package" approach. And it introduced a nice hack to execute
> scripts in the "last package", switching from the chrootable folder to
> the image.
> Things like removing qemu, resolv.conf etc could also be done in such a
> "final" package postrm.

I initially liked the idea about removing qemu with a package, but I 
don't think that is possible. After removal of this binary no commands 
can be executed in the chroot environment, and we still need to purge 
the package and cleanup the dependencies/cache etc. AFAIK it needs to be 
done from outside.

For removal of for hostname and resolv.conf I am not so sure. IMO that 
should be done before any custom package is installed. This way the 
deployment of those files can be done by any package and those files are 
managed by dpkg.

I currently cannot think of anything that should/could be 
installed/executed/removed this way apart from localepurge. But there 
might be more administrative tasks that could be done this way.

I thought about moving the locale config outside the 
isar-cfg-localepurge package, but since I don't actually deploy any 
locale config files, and just modify the debconf + reconfigure the 
locales package its ok here IMO. And it might be useful to have the 
whole locales configuration in one place.

Claudius

> 
> Henning
> 
> Am Wed, 23 May 2018 15:12:45 +0200
> schrieb "[ext] claudius.heine.ext@siemens.com"
> <claudius.heine.ext@siemens.com>:
> 
>> From: Claudius Heine <ch@denx.de>
>>
>> Hi,
>>
>> here is the rebased patchset that removes the issue with the global
>> localepurge configuration as well.
>>
>> Claudius
>>
>> Changes from v1:
>>   - rebased to current next
>>   - removed locale.nopurge setup in isar-bootstrap
>>
>> Claudius Heine (3):
>>    isar-bootstrap|configscript: implement one shot config option
>>    meta/isar-cfg-localepurge: added locale purge recipe
>>    meta-isar/isar-image-base: switch use isar-cfg-localepurge
>>
>>   .../images/files/debian-configscript.sh       |  9 ------
>>   .../images/files/raspbian-configscript.sh     |  8 -----
>>   .../recipes-core/images/isar-image-base.bb    |  6 ++--
>>   meta/classes/isar-bootstrap-helper.bbclass    | 23 +++++++++++---
>>   .../isar-bootstrap/files/locale.nopurge       | 10 -------
>>   .../isar-bootstrap/isar-bootstrap.bb          |  4 +--
>>   .../isar-cfg-localepurge/files/locale.debconf | 12 ++++++++
>>   .../isar-cfg-localepurge/files/locale.gen     |  1 +
>>   .../isar-cfg-localepurge/files/postinst       | 30
>> +++++++++++++++++++ .../isar-cfg-localepurge.bb                   |
>> 19 ++++++++++++ 10 files changed, 85 insertions(+), 37 deletions(-)
>>   delete mode 100644
>> meta/recipes-core/isar-bootstrap/files/locale.nopurge create mode
>> 100644 meta/recipes-support/isar-cfg-localepurge/files/locale.debconf
>> create mode 100644
>> meta/recipes-support/isar-cfg-localepurge/files/locale.gen create
>> mode 100644 meta/recipes-support/isar-cfg-localepurge/files/postinst
>> create mode 100644
>> meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb
>>
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de