From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Subject: [PATCH 3/8] Replace SRC_DIR with S
Date: Thu, 8 Feb 2018 16:05:36 +0100 [thread overview]
Message-ID: <d12b45ca8dc1527bcb03725d844c89afd46b9676.1518102341.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1518102341.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1518102341.git.jan.kiszka@siemens.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
This aligns us with OE/bitbake style.
Along updating the manual, also fix SRC_REV -> SRCREV.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
doc/user_manual.md | 6 +++---
meta-isar/recipes-app/example-hello/example-hello.bb | 2 +-
meta-isar/recipes-app/libhello/libhello.bb | 2 +-
meta/classes/dpkg.bbclass | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/user_manual.md b/doc/user_manual.md
index 969f6d2..0771d1e 100644
--- a/doc/user_manual.md
+++ b/doc/user_manual.md
@@ -513,7 +513,7 @@ PV = "1.0"
SRC_URI = "git://github.com/ilbers/hello.git"
SRCREV = "ad7065ecc4840cc436bfcdac427386dbba4ea719"
-SRC_DIR = "git"
+S = "git"
inherit dpkg
```
@@ -531,8 +531,8 @@ This approach prevents duplication of the license files in different packages.
- `PV` - Package version.
- `SRC_URI` - The link where to fetch application source. Please check the BitBake user manual for supported download formats.
- - `SRC_DIR` - The directory name where application sources will be unpacked. For `git` repositories, it should be set to `git`. Please check the BitBake user manual for supported download formats.
- - `SRC_REV` - Source code revision to fetch. Please check the BitBake user manual for supported download formats.
+ - `S` - The directory name where application sources will be unpacked. For `git` repositories, it should be set to `git`. Please check the BitBake user manual for supported download formats.
+ - `SRCREV` - Source code revision to fetch. Please check the BitBake user manual for supported download formats.
The last line in the example above adds recipe to the Isar work chain.
diff --git a/meta-isar/recipes-app/example-hello/example-hello.bb b/meta-isar/recipes-app/example-hello/example-hello.bb
index 9d83e4c..73cca0a 100644
--- a/meta-isar/recipes-app/example-hello/example-hello.bb
+++ b/meta-isar/recipes-app/example-hello/example-hello.bb
@@ -17,6 +17,6 @@ DEPENDS += "libhello"
SRC_URI = "git://github.com/ilbers/hello.git;protocol=https"
SRCREV = "86cc719b3359adc3c4e243387feba50360a860f3"
-SRC_DIR = "git"
+S = "git"
inherit dpkg
diff --git a/meta-isar/recipes-app/libhello/libhello.bb b/meta-isar/recipes-app/libhello/libhello.bb
index df5793e..1875831 100644
--- a/meta-isar/recipes-app/libhello/libhello.bb
+++ b/meta-isar/recipes-app/libhello/libhello.bb
@@ -13,6 +13,6 @@ PV = "0.1-98f2e41"
SRC_URI = "git://github.com/ilbers/libhello.git;protocol=https"
SRCREV = "98f2e41e7d05ab8d19b0c5d160b104b725c8fd93"
-SRC_DIR = "git"
+S = "git"
inherit dpkg
diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 9cd4403..06f0579 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -6,5 +6,5 @@ inherit dpkg-base
# Build package from sources using build script
dpkg_runbuild() {
E="${@ bb.utils.export_proxies(d)}"
- sudo -E chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR}
+ sudo -E chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${S}
}
--
2.13.6
next prev parent reply other threads:[~2018-02-08 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 15:05 [PATCH 0/8] Provide infrastructure and examples for custom kernels and modules Jan Kiszka
2018-02-08 15:05 ` [PATCH 1/8] Forward proxy settings to dpkg build Jan Kiszka
2018-02-08 15:05 ` [PATCH 2/8] Prioritize isar-apt repo over all others Jan Kiszka
2018-02-08 15:05 ` Jan Kiszka [this message]
2018-02-08 15:05 ` [PATCH 4/8] Install kernel via replaceable recipe Jan Kiszka
2018-02-08 15:05 ` [PATCH 5/8] Provide include file for easy custom kernel builds Jan Kiszka
2018-02-08 15:05 ` [PATCH 6/8] Add custom kernel examples Jan Kiszka
2018-02-08 15:05 ` [PATCH 7/8] Provide include file for easy custom module builds Jan Kiszka
2018-02-08 15:05 ` [PATCH 8/8] Add exemplary kernel module Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d12b45ca8dc1527bcb03725d844c89afd46b9676.1518102341.git.jan.kiszka@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox