From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6520199916203016192 X-Received: by 10.28.247.5 with SMTP id v5mr179551wmh.12.1518102343724; Thu, 08 Feb 2018 07:05:43 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.154.77 with SMTP id z71ls1481363wrb.7.gmail; Thu, 08 Feb 2018 07:05:43 -0800 (PST) X-Google-Smtp-Source: AH8x227ZlLt85W5NhDzxKOMD1fxfHOOWQBjtFneQwq1Sk5ctcnus64R+mGlsXSWZS3c+8J6Ey748 X-Received: by 10.223.166.209 with SMTP id t75mr154430wrc.19.1518102343138; Thu, 08 Feb 2018 07:05:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518102343; cv=none; d=google.com; s=arc-20160816; b=dTl25x4fli+IN3k+3HOk3VtSOyVg1kM5zIgplJw3A7D3RfDEMPc0BHD63rGV4nNnZo bIH6Ftgth4p80v23vVjvjOancmuK2nZs5/Y8mXnSubku429MoThvM25WqD50C7e5AB4g jmMV+oRWqu7kGbzUFSiaTWkeZzAtSWhVHp43I+S/j1s2h2uJtvz3y/eZXR5bV43kH09K CqaEBupwpHax03SMXJARzkLqYqkY/tfhIH2R5Rm94EC+BN2B0aqH7xeWQGxhs3jynikf M7KIs5WJgSSHccIwXgNwXyqv8AmNXcVXpHFxrKQj5+0n7QkwD3frKQk15192dcUIADS2 /GMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:references:in-reply-to:message-id:date :subject:to:from:arc-authentication-results; bh=PgSIZWiF3YjPR5rltgs2fXU8TVKWK1ANqPvR0J1mdos=; b=sFh5tqJ71HhwyqAXF11fcD8zW3TZTNb6lbakdqu7seIqoMez0BhP4eN86H+u6xa76G I7BnPPh3/2PQtVJxZP5RSPamN3KVpsB7CNCRkbCfw+p3kDFgeBOnJV7jAGngo6sDLN8P 2Yi6nbOrJit9iSCqnBdq5fbmVIfghtGerJctKtSpoL/DAFdAsWP3SL8bGWSC7OGmOhSE 5dLcc+LEgY1F4jXSijAblySPjfCVLtqKGVeyenWBJgY8QCr07ME4CEMs8o1q0KVZh4WJ EfBZm7ETDrYOy1apc0K/g0X6DxDbYmhZgbPE9SvdiYlJtqWYuBv1ZUQMc4Cvl0cI3fR0 6vOA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id f192si6421wmg.1.2018.02.08.07.05.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2018 07:05:43 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w18F5gZs014810 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 8 Feb 2018 16:05:42 +0100 Received: from md1f2u6c.ad001.siemens.net (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w18F5gaa010454 for ; Thu, 8 Feb 2018 16:05:42 +0100 From: Jan Kiszka To: isar-users Subject: [PATCH 3/8] Replace SRC_DIR with S Date: Thu, 8 Feb 2018 16:05:36 +0100 Message-Id: X-Mailer: git-send-email 2.13.6 In-Reply-To: References: In-Reply-To: References: X-TUID: NtbCsrDp/6WQ From: Jan Kiszka This aligns us with OE/bitbake style. Along updating the manual, also fix SRC_REV -> SRCREV. Signed-off-by: Jan Kiszka --- doc/user_manual.md | 6 +++--- meta-isar/recipes-app/example-hello/example-hello.bb | 2 +- meta-isar/recipes-app/libhello/libhello.bb | 2 +- meta/classes/dpkg.bbclass | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/user_manual.md b/doc/user_manual.md index 969f6d2..0771d1e 100644 --- a/doc/user_manual.md +++ b/doc/user_manual.md @@ -513,7 +513,7 @@ PV = "1.0" SRC_URI = "git://github.com/ilbers/hello.git" SRCREV = "ad7065ecc4840cc436bfcdac427386dbba4ea719" -SRC_DIR = "git" +S = "git" inherit dpkg ``` @@ -531,8 +531,8 @@ This approach prevents duplication of the license files in different packages. - `PV` - Package version. - `SRC_URI` - The link where to fetch application source. Please check the BitBake user manual for supported download formats. - - `SRC_DIR` - The directory name where application sources will be unpacked. For `git` repositories, it should be set to `git`. Please check the BitBake user manual for supported download formats. - - `SRC_REV` - Source code revision to fetch. Please check the BitBake user manual for supported download formats. + - `S` - The directory name where application sources will be unpacked. For `git` repositories, it should be set to `git`. Please check the BitBake user manual for supported download formats. + - `SRCREV` - Source code revision to fetch. Please check the BitBake user manual for supported download formats. The last line in the example above adds recipe to the Isar work chain. diff --git a/meta-isar/recipes-app/example-hello/example-hello.bb b/meta-isar/recipes-app/example-hello/example-hello.bb index 9d83e4c..73cca0a 100644 --- a/meta-isar/recipes-app/example-hello/example-hello.bb +++ b/meta-isar/recipes-app/example-hello/example-hello.bb @@ -17,6 +17,6 @@ DEPENDS += "libhello" SRC_URI = "git://github.com/ilbers/hello.git;protocol=https" SRCREV = "86cc719b3359adc3c4e243387feba50360a860f3" -SRC_DIR = "git" +S = "git" inherit dpkg diff --git a/meta-isar/recipes-app/libhello/libhello.bb b/meta-isar/recipes-app/libhello/libhello.bb index df5793e..1875831 100644 --- a/meta-isar/recipes-app/libhello/libhello.bb +++ b/meta-isar/recipes-app/libhello/libhello.bb @@ -13,6 +13,6 @@ PV = "0.1-98f2e41" SRC_URI = "git://github.com/ilbers/libhello.git;protocol=https" SRCREV = "98f2e41e7d05ab8d19b0c5d160b104b725c8fd93" -SRC_DIR = "git" +S = "git" inherit dpkg diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass index 9cd4403..06f0579 100644 --- a/meta/classes/dpkg.bbclass +++ b/meta/classes/dpkg.bbclass @@ -6,5 +6,5 @@ inherit dpkg-base # Build package from sources using build script dpkg_runbuild() { E="${@ bb.utils.export_proxies(d)}" - sudo -E chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR} + sudo -E chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${S} } -- 2.13.6