Re: [PATCH] add support for rebuilding essential packages

[Jan Kiszka <jan.kiszka@siemens.com>]

On 28.02.23 08:06, Cedric Hombourger wrote:
> 
> 
> On Monday, February 20, 2023 at 11:32:22 AM UTC+1 Adriaan Schmidt wrote:
> 
>     There are cases when we need to rebuild a package that is installed
>     during
>     bootstrap (we call those "essential package" here). This patch
>     introduces
>     `ISAR_REBUILD_ESSENTIAL_PKGS` which can be set in (distro/layer)
>     config, and
>     lists all essential packages.
> 
>     During build, Isar ensures that essential packages are built before
>     any others,
>     so that their locally built versions are available in isar-apt, and
>     will
>     be used in any subsequent package builds.
> 
>     Signed-off-by: Adriaan Schmidt <adriaan...@siemens.com>
> 
>     ---
>     This has interdependencies with the proposed multiarch feature,
>     and builds on v2 of that series.
> 
>     Adriaan
>     ---
>     meta/classes/dpkg-base.bbclass | 1 +
>     meta/classes/essential.bbclass | 39 ++++++++++++++++++++++++++++++++++
>     meta/classes/image.bbclass | 1 +
>     3 files changed, 41 insertions(+)
>     create mode 100644 meta/classes/essential.bbclass
> 
>     diff --git a/meta/classes/dpkg-base.bbclass
>     b/meta/classes/dpkg-base.bbclass
>     index 55cc6655..ce301346 100644
>     --- a/meta/classes/dpkg-base.bbclass
>     +++ b/meta/classes/dpkg-base.bbclass
>     @@ -10,6 +10,7 @@ inherit debianize
>     inherit terminal
>     inherit repository
>     inherit deb-dl-dir
>     +inherit essential
> 
>     DEPENDS ?= ""
>     RPROVIDES ?= "${PROVIDES}"
>     diff --git a/meta/classes/essential.bbclass
>     b/meta/classes/essential.bbclass
>     new file mode 100644
>     index 00000000..cb444674
>     --- /dev/null
>     +++ b/meta/classes/essential.bbclass
>     @@ -0,0 +1,39 @@
>     +# This software is a part of ISAR.
>     +# Copyright (C) 2023 Siemens AG
>     +
>     +ISAR_REBUILD_ESSENTIAL_PKGS ?= ""
>     +
>     +python() {
>     + isar_rebuild_essential_pkgs =
>     (d.getVar('ISAR_REBUILD_ESSENTIAL_PKGS', True) or '').split()
> 
> 
> ",True" should not be necessary
> here's getVar()'s signature:
> 
> def getVar(self, var, expand=True, noweakdefault=False, parsing=False)
>  

Yep, we still see this pattern popping up.

I fact, we have 85(!) left-overs of this legacy pattern in Isar. Let's
we write a quick patch...

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux