From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7202184025122799616 X-Received: by 2002:adf:e948:0:b0:2c3:be6a:7614 with SMTP id m8-20020adfe948000000b002c3be6a7614mr373156wrn.2.1677568752956; Mon, 27 Feb 2023 23:19:12 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:3b05:b0:3e2:165f:33d0 with SMTP id m5-20020a05600c3b0500b003e2165f33d0ls5866657wms.2.-pod-control-gmail; Mon, 27 Feb 2023 23:19:11 -0800 (PST) X-Google-Smtp-Source: AK7set+rR9L0pUsbNE9NQ8P/Dw27BumQKfwK5OzrVAqCikoMM/Yqbtioa98SebDXdc7EwJhCfZI6 X-Received: by 2002:a05:600c:1992:b0:3ea:f0d6:5d36 with SMTP id t18-20020a05600c199200b003eaf0d65d36mr1289369wmq.29.1677568751435; Mon, 27 Feb 2023 23:19:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1677568751; cv=pass; d=google.com; s=arc-20160816; b=zI5tdGtdVkHiZEwFnELnckxRG0gLuWDUDQXnQeaFld1/5h34z9UlJ1Rc0Ntu7eC9kS 4cQBwo+KdZJSRG2uxAjTybWQmfwZGnaSmjoO8hOXAbxWZ4n7CZmQ2HZdzVAF0h62qqKW x6UdWcbiJygVCVggUR3D/zYYR15giAOz1IYHLobpBCOU80nrotyf2allsRQ3dpt0yUG7 ddDyeCOGRaJQvm/7Nb23xxf/RGyDLwV4lPxBcqIJp1Z3OeuGmlIA2S0qAWxSLuHKFpPm JON9u3bTClPTokb5bwQv+0EqCxLKyyFAoCaZIwq8RiDfSPROs9Cjn/Z7tEk4kbeYQ1U3 Ggug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=UlFPrsQrN7EV+6lfa2mGYkpdLoWkTwrsU9f8DURa730=; b=0wJrEVGThpa12Wxpbf45BKh7WcN+U6GtMZ1tHQ6kVgI/wfk3PytzEcM1h/qki6PWok tkayfeMUvLadxkeN7jAJcfElXYr/meqvLTx1SWl/FJ0jc+bx7gVAiM7SQIJmnUK6L+Ll nS9LA3rfYQwzZS9Adprz7YSLvg6xODNm1xpHqRgChI0g+NfUBu+16FiG93DaDsqT4rJ5 4A+1NZ9k6CBbi0lJ8neLih+KqN1vevxaey7Es6Nvn86k6pPO8LQTWvgtK2ZhHTKJc+cR jkPZSlirdDxEBcpLTY7bri7/mqPxgiiimDVA3ZkJSzKRS3oSQIVziYFnvZiH9S5K31gn +YFg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ES3cAe0L; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe16::628 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20628.outbound.protection.outlook.com. [2a01:111:f400:fe16::628]) by gmr-mx.google.com with ESMTPS id bg16-20020a05600c3c9000b003e222d39e68si378968wmb.1.2023.02.27.23.19.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Feb 2023 23:19:11 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe16::628 as permitted sender) client-ip=2a01:111:f400:fe16::628; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ES3cAe0L; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe16::628 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=him++qTHyXescB2A31rhEigZdO2QM22+7caJiZamjUybnGIzF4Enoyw0cxa9efGHpGKamaccghLrXaKanAQZpl3uNSZxG89A70UQel7QybQNsRHWLpgKXIx6VrTTOpa0uCL1Y5R+r6ETeaiGjFNyVcE6yNFzu16uZpAshK+rpVF+mGgMz/jL6qhVXmcJOghmEm4wAush4dRGRTA1EI0e0Dcwu03X8xvYOJkmLh0DOUVCVvMudvc+sRuh0Fd6YllzSbdJqLbMP1CLNzowIwTojPX6/ISuS6HsiHKUtQp4shfYcgaLRCy6+nEI/YdwP4PjUb/RlmzKblB5lqctV48ihg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UlFPrsQrN7EV+6lfa2mGYkpdLoWkTwrsU9f8DURa730=; b=f3e+G85gygPft2e9e2kXCjCznHHSg4KHdGs+rnLk2ftkwBwpqsnKlBSBGu04UUijxnXATXcYjc1aL6wG5i1IRBpVniNBt16OdlXNP2G0XEOSFrUq8fSZz2HwYq5d6eyq81HNaPHH9x99vgAeb6CqtbAP5HhmcrbQw3maInseHnz1XPLgWxFnqgNuIxwZhHMUWEAP8Kf2540XnOCTKG9rkIz0HkLQvpOCciEPST69ElVNPGZaOjc/sXOrMXvW2e/wCxKktSIkYkZxdyLtmzjs+6j0ckzH04fyVPAYfbrBBaB5e+xS9H3x0V0mQjLuVk7M71UiReRUbE/sN/XU3NmBSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UlFPrsQrN7EV+6lfa2mGYkpdLoWkTwrsU9f8DURa730=; b=ES3cAe0LBIlKTRHonWOqm+1PE/G64wkG2MbEGbSsPp9MGp6/VVl1l/jsn251PhKahN4dqSouAz/CDBzpEusa2f8UpsJqm2P0SBOH2RIeGpM68OnnG9kIo7WbSFZVoWPd1J6zNiTNNmxfrj5jz02kE6AI3Wjoty25iBvJ+GLvsGm3pUdsIXTSkfMGzDeWlDY7EqfXk4tOMt9B7us/dgC8NmkxCR5dUvu18R0znTHnKY30jkQr929bDdPv+SGPxTdIxUlpJZ2AoGUqM0paP+zXh/TqGQx7OfOggv8EE7IuoWBcl6TzZI4AdGnmwiS4lqGWFa1hwAnPH9ga/zMFYoijCw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by DU0PR10MB6178.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3e9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 07:19:09 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5%9]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 07:19:09 +0000 Message-ID: Date: Tue, 28 Feb 2023 08:19:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] add support for rebuilding essential packages Content-Language: en-US To: Cedric Hombourger , isar-users References: <20230220103214.2704911-1-adriaan.schmidt@siemens.com> From: Jan Kiszka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::13) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|DU0PR10MB6178:EE_ X-MS-Office365-Filtering-Correlation-Id: db4ce4ab-4852-40ad-c4dd-08db195c159a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CEQgmL0FTlBGNbkRdnNBwqZcSc2tqzX/ZrkSKOxw6mQrU8CpCxJJn44t53pndUaMNhnrN6JeRmej1cPstFVgzm+XA1ghQv4LIGlEwpl3CqL1K8MSI1UT6L1B9bzntxSf2/zTJ8sJR9SV76fjiOie0L9fRLxOFEiWBqG1+ipyHxnQy20OSgva5abHrExjXOaWWZCKn4hdv3qtnYSFaXNJPHpTjOp1E/1NV+eMt9+cE4s2b2beDb4+Z74BVMYeu26VLk19SPA0l1L84XNhlZiH0xlKkpm2fKlumSwiXcPPW1a8Q+sxnXJUrOWyrWSYMzvYsiuNtNsGDxCMYSab6d6BYC/IK9U8KdaRM6vfVtLXaGwx/PPP2fkZepGQfXRtx2wJjz16Xnef0bivBpJLtxxmolY7ju/jI16ZQIor6OTbJjkc5Z1Z1lIYrzCIwjKqgjbRozQMlpupP2sX1v1iWSZPzvPfzmmSvggchZF3T/NZobRXlfjyW36ZgpXSZ0i0rvNzkZRaevDtrQstkNcLrJ8xLEdcP14Pu54y4RmUzhm/mvWTPbb6SnpLROft1jRk4Nm2UnJ3hSSat+Bx/D8g0SBqNWCtcwal93yc3DHeoRlG+fy1gwG7O5mgKMt60LZ5hBpbuLDw2VuWV9MnU16h/Ky3bfmqm5D7IM7K+TJyDJIefZAO5Us1atdeun2MYvl3yAUbPMgZREQyc6rd89jq6Be2Q76IohLih9pWd0/67wt/PEY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(346002)(376002)(366004)(396003)(451199018)(31686004)(36756003)(86362001)(31696002)(66946007)(66556008)(66476007)(8676002)(5660300002)(41300700001)(8936002)(2906002)(44832011)(38100700002)(82960400001)(6666004)(6486002)(478600001)(316002)(110136005)(2616005)(186003)(26005)(53546011)(6512007)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXpONWZuKzJOWWhNbWY1NWhncTFZeGVUVVdkdGRxamNoZml5RTVXSXE0Z245?= =?utf-8?B?a25wdTA2MjZyV2FuemhjZnZXc1RJWGlya1dCSy9yL20vbjdja1AxTDBESWF4?= =?utf-8?B?T2VNRmFRSmtPbjl5SlBnRjJLdXJrcmk3NCtZTWpDcG9DdVU1dlh5Qk9PZkwx?= =?utf-8?B?eUJ4QVRkL21QRDR5dnZSOHRnaVppQnF1Zmc2b2xDYlhjWGEvRTV3bEpBLzBC?= =?utf-8?B?SEs3L0g4MTlGQzdxMW1FSXlKMmhUTDR4MlRHdXB6S2VlMjBTVHIwbENxazNU?= =?utf-8?B?ZFlLMFJmb09JbGNvV2dZREE3Wi9jNFZybXNxdVcydmxjT2toaWhXUWZ4MFlW?= =?utf-8?B?UWJzRU1nS2RHTFVkTnp3bnkrM0o2U1owNUxmdXVXL3pjWmtyUmlOWlBVVmZQ?= =?utf-8?B?M3gzeGY3RmMrT25SZXVQTi9VZEo4NnRWVEFETFd1aUl0R1B0TGNUd3hGZ216?= =?utf-8?B?MS8rc3BvMERFenBmREdXTHBJazhQV1ZKeGdZL2l4Sm1BN3FNMTY1SUt0VFRK?= =?utf-8?B?ZlMvbGhmWkRUUGhqNFRiWHBvVkQ2eldmV3hjYlpyNjRZMUZLTWU3ZVVGMnRw?= =?utf-8?B?YlNaM01YZ0IxOUJpenB5UHA1RG14L3BIZWZmRy9pZnovQWFzN0RhbVN6VS92?= =?utf-8?B?Sit4WVRRUzBmbVpaVlZVcTVTUC9GcjNaMnA4VlVKNlFIdFYxZ0JlcEg2V3JD?= =?utf-8?B?dEhFNnVmZUlmRWxBVEZJWXNNQ1BHMCtBQ0dsaWoyTitTcmFERE5XdXRtemxk?= =?utf-8?B?aXhvL1JWbVZNQ1lWYmlpZ212a0RObFJLOGNiOFJudERkcDJvbTc4VE9kSWd6?= =?utf-8?B?MHg5V2hubitzQy9EcXJ1VFBiVG1xZVRKUlh2UWMvK3pkSzg4c1h1Qk55SHRU?= =?utf-8?B?TkFVbngvQW96dDdWVkpMRXc5UWlJMUowVTVSQ3V1QzdJTWF3aEpDWjU1U0R4?= =?utf-8?B?K3Zra0JNVmVIMUxqQlJYOTgwYVN3eVFIYitWcENtREVlRTlGL3Z1SVgyeFZy?= =?utf-8?B?VTRRNGZMZ2txOTZDM1k4WFc2cCtQaEpzclBNSGJsOVB1Wi9ZaWNEZHRWTWx6?= =?utf-8?B?L0xUMWxCSDBUT2VuRmtRMWhNRWJ3VHZrWFlrSS9QYkJkQzZINkhLRi8xVGxy?= =?utf-8?B?TjVxY2NKa0EyREdTRytKL0MzMXAvaW8rQTVkTEhJaWozcnJRZStLRkpBbGJZ?= =?utf-8?B?SkUwYVpTZ1NwOFo0dHRPNnQwZmVsQWZ6VlhVaHZqckx0RGMwRU00dHErczlm?= =?utf-8?B?OWh2UjNiMmhEMlNtSTZFRUlBV3lodE5CSDB6cld1UCtnQUJ6Y2tQUDlCMW5Z?= =?utf-8?B?ZmNPTmZnOHFCWnhIaGpXUWxQSkcybk53QTFpQjdHYmE2ZnQyaElBdHJLdzJQ?= =?utf-8?B?NXNnMFhib0hCak9JMitsVHYrckd2bFFPUmFOS1ZRaUFRNXlZbUVuNGIwZ1pZ?= =?utf-8?B?eWxVcjFCU0tsUWFXWDRjejdOZzFmQWR6ZjJJMXZMTTUzT05Pd0RRMUZjUno4?= =?utf-8?B?MzVyblc4MExWdWRZY1Bobk5OaElYQnFGVjFWdmlWeTV4a3dLOU0yM0liWGJj?= =?utf-8?B?Rm9JWmhXYTc4elNsUW85eDNUNHkwRjNmR05IRnBXSjlnZFFUZndnRmF4Q2Uy?= =?utf-8?B?UmpMZEhsZ0ozcU5pa2dMWEwwaTBvOTFNK2g4Y281Vi9ya2UvUDNiZjJCQ1lZ?= =?utf-8?B?QjQ4bVdJVVNtbDl1aE5VTU44UFB6YTROdmZXTUhmeHVkSmxZMHJmM21zRXRm?= =?utf-8?B?SHVYT3ZKNWtwWHFFaUlobGsvbjF6cC9ZL0RZSVpva0JCTzJ5Q3ltNW9Wc1Vx?= =?utf-8?B?dUdwdEFSMFZKUUovYUZFMDhHVWp4R1dOMWxFVmg5OUhKa0tOTEtBMkovRmdM?= =?utf-8?B?UWV0MVRudDZoNHd4bUY3bWdwN1B2MzY5WC9HaWc0dFc1d0xPUVNvd1draStY?= =?utf-8?B?UWFMcVVJRjBqbDJQTHhhdm1tS2FmTmcwUmpDankzYldCSklBQlppVGI5RUN1?= =?utf-8?B?SUQxSk05ZVBBdkpTZXFIOSs2dVFyY3NtQ21NWCtRT2I2QkhjYUsxVnBDRlR5?= =?utf-8?B?MmZPNXYwTE9EQm9TN09KeHRObWxpMTlONUg5Z3cwSFkwejZOdi9xbnJzZ0Vn?= =?utf-8?B?alBabUxIK1QwU1B3c1RMS1RPV2ozWmYrUmdabS9JejVvNXVOTyt0TGxCNTMv?= =?utf-8?B?UFE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: db4ce4ab-4852-40ad-c4dd-08db195c159a X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 07:19:09.3988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OPJ7AwoXi8lsaMGEWhDWucbf1/y8evjV5iKSxIGE7RjM7l4jayGi5o9PTwblZhZ1/N0KZKDSJFQRj3ghvNowww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6178 X-TUID: GuVcfv/u9ZSP On 28.02.23 08:06, Cedric Hombourger wrote: > > > On Monday, February 20, 2023 at 11:32:22 AM UTC+1 Adriaan Schmidt wrote: > > There are cases when we need to rebuild a package that is installed > during > bootstrap (we call those "essential package" here). This patch > introduces > `ISAR_REBUILD_ESSENTIAL_PKGS` which can be set in (distro/layer) > config, and > lists all essential packages. > > During build, Isar ensures that essential packages are built before > any others, > so that their locally built versions are available in isar-apt, and > will > be used in any subsequent package builds. > > Signed-off-by: Adriaan Schmidt > > --- > This has interdependencies with the proposed multiarch feature, > and builds on v2 of that series. > > Adriaan > --- > meta/classes/dpkg-base.bbclass | 1 + > meta/classes/essential.bbclass | 39 ++++++++++++++++++++++++++++++++++ > meta/classes/image.bbclass | 1 + > 3 files changed, 41 insertions(+) > create mode 100644 meta/classes/essential.bbclass > > diff --git a/meta/classes/dpkg-base.bbclass > b/meta/classes/dpkg-base.bbclass > index 55cc6655..ce301346 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -10,6 +10,7 @@ inherit debianize > inherit terminal > inherit repository > inherit deb-dl-dir > +inherit essential > > DEPENDS ?= "" > RPROVIDES ?= "${PROVIDES}" > diff --git a/meta/classes/essential.bbclass > b/meta/classes/essential.bbclass > new file mode 100644 > index 00000000..cb444674 > --- /dev/null > +++ b/meta/classes/essential.bbclass > @@ -0,0 +1,39 @@ > +# This software is a part of ISAR. > +# Copyright (C) 2023 Siemens AG > + > +ISAR_REBUILD_ESSENTIAL_PKGS ?= "" > + > +python() { > + isar_rebuild_essential_pkgs = > (d.getVar('ISAR_REBUILD_ESSENTIAL_PKGS', True) or '').split() > > > ",True" should not be necessary > here's getVar()'s signature: > > def getVar(self, var, expand=True, noweakdefault=False, parsing=False) >   Yep, we still see this pattern popping up. I fact, we have 85(!) left-overs of this legacy pattern in Isar. Let's we write a quick patch... Jan -- Siemens AG, Technology Competence Center Embedded Linux