From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 04 Feb 2026 12:18:00 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-ej1-f56.google.com (mail-ej1-f56.google.com [209.85.218.56]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 614BI0TI012899 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Feb 2026 12:18:00 +0100 Received: by mail-ej1-f56.google.com with SMTP id a640c23a62f3a-b872c88d115sf689721266b.2 for ; Wed, 04 Feb 2026 03:18:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1770203875; cv=pass; d=google.com; s=arc-20240605; b=a5qIYMUJMP5Gbgctp/r6umog079xaimQdtWjdLUobdv7dJFhUxJ5y9aY8aB/XvoTgp 2J+LVTuelQTvWg3grn9TVXaZJr3li7v/n5EvwsR6L+MFeaRcYo/O+Mm6RSYKHrmD9mm4 ADieUdBvPFZ7vJwVsHbe/LUBHy1F5Ntq+IqstVfzpQwDqWNvuy9+hsSjZEMsR1Q3EMWE 1brKRu6hpEyg9hVGS5scaMlsqsBHoMOSvXnjgnDb9IwhUyp9gtbgQqzHp3iq71sp6Kga WLyFhF0jugBzvkNkEsl/W7lWgzsKCiu9YI/aMxpRxx96m4rKeO8vSZoHz+JWOHgalCUZ Ltpg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=vH8oNF10KIgvSWoNaTVMjEIsYFalo5mVZ9aXOl+9WBc=; fh=GU9UugQCmIa1kSOkE4dhroGOUDLdHbRq+CjTeqttGdc=; b=JPJsQb2mPFabOWqSH0lFT50pwvfTf8vFsGgxccS4hinB7YaLKrnQ69Ffp0EG5VwW+2 TRayvlm/ptiyB9sAHhKAEJHU6WZi8wmT0kXmThltyP6LoQ28PeVOwMnlGdw+Lot6wUnu sk6smgbUnS2Utek+EGGlG18X5VkWe/IwN+yPfug4NqoBPVrskXy42NRa6uKLWRPQvRgG 6YF9DLPREqxsEssiS+W9gg8egsMXCBOuyFBHoI9WIWjHm/y9/QkiZd0ZyM3s/rD3GygN AOtT4WkMDpeNSZDfePAI8jsGYvgEHyHwxAAshL6rQCUeQ3e/UXLXeMEPl7JswU7X3WtZ RnHw==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1770203875; x=1770808675; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:in-reply-to:from:content-language:references:to :subject:user-agent:mime-version:date:message-id:sender:from:to:cc :subject:date:message-id:reply-to; bh=vH8oNF10KIgvSWoNaTVMjEIsYFalo5mVZ9aXOl+9WBc=; b=DtxRaDlJ8pT0YITczC/hNhCRfIn4tBeo0KgD68HOofWPx8MREGWCodt5YzUpgdA9Po +5Au2gTUidf6xwyur9E8HeQLWYNMnZWHsJSgLd894i0JPBL6cvdIaAoZ3CP0Q+UapCZw 2rnYf+Us4hIHeanIpHxY33m1k+N9vFJscDuMs7BKSAd0a23HU3G5bGbkLXubmJhW/uUQ QhmOrpM0KK2bK1G7lQvNzFR60VGXXOvv1TZ3D5ZU+Ut/qsvQOsSfP/dw20SqbSfl9IEk NRTHKfdrGdU5ThlD57eteVExYU0FjEldfRc1xi0iUx7459ZWrjdNQgxF2fQ78l8PjXhu QSXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770203875; x=1770808675; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:to:subject:user-agent:mime-version :date:message-id:x-beenthere:x-gm-message-state:sender:from:to:cc :subject:date:message-id:reply-to; bh=vH8oNF10KIgvSWoNaTVMjEIsYFalo5mVZ9aXOl+9WBc=; b=SD1mtMmusN5YV0xgi5bmukjXJI+y7tkBFZ3/H9M7CbFO4555X4KAwXu+i5Pr2jQ5o3 wRTzzQn4IAs/fTph35g7mwsKQZMBETvo02UYI0uxMjmoAj3imh6CzQSB16yRXNh4RRYJ wGSMOErK1AAPPqQHwl5DW4UdlAVyFhptjZ0LSb1kKeCRZAIC2Lr+1ycgI8CPcZORJ5o+ zZ7NzweNiBh7RoCXhGIoc8bVIDm+lhFWTTJVzNqXU4pHgNT435S6P2E8UYXu5ApDjyU4 UsLkSDO4fZxADkLPJCSbbGfN3lqo9vDYqTDPsY+czS6y4qdGmPo+ydD/d+YG4au0XRrr k8iA== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCVGGyp/4C32eNm3/G3sEJZkeFJ21zpxRass3tn1N3tMoUf+xPVpWPTZ1FrWx7b8wfXBHW63@ilbers.de X-Gm-Message-State: AOJu0YyWBanSYWvASIsOKGS7hGKqYNrIIOdGBlw+Bscys/CdGjfJzEfn Y1C/lfy45hZJZwMo3M2XXJEuKVGmd4NumNsj5U2j0H4oZzORj8/rdqPN X-Received: by 2002:a17:907:84c:b0:b87:6:3727 with SMTP id a640c23a62f3a-b8e9f4041femr162715766b.48.1770203874444; Wed, 04 Feb 2026 03:17:54 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="AV1CL+FdnWIXyiy+j0kUIfUSJHzC1obIwjo/M0faRht5wdWxpw==" Received: by 2002:a05:6402:2230:b0:658:3078:75b5 with SMTP id 4fb4d7f45d1cf-658f8668a2dls3270006a12.1.-pod-prod-03-eu; Wed, 04 Feb 2026 03:17:52 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUCRUXKeDK7HNSeyRVlI2ryV7VdVXjPyqoG6m3QirNKclRfq5CZu9fg0NEYs+IdjOvBteXMs/May2UX@googlegroups.com X-Received: by 2002:a05:6402:1ecc:b0:653:af6c:12c4 with SMTP id 4fb4d7f45d1cf-659499b4048mr1611605a12.6.1770203871886; Wed, 04 Feb 2026 03:17:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1770203871; cv=none; d=google.com; s=arc-20240605; b=YWVHXmQlXqZDnCneSxgX8mV4dzdhdA7ZKJZxZn+k+Jr3ObI3hUZO1C1zT5NF5SQ/c3 vByBXMoYIb0GyCHFW463e262wHX6iupz8XA6A5joRx4hEUt8f8TJsgd4DBnhlIEFzgog KnsDQh9li85TIhXjzGABVxQMEqf7HptyYpBDOMkRWs+N7nvCTsklF13d7kfiy1n3FYZv suWx1iIId6TfW28I7X1mkmsm57wFGbvKjXPyRXIrbgQUnPralFNK9bB5ByBvujaPtw5/ ZgzCd/xFlU6CLyGhipINDV+SdmwSZoBmhOc2y0rH8skllAeHdjtRdmBB/gIpKjVjCy/m JwPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id; bh=VwG+3oRhINL/zgUqwuYxtsVk0THSnYYirFovdnArHHQ=; fh=5NSxVC+mApFXoXLSOq5LsifR6fZRAAkhAp5yZbt2WhY=; b=DDToCERrndI9TL59vRRB1cGpzOHV2LYN1b64eekgSoBdruQxJ7FPmlXaawYr4WZIU9 4ifCRCWAfXyLsUsERu4IBEonI8q0NZWZ8RidUJYW1vCn8o+OTALtxMdrnnz/2LK58rxW BrqWdH34uiXqxTn8jBCFFci6K9dMkZlS9qTBpGXtWs18oVNhOgsjgcjYns6jvvmXXFAy SQ1t58lha/21mZTN7rUWqd33yH9/IgXEulvCedHcj58xXTLwd9wg+StNQzWJotbv7HTC 2Q1h1aiAG3L+id06uzESOHDzn5tuR7ZxMaF8jq5hd+BUBjhX7zNWqndBbD4eNI4MPP8y q8uQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 4fb4d7f45d1cf-6594a5deca3si73846a12.6.2026.02.04.03.17.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Feb 2026 03:17:51 -0800 (PST) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.117] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 614BHovI012892 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 4 Feb 2026 12:17:50 +0100 Message-ID: Date: Wed, 4 Feb 2026 12:17:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] debianize: warn if package maintainer is default or empty To: "MOESSBAUER, Felix" , "isar-users@googlegroups.com" , "Kiszka, Jan" References: <20260121174002.3293232-1-felix.moessbauer@siemens.com> <20260121174002.3293232-2-felix.moessbauer@siemens.com> <2f6a354bf1c859ed38213c240746dd815adf20d7.camel@siemens.com> Content-Language: en-US From: Zhihang Wei In-Reply-To: <2f6a354bf1c859ed38213c240746dd815adf20d7.camel@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: D431srEgrh0N On 1/22/26 10:18, 'MOESSBAUER, Felix' via isar-users wrote: > On Wed, 2026-01-21 at 19:21 +0100, Jan Kiszka wrote: >> On 21.01.26 18:40, 'Felix Moessbauer' via isar-users wrote: >>> The debian policies require that the package maintainer is filled >>> with someone that can be contacted. Checks of the SBOM of various layers >>> have shown that often the maintainer is not explicitly set, probably >>> because we provide a default. >>> >>> As a change of the default maintainer might create a lot of downstream >>> changes, we introduce a warning instead. Later on, we can remove the >>> default and just assert that it is set. >> Indeed, this is likely creating at least a lot of warning noise for >> packages that are not maintained like Debian packages because they are >> proprietary. I'm not yet sure it will be helpful to enforce other pseudo >> addresses for those. > In the past this remained mostly unnoticed, as maintainer data is not > part of the manifest file and also not relevant for the license > clearing itself (still it was wrong). This changed with in introduction > of SBOMs as now this data is used downstream and by that more care > needs to be taken. > > Anyways, even the isar docs request you to put in a proper string > instead of the default. Hi, We think it's good to have this warning to improve data quality. The mailbox should point to one that is monitored so people can respond. Indeed, it will cause a spike in warnings, but we don't see a better alternative. >> Maybe we should define some alternative placeholder that verbosely >> documents that this packages is proprietary, and different contact >> channels apply? Would still create noise in the transition. > No. Just because we rebuild something does not mean it is proprietary. > Only the isar user can decide what value to put in there. If you really > want to have a setting as you just proposed, just set the MAINTAINER at > a higher level (e.g. by providing the default value in the local.conf). > This is already supported today. > > Nonetheless, for SBOMs we have the garbage in -> garbage out situation. > That's why I prefer to start with good data instead of downstream > papering over. > > Felix > >> Jan Maybe we should also tell people to provide a URL to their package when reporting such issues. The patch itself has passed CI. Zhihang >>> Signed-off-by: Felix Moessbauer >>> --- >>> meta/classes-recipe/debianize.bbclass | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/meta/classes-recipe/debianize.bbclass b/meta/classes-recipe/debianize.bbclass >>> index a629feba..a255dd28 100644 >>> --- a/meta/classes-recipe/debianize.bbclass >>> +++ b/meta/classes-recipe/debianize.bbclass >>> @@ -25,7 +25,16 @@ MAINTAINER ??= "Unknown maintainer " >>> >>> DEBIANIZE_BUILD_DEPENDS ?= "debhelper-compat (= ${DEBIAN_COMPAT}), ${DEBIAN_BUILD_DEPENDS}" >>> >>> +deb_check_maintainer() { >>> + if [ -z "${MAINTAINER}" ]; then >>> + bbwarn "MAINTAINER is empty. Please set a valid maintainer." >>> + elif echo "${MAINTAINER}" | grep -q "@example.com"; then >>> + bbwarn "MAINTAINER contains '@example.com'. Please set a valid maintainer." >>> + fi >>> +} >>> + >>> deb_add_changelog() { >>> + deb_check_maintainer >>> changelog_v="${CHANGELOG_V}" >>> timestamp="${DEBIAN_CHANGELOG_TIMESTAMP}" >>> if [ -f ${S}/debian/changelog ]; then >>> @@ -84,6 +93,7 @@ deb_create_control[vardeps] += "DEBIANIZE_BUILD_DEPENDS \ >>> DEBIAN_RULES_REQUIRES_ROOT \ >>> DEBIAN_STANDARDS_VERSION" >>> deb_create_control() { >>> + deb_check_maintainer >>> # Add Source section >>> cat << EOF > ${S}/debian/control >>> Source: ${BPN} >> -- >> Siemens AG, Foundational Technologies >> Linux Expert Center -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/d1aaeb33-8c2f-4518-a60c-3425e2b8982a%40ilbers.de.