From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7118849410521366528 X-Received: by 2002:a05:600c:4ed0:b0:3a0:5263:cf09 with SMTP id g16-20020a05600c4ed000b003a05263cf09mr17091550wmq.6.1657558517395; Mon, 11 Jul 2022 09:55:17 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:588d:0:b0:21d:339f:dc1 with SMTP id n13-20020a5d588d000000b0021d339f0dc1ls371177wrf.0.gmail; Mon, 11 Jul 2022 09:55:16 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u8Yft4PWjN5OKlh0SjvmrISQmrKAw7Gr72ms2bI4WPNA1uk/zPV582Kd0J4C36iNDTBxLX X-Received: by 2002:adf:dd52:0:b0:21d:941a:3ade with SMTP id u18-20020adfdd52000000b0021d941a3ademr14750041wrm.10.1657558516173; Mon, 11 Jul 2022 09:55:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657558516; cv=pass; d=google.com; s=arc-20160816; b=yvV5/xuFl4Rk5sGZN+yPTvrfyL1Ux2jP+4bIIAn6B/JKZq/STWTrri5y5aGk9u0/if 63p/54QXe+Q82sZzJc+RAzpRgiHB7+D6yut262RjDbr2azj6OfOlkbhixSyZJuutNCVS 76BzjfADgtNJ624bw4Kx61SjTKWCdFSphwFpvrPOfqBe1/It55gZfRtSriANr3BcOee8 aTLtsxHs/qEaYquPpAO4hB+KjmGT5H/CUDLu+YsteFi78M6mt3Rz/YUo+KdZXOOet03A kNOvTaVi8JRaHVnIT+g1UQEm7Yp3Kgc4p1IR1iZSrhX4vpQG7amfpijvXl3uJiadpEFQ nM0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=sPkNaXu5XW2/Ob9LQshgwV0dOme0DUTid4drYuVzxoA=; b=bqqnCuE97dBya17RTQZqKl72whb8Aq95900Wtr208zeEJrTd3dWDYRwjE0MXtyMcbR JoxxaqxrPy9JPzPssfm9d56ZuzSwzNvbvWWIQpkeRVrX5QIlwwMc1nf4tvDX3zAsiW0d 4YjumlYHh+6UM6iz3K6HO2mp5l8HWfKOAXsrZAzmxY7dD7E6ZGJMS5cHzE9zJCWN1a0K q+DkZmCkakQRDSrybgEQj5gp6TWCIXLr3SQpaDVEQxNTJYGEx6h4QsMUGIx5pEdxLKdq +Pex3Vp+Rf98AcJQ1WSPoqVy+Hs+VPBnRgjtFZQlWSdK9i3V2zhNkYlxA3UcROMjgNLH euTA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=l4KnzAB4; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.13.85 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130085.outbound.protection.outlook.com. [40.107.13.85]) by gmr-mx.google.com with ESMTPS id t14-20020a1c770e000000b003a2e84a9f74si95669wmi.0.2022.07.11.09.55.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2022 09:55:16 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.13.85 as permitted sender) client-ip=40.107.13.85; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=l4KnzAB4; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.13.85 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IgvyqZS7+FTcl39sUJWJbQi1cUHnHWgJ8KDGVUXsTyJkSmxS60OL7DUDpDDHL0pZ7OGLDtXrzLFggg+h2GMus31tVrqd9tPBAVNjcfycYbrU3nwYvMcFI15n43yhUgPVItja1RRxfMruLyQiDyeF2ELKgYUiQzIxRVxhS+YmZwaS3J5F0HS6ORCf1ugIIV8yCVl5PNzoPFqKV9XCjOWuynp4ldgVMsaG41LJL7GSccTbDxNQEpihlPvS6YAalXxileggJyhlcpITAKo5Jqfs2W4x3bZObpO6aKWztCM46NzEeDOjmn8qNUeXizSxdlo5L/5ayoHp1kyCkBh7BAYBnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sPkNaXu5XW2/Ob9LQshgwV0dOme0DUTid4drYuVzxoA=; b=E9EpfpGo866J/ocarrElpJMvBZQ5Qva0wMlpYOW/LvzhZa8zxZTwsofRQIyYtJSQgvCpsuGNcIIpL6sH5KwSo7/PAi6+YsddYUN83YdpHr67V1VRhlF9vC0gKvQFvG9GvcXY31qRlYC93H5KimI8rjqn4fc0njduZGIDcfdBXINttMGdbzmrhH2Jwwvbw8JFbP7FLlze/6XyFr9jzA5PkRei6pkApuDkgydxy+5Bm+pbacMoIKjGWuVjssjerhTna4YVyAAAhIkGdk/r2XJbET7n47F3S8OTNsOrENRSq8DZFLKVVydrfoF/ri4YDNpCXQdedE4P1o3N0yA8fztLaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.71) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sPkNaXu5XW2/Ob9LQshgwV0dOme0DUTid4drYuVzxoA=; b=l4KnzAB4FOaKD5rKoy42wIdUwWQV6UV+D1ze082GoUqoynUnSp93HdCpbyk9NAJQU5ScJevXCkOSsbxuFknWXacAJxiaNpgWwp6j+tfG/n30t8G8oTbahvifwICUP+ZV/bD63tBv0gdNojZOKw3jE/Kyyv28e9zfz+OueIc7gsLQsnl+YTVqFn+8BzjcDmwHbP58EXqkoq2921XTaRyKd7yxABlschh7f8Tz194QPPL4UWS3+T9pt1d8aXRR1EElxjl4e/4CL7kyRpS6UajUqO+4WnFUh9c7eoIWvQu65Dof4bRGXSDDfqBUjyrdg//H/uZgMnQzAqi+ZVGAavSr8g== Received: from OS6P279CA0007.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:30::8) by AM7PR10MB3640.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:135::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Mon, 11 Jul 2022 16:55:14 +0000 Received: from HE1EUR01FT103.eop-EUR01.prod.protection.outlook.com (2603:10a6:e10:30:cafe::15) by OS6P279CA0007.outlook.office365.com (2603:10a6:e10:30::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Mon, 11 Jul 2022 16:55:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.71) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.71 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.71; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.71) by HE1EUR01FT103.mail.protection.outlook.com (10.152.1.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Mon, 11 Jul 2022 16:55:14 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC9SKA.ad011.siemens.net (194.138.21.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.9; Mon, 11 Jul 2022 18:55:13 +0200 Received: from [167.87.9.151] (167.87.9.151) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.9; Mon, 11 Jul 2022 18:55:13 +0200 Message-ID: Date: Mon, 11 Jul 2022 18:55:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] linux-custom: Fix error handling of kernel build Content-Language: en-US To: Henning Schild CC: isar-users , Cedric Hombourger References: <6b8a5055-437c-f706-d871-a9b564631cd8@siemens.com> <20220711150432.28d2a1be@md1za8fc.ad001.siemens.net> From: Jan Kiszka In-Reply-To: <20220711150432.28d2a1be@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.9.151] X-ClientProxiedBy: DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--15.701100-8.000000 X-TMASE-MatchedRID: irl7E//xM945QaOxwNGfvo9bHfxDWoibGnjuHJNyKRxweJDozYf4K606 ui9xBYavgHhfJtGVOYTD9iRj9LIMxv9z/s7Ti1TSB6v+5gVW3HJPEtzipOABjJxVZzZr7+O7p1P jcaldww0HZBaLwEXlKGlF7OhYLlctN1cJurw+xGPe9lCknhyDexVkoSf/BaDXG9TMqjxt7zEL// VMxXlyE5XmY63X9nCpuF0BEedRtW09VOAEZ4oQex6mHHBXlfPgvHebHoyeEXWVd49c0zgWM0Yj0 zDHPzJpyF9drED/u/s/PJ8p+RzsAfzpNdtHBeczY5Z09adeRc1MFmmQO5uUd8Vbb3pjW5MnAPiR 4btCEeaUAUfla+IhaLKXWmEvaG3ECxvAgaTHFy+Rk6XtYogiau9c69BWUTGwVnRXm1iHN1bEQdG 7H66TyH4gKq42LRYkMOME7V/pUKnjsvBrkbvSZaPFjk7QI9dsI1+HYm1eS0t+3BndfXUhXQ== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.701100-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: 09B5FCB023D98ED13318649C32F3D9DA68688093EFD79F564A07189222AF08872000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 48d93d94-4891-4a0c-211f-08da635e2019 X-MS-TrafficTypeDiagnostic: AM7PR10MB3640:EE_ X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tN5ncsVKRQnY3zbejbkZYjhpHyUB4JNYZRwUl05oRopDdJqt3woA5BeQxQJU6ERmHtG3Fo+48t9udXcX82YHIfi4ZaIX3JZJvF2pc4BpBgUtmjuK8Dk4vm/hAVa065pQeD3Jef5P6u0XHlieRcv8m23qawq9KEeG79taDImqiow1K3AptRui6jawsW79YgYuAgKsIhf0Qix1z3HNVbxxzWlDuKh1dcE/i8K8W+EhXgp0HCSFSAp6ehtDqdrnTUsP1pldDDVf3TKqy6Tdzk45xmk7CM2OGwDueaVlrgnR43exOJtrMMONbgpKoEOiCyQLfSk32B6kmS7L70dA+Yt3bJR6v41ZjdnCXjRNaV+jzu3hqKcqigiIpSyJVePS9zf7W5/tNMohBJqExjcqUjf3wrc2Nq1lVjbXwYcpSRigSDEdUDufXKm2QYS8q4SS44mG5G0ETZeBb8DzwxKkJLJqo9NoHHJOwIdSTOfJqTdpszO2Q4Apw4RfWHsYmGKGRSMlJxar7YaH/yA9a8CZMWR9gSsdMgDO4wNr6cUzfpIPZWzldC4IfV8nT2x7taXIN5KmTjLfyauqhLwtgZt6tGdCJa4jyAgtFDd8PbM/BriRFWV81j81MDCY/YZiyIYwJkbU4JJZnDOVyt9zXG2S210Oa3D5EXzSOQkCO3zUCf5ZXxTlJBLdAPToSFm1835m3KpNhGrtVVzTk3eVHIS8vNsnklouOhc5otgJ6vzJ/B38eTLQXzx3rIzUdAnIpr/847YiHycFzMnOwS8HWx1tkZXng9RvqmEUboQdk0pBZ6RAtDjhQgKNTa/IBlM4RMCczN5nlEqiq+aPETbemobBgQMx7f5VWVMpjVsZ2F3bCOTb5YCXyRnZUHfAbsRtJl7bHWh5y+PXkphfestRu6X7X2tBNBF8wEv4jtUVdXhDVJ52kRA= X-Forefront-Antispam-Report: CIP:194.138.21.71;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(346002)(136003)(376002)(40470700004)(46966006)(36840700001)(44832011)(82960400001)(82310400005)(36860700001)(6862004)(86362001)(82740400003)(8936002)(8676002)(31696002)(70586007)(83380400001)(70206006)(40460700003)(356005)(5660300002)(16526019)(4326008)(316002)(336012)(36756003)(81166007)(2616005)(53546011)(478600001)(47076005)(956004)(54906003)(31686004)(26005)(41300700001)(6636002)(6706004)(37006003)(2906002)(16576012)(40480700001)(186003)(3940600001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 16:55:14.2158 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48d93d94-4891-4a0c-211f-08da635e2019 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.71];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT103.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3640 X-TUID: mwD9dV5YUSRp On 11.07.22 15:04, Henning Schild wrote: > Am Sun, 10 Jul 2022 22:51:24 +0200 > schrieb Jan Kiszka : > >> From: Jan Kiszka >> >> Error was widely broken because set -e was not consistently set and, >> where it was, it had no effect on functions as the do_${target} >> invocation put them in a pipe which causes -e to be ignored. >> >> This sets -e in the common script already and avoids the now unneeded >> "|| exit ${?}". >> >> Signed-off-by: Jan Kiszka >> --- >> >> Found while fighting with a horrible vemdor kernel that had >> dtbs_install broken - but was built "successfully". >> >> meta/recipes-kernel/linux/files/debian/isar/build.tmpl | 6 +++--- >> meta/recipes-kernel/linux/files/debian/isar/clean.tmpl | 2 +- >> meta/recipes-kernel/linux/files/debian/isar/common.tmpl | 4 +++- >> meta/recipes-kernel/linux/files/debian/isar/configure.tmpl | 6 +++--- >> meta/recipes-kernel/linux/files/debian/isar/install.tmpl | 5 +---- >> 5 files changed, 11 insertions(+), 12 deletions(-) >> >> diff --git a/meta/recipes-kernel/linux/files/debian/isar/build.tmpl >> b/meta/recipes-kernel/linux/files/debian/isar/build.tmpl index >> b7749cec..550bdc67 100644 --- >> a/meta/recipes-kernel/linux/files/debian/isar/build.tmpl +++ >> b/meta/recipes-kernel/linux/files/debian/isar/build.tmpl @@ -3,7 +3,7 >> @@ # SPDX-License-Identifier: MIT >> >> # Load common stuff >> -. ${S}/debian/isar/common || exit ${?} >> +. ${S}/debian/isar/common >> >> do_build() { >> >> @@ -12,7 +12,7 @@ do_build() { >> >> # Process existing kernel configuration to make sure it is >> complete # (use defaults for options that were not specified) >> - ${MAKE} O=${KERNEL_BUILD_DIR} olddefconfig prepare || exit ${?} >> + ${MAKE} O=${KERNEL_BUILD_DIR} olddefconfig prepare >> >> # Transfer effective kernel version into control file and scripts >> KR=$(${MAKE} O=${KERNEL_BUILD_DIR} -s --no-print-directory >> kernelrelease) @@ -22,7 +22,7 @@ do_build() { >> set -x >> >> # Build the Linux kernel >> - ${MAKE} O=${KERNEL_BUILD_DIR} ${PARALLEL_MAKE} || exit ${?} >> + ${MAKE} O=${KERNEL_BUILD_DIR} ${PARALLEL_MAKE} >> >> # Stop tracing >> set +x >> diff --git a/meta/recipes-kernel/linux/files/debian/isar/clean.tmpl >> b/meta/recipes-kernel/linux/files/debian/isar/clean.tmpl index >> f9039877..bc67595b 100644 --- >> a/meta/recipes-kernel/linux/files/debian/isar/clean.tmpl +++ >> b/meta/recipes-kernel/linux/files/debian/isar/clean.tmpl @@ -3,7 +3,7 >> @@ # SPDX-License-Identifier: MIT >> >> # Load common stuff >> -. ${S}/debian/isar/common || exit ${?} >> +. ${S}/debian/isar/common >> >> do_clean() { >> >> diff --git a/meta/recipes-kernel/linux/files/debian/isar/common.tmpl >> b/meta/recipes-kernel/linux/files/debian/isar/common.tmpl index >> b7752fb6..52ebebb0 100644 --- >> a/meta/recipes-kernel/linux/files/debian/isar/common.tmpl +++ >> b/meta/recipes-kernel/linux/files/debian/isar/common.tmpl @@ -2,6 >> +2,8 @@ # Copyright (c) Mentor Graphics, a Siemens business, 2019 >> # SPDX-License-Identifier: MIT >> >> +set -e >> + >> # Isar settings >> ARCH=${KERNEL_ARCH} >> KERNEL_PKG_IMAGE=linux-image-${KERNEL_NAME_PROVIDED} >> @@ -45,5 +47,5 @@ main() { >> fi >> >> # call the actual target script >> - do_${target} || return ${?} >> + do_${target} >> } >> diff --git >> a/meta/recipes-kernel/linux/files/debian/isar/configure.tmpl >> b/meta/recipes-kernel/linux/files/debian/isar/configure.tmpl index >> 83871baa..58f10326 100644 --- >> a/meta/recipes-kernel/linux/files/debian/isar/configure.tmpl +++ >> b/meta/recipes-kernel/linux/files/debian/isar/configure.tmpl @@ -3,14 >> +3,14 @@ # SPDX-License-Identifier: MIT >> # Load common stuff >> -. ${S}/debian/isar/common || exit ${?} >> +. ${S}/debian/isar/common >> >> do_configure() { >> >> # Process kernel config target and fragments >> - ${MAKE} O=${KERNEL_BUILD_DIR} ${KERNEL_CONFIG_TARGET} || exit >> ${?} >> + ${MAKE} O=${KERNEL_BUILD_DIR} ${KERNEL_CONFIG_TARGET} >> ./scripts/kconfig/merge_config.sh -O ${KERNEL_BUILD_DIR}/ \ >> - ${KERNEL_BUILD_DIR}/.config ${KERNEL_CONFIG_FRAGMENTS} >> + ${KERNEL_BUILD_DIR}/.config ${KERNEL_CONFIG_FRAGMENTS} > > ?? > That was what I had in mind as well when I read those two lines. Therefore, I took the freedom to make them more readable via an indention fix along this. Not worth a separate patch. Jan >> >> # Stop tracing >> set +x >> diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index >> 4c8c889f..c6b5059d 100644 --- >> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ >> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -3,10 >> +3,7 @@ # SPDX-License-Identifier: MIT >> >> # Load common stuff >> -. ${S}/debian/isar/common || exit ${?} >> - >> -# Stop on error >> -set -e >> +. ${S}/debian/isar/common >> >> do_install() { >> > -- Siemens AG, Technology Competence Center Embedded Linux