From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6868613252732944384 X-Received: by 2002:a1c:40c4:: with SMTP id n187mr7094649wma.180.1599720842271; Wed, 09 Sep 2020 23:54:02 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:dd0a:: with SMTP id a10ls5789586wrm.2.gmail; Wed, 09 Sep 2020 23:54:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAPWr4vzw9bmIZqrUQx8ffJBAEjzH077yoeXZg+3lO5aoVMtTO3xkF4ckTC7rPb+hOTs4B X-Received: by 2002:adf:e6c8:: with SMTP id y8mr7870543wrm.229.1599720841289; Wed, 09 Sep 2020 23:54:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599720841; cv=none; d=google.com; s=arc-20160816; b=VxqnilzgKRJbzSTbetmCeW76CXIPATZXfUOXs2W5SdWlCG5Ntz5q8cfTKQB1vOvv6U YR6/416d4/4A1oJOjKHFs4RdJu8giF//LMBvi4YcnFsEP7ixC9qD99a8YcccuO1lghwe JZNrM3nzKWEfrglzdAV4qneXytn9g8Me7Boex3c+baK6mAbAI2hj3alBQHlKW9V3iKQ2 1mkIedLjNzQrp4ZJWoTCqrJJo3lKla8cXHEUVx84E3MMgdxFqERN7t99i48ioTZaaCDp UJB1TUtn2xrZV968mpdc8vXiFyNyqn6a5Ny1ZGf8UdklK7K5zBng4Q5yV5OmgtvvzXhA en7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:cc:to:from:subject; bh=1IMjJG5P8vgx7I8poDSZICguUWJf8fZVEyzKg6JXsAo=; b=TQM31Skq38F/q3X8yfVtE+VK2NXsKdHN+dZ81i00o0oFtNs19IT50qyF5r9XXjIiqy AwvAaR6wm/A0LsICxUg/XZxMgnt04LqsZoql9JzM5CtTMiFMrRMhl/5hhcrIdHJM+r3d wF2RMl+0T0X4PkqucJnckaPKOHkX/9waAqhQAf7kzbY7HX2+OJdr3FJAR7sSLiyVXvVq 6wrWIcLWx0SlxH29sVIbnnogGpBHfgk9uEq+an9pu9SDhizQ5ipjijVjnO2ulMr+TdAC uTGzHYcJ9mFVFIaVwRupyBEdVbBUdI2C/9f09Y5qv1MnjyxsJ3o6PLC/zH/fa0gC3jzw y/tA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id y64si36986wmc.0.2020.09.09.23.54.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Sep 2020 23:54:01 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 08A6s0iK028237 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 10 Sep 2020 08:54:00 +0200 Received: from [167.87.23.29] ([167.87.23.29]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 08A6s0Yp001110; Thu, 10 Sep 2020 08:54:00 +0200 Subject: Re: [PATCH 2/2] ci: Add compat arch support From: Jan Kiszka To: Henning Schild Cc: isar-users References: <64fa79e829f2b29553b2baedabc766f7ec3ef230.1599223641.git.jan.kiszka@siemens.com> <20200909154442.1241936f@md1za8fc.ad001.siemens.net> <141bba40-5a5e-dda8-87b1-979a735b9d5d@siemens.com> Message-ID: Date: Thu, 10 Sep 2020 08:54:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <141bba40-5a5e-dda8-87b1-979a735b9d5d@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 7unHGWeUw1Vw On 10.09.20 08:51, [ext] Jan Kiszka wrote: > On 09.09.20 15:44, Henning Schild wrote: >> On Tue, 8 Sep 2020 10:53:58 +0200 >> "[ext] Jan Kiszka" wrote: >> >>> On 04.09.20 14:47, [ext] Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> Build hello-isar and libisar for the compat arch if that is enabled. >>>> Set ISAR_ENABLE_COMPAT_ARCH for all supported combinations in CI. >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> meta-isar/recipes-app/hello-isar/hello-isar.bb | 3 +++ >>>> meta-isar/recipes-app/libhello/libhello.bb | 3 +++ >>>> scripts/ci_build.sh | 6 ++++++ >>>> 3 files changed, 12 insertions(+) >>>> >>>> diff --git a/meta-isar/recipes-app/hello-isar/hello-isar.bb >>>> b/meta-isar/recipes-app/hello-isar/hello-isar.bb index >>>> 144a433e..8c3ba8b2 100644 --- >>>> a/meta-isar/recipes-app/hello-isar/hello-isar.bb +++ >>>> b/meta-isar/recipes-app/hello-isar/hello-isar.bb @@ -20,4 +20,7 @@ >>>> SRC_URI = " \ file://yet-another-change.txt;apply=yes;striplevel=0" >>>> SRCREV = "a18c14cc11ce6b003f3469e89223cffb4016861d" >>>> >>>> +# NOTE: This is just to test 32-bit building on 64-bit archs. >>>> +PACKAGE_ARCH_compat-arch = "${COMPAT_DISTRO_ARCH}" >>>> + >>>> inherit dpkg >>>> diff --git a/meta-isar/recipes-app/libhello/libhello.bb >>>> b/meta-isar/recipes-app/libhello/libhello.bb index >>>> ab271b58..5c44de50 100644 --- >>>> a/meta-isar/recipes-app/libhello/libhello.bb +++ >>>> b/meta-isar/recipes-app/libhello/libhello.bb @@ -13,4 +13,7 @@ PV = >>>> "0.1-98f2e41" SRC_URI = >>>> "git://github.com/ilbers/libhello.git;protocol=https;destsuffix=${P}" >>>> SRCREV = "98f2e41e7d05ab8d19b0c5d160b104b725c8fd93" >>>> +# NOTE: This is just to test 32-bit building on 64-bit archs. >>>> +PACKAGE_ARCH_compat-arch = "${COMPAT_DISTRO_ARCH}" >>>> + >>>> inherit dpkg >>>> diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh >>>> index d2c707b8..461fd5cc 100755 >>>> --- a/scripts/ci_build.sh >>>> +++ b/scripts/ci_build.sh >>>> @@ -139,6 +139,12 @@ if [ ! -d "$BUILD_DIR" ]; then >>>> fi >>>> source isar-init-build-env "$BUILD_DIR" >>>> >>>> +cat >>conf/local.conf <>>> +ISAR_ENABLE_COMPAT_ARCH_amd64 = "1" >>>> +ISAR_ENABLE_COMPAT_ARCH_arm64 = "1" >>>> +ISAR_ENABLE_COMPAT_ARCH_debian-stretch_amd64 = "0" >>>> +EOF >>>> + >>>> if [ -n "$CROSS_BUILD" ]; then >>>> sed -i -e 's/ISAR_CROSS_COMPILE ?= "0"/ISAR_CROSS_COMPILE ?= >>>> "1"/g' conf/local.conf fi >>>> >>> >>> This triggers a problem: >>> >>> In a multiconfig setup like our CI, building the 32-bit package from >>> both the native 32-bit arch as well as the 64-bit arch now races. If >>> the 64-bit arch tries to install its self-built compat package, that >>> may just be under re-deployment by the 32-bit arch, and the build >>> fails. >>> >>> Options: >>> - somehow express that both archs provide the same package (though >>> that may defeat the purpose of testing the compat build) >> >> The purpose is that people want to use compat because they have just >> one image. > > Well, one could imagine building a legacy application for both an old > ARMv7 device as well as for a new ARMv8 design. All that in one build > run (mc:...). Then the user would have to express that > my_beloved_legacy_app is actually a dependency that only needs to be > built once, and it would not matter if that is done by the armhf > buildchroot or via compat by the arm64 one. > I think I know the answer for our testing scenario: call the the compat-variant of hello-isar "hello-isar-compat" and request that package in the 64-bit image. Then both build paths are stressed, and everyone gets what is desired. Let me try that later... Jan >> >>> - split isar-apt per arch, not just per distro >> >> But would the compat not need to include both now, and the mc enemy >> would still mess with one of them? > > We would have isar-apt/apt/debian-buster-armhf, debian-buster-arm64 > etc., but all of them able to carry packages for any arch. > >> >> - better/more locking around isar-apt readers and writers >> > > Nope, that would only paper over the fact that a package is built twice > and the one to be used would be chosen by chance. Bad for reliable testing. > > Jan > >>> Suggestions? >> >> Well one thing ... but i do not want to repeat myself ... >> >> Henning >> >>> Jan >>> >> > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux