From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 11 Sep 2026 13:12:53 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qv1-f60.google.com (mail-qv1-f60.google.com [209.85.219.60]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 68BBCqV3013016 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 11 Sep 2026 13:12:52 +0200 Received: by mail-qv1-f60.google.com with SMTP id 6a1803df08f44-91043af01d9sf14319176d6.2 for ; Fri, 11 Sep 2026 04:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1789125166; x=1789729966; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:x-original-sender :content-type:mime-version:subject:references:in-reply-to:message-id :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gviNdOABrB7GXPYKkg/1mDktiy6ENvcFptaiOeDAgxg=; b=oildZb0Nq9sb4hiwFfiozy86lvCLMInWUd4T3dTsa4jG9/QyYcv2XyH42B0o/8HW5n i5VRA9PLglDLd78Rexnm0t3R74wEOuzg2IJKPrJyiUno5mneYpsNccsE+HuAIiwnbXz7 t/wgYIJi5FBHlB++nWhuncYwBFfOeaTClYWl9PISPvdYZZGyvcGJF+c/so5grlJeh56v xLUv1E1+kwlzJ0x0/vaOWn6U8uS6+1UoTpT5MvrHhaaZeEH6HqpKyglYg/M8305J3xgk RwSFJnoSelKSuwDob8xZYT4QD2vm5SqYls3v+W09CYXpGgk1/8748Wa1cNHAN9NC2Y2h EFIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789125166; x=1789729966; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-sender:content-type:mime-version:subject:references :in-reply-to:message-id:to:from:date:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=gviNdOABrB7GXPYKkg/1mDktiy6ENvcFptaiOeDAgxg=; b=iSVEONcKRDEw94YTn08YOxl5jw1Lt2xmCv8vRuSyMKvWztenL/+kr7iVzGM+cF3h82 dZdDL31LzMEzuS9OO29xW7FojinF6zQr3/1nuyDgBX8NPNcrAPGdd2Zrnk5gV3vIkShT 85qvsrNWS2U7E0EoWDo2oKH0ocHinAjje7XopuOb/V6yAFF9eO8CoeZvEJrhrfvrj/Px OWRbl4L+c8jd7lC5dYSsz0zyOWeW0Z4TII2Yl7zhSwVXhDBR0ptr9owx0o/H36BfW0Dj IFUul9kB1ct0btjKTN6UWkaVjiU0Ekbys5+GMSEQT/smZEXs7RMEon0yJSr+vuZxlfKL UHfQ== X-Forwarded-Encrypted: i=1; AKwUvByWDFaG5MUTZL5ibA7Sm6TxgYa9eCiQ1l0jD3NY5UhCOHg4tDXqlKabyPVW2/Dn0yCBIVfe@ilbers.de X-Gm-Message-State: AFuF++kRft9NwQ28uufaRShDnpFzBGGMYZzxkOFvokWYu5Etah2zJyqD pn30bu8LDftEvNyKzzEUVg0kVtpsIyZfyBLCAZJ4jmrDQ5pWLIRHJKWt X-Received: by 2002:a05:6214:224c:b0:910:3063:c97d with SMTP id 6a1803df08f44-9121209226cmr48599956d6.12.1789125166407; Fri, 11 Sep 2026 04:12:46 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="ATskLdei//btKQalUYrGr8FEmJYQGlXcAXrtKt1n0gtn2zizkQ==" Received: by 2002:a05:6214:5e03:b0:90e:8f12:cc55 with SMTP id 6a1803df08f44-9120285c485ls43358526d6.0.-pod-prod-09-us; Fri, 11 Sep 2026 04:12:45 -0700 (PDT) X-Received: by 2002:a05:620a:7102:b0:939:761c:4f59 with SMTP id af79cd13be357-939ea14252fmr430650685a.16.1789125164982; Fri, 11 Sep 2026 04:12:44 -0700 (PDT) Date: Fri, 11 Sep 2026 04:12:44 -0700 (PDT) From: "'Srinuvasan Arjunan' via isar-users" To: isar-users Message-Id: In-Reply-To: <855faf99-5468-44da-8d6d-5472b87512e9@siemens.com> References: <20260911101616.748091-1-srinuvasan.a@siemens.com> <855faf99-5468-44da-8d6d-5472b87512e9@siemens.com> Subject: Re: [PATCH] avoid double slash in generated rootfs umount paths MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_70622_1279949770.1789125164447" X-Original-Sender: srinuvasan.a@siemens.com X-Original-From: Srinuvasan Arjunan Reply-To: Srinuvasan Arjunan Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: 7vEciQ8TDkMS ------=_Part_70622_1279949770.1789125164447 Content-Type: multipart/alternative; boundary="----=_Part_70623_358126220.1789125164447" ------=_Part_70623_358126220.1789125164447 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Friday, September 11, 2026 at 4:19:31=E2=80=AFPM UTC+5:30 Jan Kiszka wro= te: On 11.09.26 12:16, srinuvasan.a via isar-users wrote:=20 > From: Srinuvasan A =20 >=20 > ROOTFS_MOUNTS inner paths are absolute, e.g. /isar-apt and=20 > /isar-work. insert_isar_umounts added another slash between ROOTFSDIR=20 > and the inner path, producing paths like rootfs//isar-apt in the=20 > expanded rootfs_do_umounts_priv task.=20 >=20 > Strip the leading slash from the inner mount path when building the=20 > mountpoint, matching the logic already used by insert_isar_mounts.=20 >=20 > Logs:=20 > mountpoint -q=20 /work/build/tmp/work/debian-trixie-amd64/isar-image-base-qemuamd64/1.0-r0/r= ootfs//isar-apt=20 &&=20 > umount=20 /work/build/tmp/work/debian-trixie-amd64/isar-image-base-qemuamd64/1.0-r0/r= ootfs//isar-apt=20 >=20 > mountpoint -q=20 /work/build/tmp/work/debian-trixie-amd64/isar-image-base-qemuamd64/1.0-r0/r= ootfs//isar-work=20 &&=20 > umount=20 /work/build/tmp/work/debian-trixie-amd64/isar-image-base-qemuamd64/1.0-r0/r= ootfs//isar-work=20 >=20 > Signed-off-by: Srinuvasan A =20 > ---=20 > meta/classes-global/base.bbclass | 2 +-=20 > 1 file changed, 1 insertion(+), 1 deletion(-)=20 >=20 > diff --git a/meta/classes-global/base.bbclass=20 b/meta/classes-global/base.bbclass=20 > index 8f81ab70..be663fe7 100644=20 > --- a/meta/classes-global/base.bbclass=20 > +++ b/meta/classes-global/base.bbclass=20 > @@ -432,7 +432,7 @@ def insert_isar_umounts(d, rootfs, mounts):=20 >=20 > for m in mounts.split():=20 > host, inner =3D m.split(':') if ':' in m else (m, m)=20 > - mp =3D '{}/{}'.format(rootfs, inner)=20 > + mp =3D '{}/{}'.format(rootfs, inner[1:])=20 This looks fragile. Why not strip off '/', rather than blindly cutting=20 the last char?=20 Jan Thanks for the comments, Here, inner[1:] strips the leading /, as we always assume the paths in=20 ROOTFS_MOUNTS are absolute. For example: ROOTFS_MOUNTS ??=3D "${REPO_ISAR_DIR}/${DISTRO}:/isar-apt=20 ${WORKDIR}:/isar-work" This also follows the same pattern already used by insert_isar_mounts. Many thanks, Srinu > lines.append('mountpoint -q {} && umount {}'.format(mp, mp))=20 > lines.append('[ -d {} ] && rmdir --ignore-fail-on-non-empty=20 {}'.format(mp, mp))=20 > return '\n'.join(lines)=20 --=20 Siemens AG, Foundational Technologies=20 Linux Expert Center=20 --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= d3bd2de6-8c19-4ff0-8920-9f9506dee029n%40googlegroups.com. ------=_Part_70623_358126220.1789125164447 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Friday, September 11, 2026 at 4:19:31= =E2=80=AFPM UTC+5:30 Jan Kiszka wrote:
On 11.09.26 12:16, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuv...@s= iemens.com>
>=20
> ROOTFS_MOUNTS inner paths are absolute, e.g. /isar-apt and
> /isar-work. insert_isar_umounts added another slash between ROOT= FSDIR
> and the inner path, producing paths like rootfs//isar-apt in the
> expanded rootfs_do_umounts_priv task.
>=20
> Strip the leading slash from the inner mount path when building = the
> mountpoint, matching the logic already used by insert_isar_mount= s.
>=20
> Logs:
> mountpoint -q /work/build/tmp/work/debian-trixie-amd64/isar-imag= e-base-qemuamd64/1.0-r0/rootfs//isar-apt &&
> umount /work/build/tmp/work/debian-trixie-amd64/isar-image-base= -qemuamd64/1.0-r0/rootfs//isar-apt
>=20
> mountpoint -q /work/build/tmp/work/debian-trixie-amd64/isar-imag= e-base-qemuamd64/1.0-r0/rootfs//isar-work &&
> umount /work/build/tmp/work/debian-trixie-amd64/isar-image-base= -qemuamd64/1.0-r0/rootfs//isar-work
>=20
> Signed-off-by: Srinuvasan A <sr= inuv...@siemens.com>
> ---
> meta/classes-global/base.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/meta/classes-global/base.bbclass b/meta/classes-glo= bal/base.bbclass
> index 8f81ab70..be663fe7 100644
> --- a/meta/classes-global/base.bbclass
> +++ b/meta/classes-global/base.bbclass
> @@ -432,7 +432,7 @@ def insert_isar_umounts(d, rootfs, mounts):
> =20
> for m in mounts.split():
> host, inner =3D m.split(':') if ':' in m else (m, m)
> - mp =3D '{}/{}'.format(rootfs, inner)
> + mp =3D '{}/{}'.format(rootfs, inner[1:])

This looks fragile. Why not strip off '/', rather than blindly cuttin= g
the last char?

Jan

=C2=A0 Thanks for the comments,=

=C2=A0 Here,=C2=A0inner[1:] strips the leading /, as we always assume th= e paths in ROOTFS_MOUNTS are absolute.

=C2= =A0 For example:

=C2=A0 ROOTFS_MOUNT= S ??=3D "${REPO_ISAR_DIR}/${DISTRO}:/isar-apt ${WORKDIR}:/isar-work"=

=C2=A0 This also follows the same pattern already used by insert_isar_mounts.

=C2=A0 Many thanks,

=C2= =A0 Srinu



> lines.append('mountpoint -q {} && umount {}'.fo= rmat(mp, mp))
> lines.append('[ -d {} ] && rmdir --ignore-fail-= on-non-empty {}'.format(mp, mp))
> return '\n'.join(lines)

--=20
Siemens AG, Foundational Technologies
Linux Expert Center

--
You received this message because you are subscribed to the Google Groups &= quot;isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-use= rs+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-use= rs/d3bd2de6-8c19-4ff0-8920-9f9506dee029n%40googlegroups.com.
------=_Part_70623_358126220.1789125164447-- ------=_Part_70622_1279949770.1789125164447--