public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH 4/7] meta-isar: jh7110-u-boot-spl-image: Fix native build
Date: Fri, 06 Oct 2023 08:52:25 +0300	[thread overview]
Message-ID: <d3c8b566a6137df335df7667d65642d73cfefdd3.camel@ilbers.de> (raw)
In-Reply-To: <330c49e7cad7cec72dc0aae00a250e504dd30fbd.1696530723.git.jan.kiszka@siemens.com>

On Thu, 2023-10-05 at 20:32 +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> In general, recipes must not use HOST_ARCH because it does not
> account
> for ISAR_CROSS_COMPILE being enabled or disabled. This is encoded
> into
> BUILD_HOST_ARCH, though.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  .../jh7110-u-boot-spl-image/jh7110-u-boot-spl-image_0.1.bb      | 2
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-isar/recipes-bsp/jh7110-u-boot-spl-image/jh7110-u-
> boot-spl-image_0.1.bb b/meta-isar/recipes-bsp/jh7110-u-boot-spl-
> image/jh7110-u-boot-spl-image_0.1.bb
> index dbce7c28..cd31c9ca 100644
> --- a/meta-isar/recipes-bsp/jh7110-u-boot-spl-image/jh7110-u-boot-
> spl-image_0.1.bb
> +++ b/meta-isar/recipes-bsp/jh7110-u-boot-spl-image/jh7110-u-boot-
> spl-image_0.1.bb
> @@ -12,7 +12,7 @@ DEPENDS = "jh7110-u-boot-spl-tool-native u-boot-
> starfive-visionfive2"
>  DEBIAN_BUILD_DEPENDS = "jh7110-u-boot-spl-tool:native, u-boot-
> starfive-visionfive2:${DISTRO_ARCH}"
>  
>  # this is a host tool
> -PACKAGE_ARCH = "${HOST_ARCH}"
> +PACKAGE_ARCH = "${BUILD_HOST_ARCH}"
>  

What do you think about renaming variable BUILD_HOST_ARCH to BUILD_ARCH
in Isar? While it's not yet widely used in the recipes, it would better
to do it earlier.

It is an internal Isar variable and renaming should not affect any
downstreams. Renaming  should make us a bit closer to OE, where
BUILD_ARCH has the same meaning.

Additionally, it would fix the issue with sstate-cache and "-native"
packages ( https://groups.google.com/g/isar-users/c/2TNQPOb0IXY ).

>  do_prepare_build[cleandirs] += "${S}/debian"
>  do_prepare_build(){


  reply	other threads:[~2023-10-06  5:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05 18:31 [PATCH 0/7] HOST_ARCH, -native, riscv64, and all the rest Jan Kiszka
2023-10-05 18:31 ` [PATCH 1/7] Revert "base: Fix HOST_ARCH for native builds" Jan Kiszka
2023-10-06  5:44   ` Uladzimir Bely
2023-10-06  5:59     ` Jan Kiszka
2023-10-06  6:04   ` Uladzimir Bely
2023-10-05 18:31 ` [PATCH 2/7] multiarch: Downgrade native dependencies when building in emulated environment Jan Kiszka
2023-10-05 18:31 ` [PATCH 3/7] meta-isar: jh7110-u-boot-spl-tool: Rely on native annotation Jan Kiszka
2023-10-05 18:32 ` [PATCH 4/7] meta-isar: jh7110-u-boot-spl-image: Fix native build Jan Kiszka
2023-10-06  5:52   ` Uladzimir Bely [this message]
2023-10-06  6:00     ` Jan Kiszka
2023-10-06  6:06       ` Uladzimir Bely
2023-10-05 18:32 ` [PATCH 5/7] meta-isar: u-boot-starfive-visionfive2: Simplify build dependencies Jan Kiszka
2023-10-05 18:32 ` [PATCH 6/7] linux-custom: Drop unused template variable Jan Kiszka
2023-10-05 18:32 ` [PATCH 7/7] Move riscv64 from sid-ports to regular sid Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3c8b566a6137df335df7667d65642d73cfefdd3.camel@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox