public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: Zhihang Wei <wzh@ilbers.de>, Anton Mikanovich <amikan@ilbers.de>,
	isar-users@googlegroups.com,
	Felix Moessbauer <felix.moessbauer@siemens.com>,
	Quirin Gylstorff <quirin.gylstorff@siemens.com>
Cc: Uladzimir Bely <ubely@ilbers.de>
Subject: Re: [PATCH v6 4/4] meta: Deploy DTBs once per kernel
Date: Mon, 20 Apr 2026 18:09:01 +0200	[thread overview]
Message-ID: <d518e461-056b-46f0-80b9-1b76ed3a8018@siemens.com> (raw)
In-Reply-To: <837a3122-7cf6-4284-a9b0-98ae0845fa88@ilbers.de>

On 20.04.26 18:06, Zhihang Wei wrote:
> 
> 
> On 4/17/26 16:42, Jan Kiszka wrote:
>> On 17.04.26 16:17, Zhihang Wei wrote:
>>>
>>> On 2/13/26 09:01, 'Jan Kiszka' via isar-users wrote:
>>>> On 13.02.26 08:40, Anton Mikanovich wrote:
>>>>> From: Uladzimir Bely <ubely@ilbers.de>
>>>>>
>>>>> Task do_copy_boot_files deploys DTB files into the same location for
>>>>> different images (e.g., isar-image-base and isar-image-ci). This
>>>>> causes
>>>>> a build error.
>>>>>
>>>>> do_copy_boot_files is called once for every image recipe while dtb
>>>>> files
>>>>> belong to the kernel which is the same for both images. Performing dtb
>>>>> deployment once for the same kernel solves the issue.
>>>>>
>>>> This remains inconsistent: DTBs are just another artifact of the
>>>> kernel.
>>> Since DTB belongs to the kernel and should stay with it, how about
>>> moving both kernel and DTB deployment together into a separate recipe,
>>> rather than keeping them in the image generation process? Logically,
>>> the deployment of these artifacts does not belong to the image
>>> generation process. With this approach, kernel and DTB are only
>>> deployed once, DTB names remain the same. We do have one API change
>>> here, kernel image names are no longer prefixed with the image name.
>> The image selects the kernel it wants (and thus also the DTBs). We could
>> create a meta recipe/package that expresses this selection and deploy
>> from there, but it will cause quick some churn down the line as well.
>> I'm also not sure if it will actually change anything our problem this
>> way because in the end it is about deploying twice, not about from where
>> (image or some recipe).
>>
>> Jan
>>
> If the kernel/DTB deployment becomes a separate task and image creation
> depends on it, wouldn't the second image simply reuse the
> already-completed task rather than deploying again? The dependency would
> be marked as done, so the "deploying twice" issue should be avoided.
> 
> Did I miss something here?

Isn't the main problem that two different images with different
parameters (distros...) may deploy to the same path? This is why I say
it's irrelevant from where we deploy, what matters is the destination.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/d518e461-056b-46f0-80b9-1b76ed3a8018%40siemens.com.

  reply	other threads:[~2026-04-20 16:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  7:40 [PATCH v6 0/4] Deploy DTBs with separate recipe Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 1/4] wic: Obtain real machine name in isoimage source plugin Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 2/4] testsuite: Add testcases to check dtb deployment Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 3/4] meta: Fix do_copy_boot_files error for different distros of same machine Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 4/4] meta: Deploy DTBs once per kernel Anton Mikanovich
2026-02-13  8:01   ` 'Jan Kiszka' via isar-users
2026-02-16 17:15     ` Baurzhan Ismagulov
2026-02-16 17:51       ` 'Jan Kiszka' via isar-users
2026-02-18 16:21         ` Baurzhan Ismagulov
2026-02-18 16:45           ` 'Jan Kiszka' via isar-users
2026-04-17 14:17     ` Zhihang Wei
2026-04-17 14:42       ` 'Jan Kiszka' via isar-users
2026-04-20 16:06         ` Zhihang Wei
2026-04-20 16:09           ` 'Jan Kiszka' via isar-users [this message]
2026-04-18  4:19       ` Roberto A. Foglietta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d518e461-056b-46f0-80b9-1b76ed3a8018@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=amikan@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=quirin.gylstorff@siemens.com \
    --cc=ubely@ilbers.de \
    --cc=wzh@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox