public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: srinuvasan.a@siemens.com, isar-users@googlegroups.com
Subject: Re: [PATCH v5] debianize: set appropriate Standards-Version for each debian suite
Date: Tue, 4 Nov 2025 13:58:07 +0100	[thread overview]
Message-ID: <d533716c-0bbf-4299-bb85-f436340a6e3f@siemens.com> (raw)
In-Reply-To: <20251104095033.273857-1-srinuvasan.a@siemens.com>

On 04.11.25 10:50, srinuvasan.a via isar-users wrote:
> From: srinuvasan <srinuvasan.a@siemens.com>
> 
> The Standards-Version field in debian/control declares the Debian Policy
> version that the package complies with. Currently, the custom source packages
> use a hard-coded Standards-Version: 3.9.6, which is obsolete and does not align
> with the policies of newer Debian releases
> 
> Update the packaging to set the correct Standards-Version dynamically based on
> the target Debian suite, ensuring compliance with the appropriate Debian Policy
> version for each release.
> 
> Debian Policy evolves over time, newer versions may add, remove, or deprecate
> control fields and packaging behaviors. Using an outdated Standards-Version
> can miss required or recommended fields, leading to QA or functional issues.
> 
> Examples:
>   - Rules-Requires-Root (Policy 4.1.0): declares if root privileges are needed
>     during debian/rules execution, improves reproducibility and isolation.
>   - Homepage (Policy 3.9.3): provides upstream project link for better metadata.
> 
> Older Standards-Version(Policy 3.9.6) may trigger lintian warnings such as:
>   W: source: missing-rules-requires-root-field
>   W: source: missing-homepage-field
> 
> Keeping Standards-Version current ensures clean builds, QA compliance,
> and future compatibility.
> 
> Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
> ---
>  RECIPE-API-CHANGELOG.md        |  8 ++++++++
>  meta/classes/debianize.bbclass | 12 ++++++++++--
>  2 files changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> index cf04fa5c..31512561 100644
> --- a/RECIPE-API-CHANGELOG.md
> +++ b/RECIPE-API-CHANGELOG.md
> @@ -242,6 +242,14 @@ consumption by imaging classes.
>  Additional build dependencies of auto-debianized packages can now be defined
>  by setting DEBIAN_BUILD_DEPENDS.
>  
> +### Add DEBIAN_STANDARDS_VERSION as a deb_debianize parameter
> +
> +By default, the Standards-Version field in the debian/control file is automatically
> +set based on the corresponding Debian suite.
> +If you need to override this default value, you can do so by defining
> +the DEBIAN_STANDARDS_VERSION variable in your recipe.
> +E.x: `DEBIAN_STANDARDS_VERSION:<suite-name> = <version>`
> +
>  ### Separation of ${S} and ${D} in dpkg-raw
>  
>  ${S} can now be used for checking out sources without being linked implicitly
> diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
> index 1f54e8f9..247489ea 100644
> --- a/meta/classes/debianize.bbclass
> +++ b/meta/classes/debianize.bbclass
> @@ -24,6 +24,13 @@ MAINTAINER ??= "Unknown maintainer <unknown@example.com>"
>  
>  DEBIANIZE_BUILD_DEPENDS ?= "debhelper-compat (= ${DEBIAN_COMPAT}), ${DEBIAN_BUILD_DEPENDS}"
>  
> +DEBIAN_STANDARDS_VERSION:buster ?= "4.3.0"
> +DEBIAN_STANDARDS_VERSION:bullseye ?= "4.5.1"
> +DEBIAN_STANDARDS_VERSION:bookworm ?= "4.6.2"
> +DEBIAN_STANDARDS_VERSION:trixie ?= "4.7.2"
> +DEBIAN_STANDARDS_VERSION:sid ?= "4.7.2"
> +DEBIAN_STANDARDS_VERSION ?= "3.9.6"
> +

Maybe even put that into meta/conf/distro/debian*.conf, similar to
DISTRO_GCC? Or define DEBIAN_STANDARDS_VERSION_DEFAULT there and do

DEBIAN_STANDARDS_VERSION ?= "${DEBIAN_STANDARDS_VERSION_DEFAULT}"

here.

>  deb_add_changelog() {
>  	changelog_v="${CHANGELOG_V}"
>  	timestamp="${DEBIAN_CHANGELOG_TIMESTAMP}"
> @@ -80,14 +87,15 @@ deb_create_control[vardeps] += "DEBIANIZE_BUILD_DEPENDS \
>                                  DEBIAN_BREAKS \
>                                  DEBIAN_BUILT_USING \
>                                  DEBIAN_CONFLICTS \
> -                                DEBIAN_RULES_REQUIRES_ROOT"
> +                                DEBIAN_RULES_REQUIRES_ROOT \
> +                                DEBIAN_STANDARDS_VERSION"
>  deb_create_control() {
>  	# Add Source section
>  	cat << EOF > ${S}/debian/control
>  Source: ${BPN}
>  Section: ${@ deb_list_beautify(d, 'DEBIAN_SECTION')}
>  Priority: optional
> -Standards-Version: 3.9.6
> +Standards-Version: ${DEBIAN_STANDARDS_VERSION}
>  Maintainer: ${MAINTAINER}
>  Build-Depends: ${@ deb_list_beautify(d, 'DEBIANIZE_BUILD_DEPENDS')}
>  EOF

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/d533716c-0bbf-4299-bb85-f436340a6e3f%40siemens.com.

      reply	other threads:[~2025-11-04 12:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27 11:53 [PATCH] " srinuvasan.a via isar-users
2025-10-28 11:56 ` 'Florian Bezdeka' via isar-users
2025-10-29 12:02   ` [PATCH v2] " srinuvasan.a via isar-users
2025-10-29 15:25     ` 'Jan Kiszka' via isar-users
2025-10-31  6:11       ` Srinuvasan Arjunan
2025-11-03 11:07         ` [PATCH v3] " srinuvasan.a via isar-users
2025-11-03 14:51           ` [PATCH v4] " srinuvasan.a via isar-users
2025-11-03 14:56             ` 'Isaac True' via isar-users
2025-11-04  6:44               ` Srinuvasan Arjunan
2025-11-04  9:50                 ` [PATCH v5] " srinuvasan.a via isar-users
2025-11-04 12:58                   ` 'Jan Kiszka' via isar-users [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d533716c-0bbf-4299-bb85-f436340a6e3f@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=srinuvasan.a@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox