public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	isar-users <isar-users@googlegroups.com>
Cc: Henning Schild <henning.schild@siemens.com>
Subject: Re: [PATCH 0/7] u-boot-script rework, the Final One (tm)
Date: Thu, 29 Nov 2018 15:15:59 +0300	[thread overview]
Message-ID: <d54ddfb4-c8e7-ce64-1e2b-eb82015b08ab@ilbers.de> (raw)
In-Reply-To: <cover.1543225142.git.jan.kiszka@siemens.com>

On 11/26/18 12:38 PM, Jan Kiszka wrote:
> Yes, another rework of the u-boo-script interface. I finally realized
> that the current approach of packaging the machine- or even image-
> specific configuration along with the script generator is broken: It
> cannot easily account for different targets requesting different
> configurations. This breakes in multiconfig scenarios with different
> targets of the same architecture.
> 
> Rather than hacking further on the recipe and package, this now pushes
> the /etc/default/u-boot-script generation to wic. For that, a new plugin
> is introduced, rootfs-u-boot, which is inheriting the rootfs plugin. The
> reason to choose rootfs as hook, rather than some bootimg plugin, is
> that there are systems that do not have U-Boot in a regular partition
> but still want to use u-boot-script.
> 
> Along this change come a few directly or indirectly related cleanups.
> 
> Jan

Applied to the 'next' (except dropped patch #2 "wic: Remove obsolete 
reference to msger logger").

Thanks,
Maxim.

> Jan Kiszka (7):
>    wic: Move isar plugins out of example layer to core
>    wic: Remove obsolete reference to msger logger
>    meta-isar: Factor out bananapi machine config
>    wic: Add rootfs-u-boot
>    meta-isar: Switch bananapi and de0-nano-soc to rootfs-u-boot
>    u-boot-script: Make truly generic
>    meta: Fold wks-file class into wic-img
> 
>   .../bananapi.conf}                                 |  5 +-
>   meta-isar/conf/machine/de0-nano-soc.conf           |  2 +-
>   meta-isar/conf/multiconfig/bananapi-stretch.conf   | 17 +---
>   meta-isar/scripts/lib/wic/canned-wks/bananapi.wks  |  2 +-
>   .../scripts/lib/wic/canned-wks/de0-nano-soc.wks    |  2 +-
>   meta/classes/wic-img.bbclass                       | 26 ++++++-
>   meta/classes/wks-file.bbclass                      | 30 -------
>   .../recipes-bsp/u-boot-script/u-boot-script_1.0.bb | 81 -------------------
>   .../recipes-bsp/u-boot-script/u-boot-script_1.1.bb | 28 +++++++
>   .../lib/wic/plugins/source/bootimg-efi-isar.py     |  0
>   .../lib/wic/plugins/source/bootimg-pcbios-isar.py  |  0
>   .../lib/wic/plugins/source/rootfs-u-boot.py        | 91 ++++++++++++++++++++++
>   scripts/lib/wic/plugins/source/rootfs.py           |  7 +-
>   13 files changed, 152 insertions(+), 139 deletions(-)
>   copy meta-isar/conf/{multiconfig/bananapi-stretch.conf => machine/bananapi.conf} (79%)
>   delete mode 100644 meta/classes/wks-file.bbclass
>   delete mode 100644 meta/recipes-bsp/u-boot-script/u-boot-script_1.0.bb
>   create mode 100644 meta/recipes-bsp/u-boot-script/u-boot-script_1.1.bb
>   rename {meta-isar => meta}/scripts/lib/wic/plugins/source/bootimg-efi-isar.py (100%)
>   rename {meta-isar => meta}/scripts/lib/wic/plugins/source/bootimg-pcbios-isar.py (100%)
>   create mode 100644 meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

      parent reply	other threads:[~2018-11-29 12:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26  9:38 Jan Kiszka
2018-11-26  9:38 ` [PATCH 1/7] wic: Move isar plugins out of example layer to core Jan Kiszka
2018-11-26  9:38 ` [PATCH 2/7] wic: Remove obsolete reference to msger logger Jan Kiszka
2018-11-26  9:45   ` Henning Schild
2018-11-26  9:50     ` Jan Kiszka
2018-11-26 10:07       ` Henning Schild
2018-11-26 11:02         ` Jan Kiszka
2018-11-26  9:38 ` [PATCH 3/7] meta-isar: Factor out bananapi machine config Jan Kiszka
2018-11-26  9:38 ` [PATCH 4/7] wic: Add rootfs-u-boot Jan Kiszka
2018-11-26  9:39 ` [PATCH 5/7] meta-isar: Switch bananapi and de0-nano-soc to rootfs-u-boot Jan Kiszka
2018-11-26  9:39 ` [PATCH 6/7] u-boot-script: Make truly generic Jan Kiszka
2018-11-26  9:39 ` [PATCH 7/7] meta: Fold wks-file class into wic-img Jan Kiszka
2018-11-29 12:15 ` Maxim Yu. Osipov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d54ddfb4-c8e7-ce64-1e2b-eb82015b08ab@ilbers.de \
    --to=mosipov@ilbers.de \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox