From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6628101528005640192 X-Received: by 2002:a05:6402:286:: with SMTP id l6mr337915edv.11.1543493767326; Thu, 29 Nov 2018 04:16:07 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:a843:: with SMTP id dx3-v6ls378642ejb.7.gmail; Thu, 29 Nov 2018 04:16:06 -0800 (PST) X-Google-Smtp-Source: AFSGD/UAXoceE9DcSmlkMCd92opaaGoke834gbGtNxZ5NPfUSSq/D8mEAlFOuR85y0ZuWxMPY/Ho X-Received: by 2002:a17:906:6006:: with SMTP id o6-v6mr310682ejj.4.1543493766938; Thu, 29 Nov 2018 04:16:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543493766; cv=none; d=google.com; s=arc-20160816; b=l/OjN9yfFTRDz3bYtE+ooY3H9hCax9R2v6yILkeDDS8rwSkD8BFZXai/W9hVbvhzk+ wqa3ZHjntzePTJKof7LoV7Vnx8BHu4VP7CNjACWtf5ii1QswM9lzj3Ib++24fPUBD6h5 V+Pq6h79286aq24qbKFwzJICK7M5XCsBBq8ueZNTMP52Ebc6031GhJVJfqYaQSu0aHra uwI3x0lnNXiYuh94dWiGMH5UnBX+kgk0O8jXFMgCzjM9IZrIWEjFnII/L46smWzQZyoe jTlHdmdx9DCIKtObAsLv4/5IU/fgch1m/pJlswIkI1AtxS5CJZrtZXhUowGexX87vG71 bHnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=F72EXHvTCBlBqnIDT/qalGKODU5EYHiVvGCxAGNuAi0=; b=GvncDiUmCajczmF4pLALE2SZy5GkFLNlhNhl5zzDUy3Auy74QfLk/O7B/+CIRw1jbT 9xwDTyMnOMO9RvEoB8WtONFw0eI3jDN3Y5fqnilmHNjjM9Wh7PcuyxwoqDeb8Q1diV4w dxurux5XPEfScyzxRx46coCThvvdKnMESFd6lTg2l7KhqLphhQ+YuXsVqIAF8GMmMERZ aYCb270SpXT7smxYrtqT9tNGWRxC8zeUiXhPK/ACobiG+mPU+wCPZWHPBSLmq4r8Gs1H zqQN8Heg9xqEgtty6tDdEjpGGzfDrRqkVOs9MF+a4/Z9lGmKwLYhnCKsX8ZQ00okWVUS MZtg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id h28si90099edh.4.2018.11.29.04.16.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Nov 2018 04:16:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id wATCG4vw017077 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 29 Nov 2018 13:16:06 +0100 Subject: Re: [PATCH 0/7] u-boot-script rework, the Final One (tm) To: Jan Kiszka , isar-users Cc: Henning Schild References: From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: Date: Thu, 29 Nov 2018 15:15:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: FIzyOb/upm5f On 11/26/18 12:38 PM, Jan Kiszka wrote: > Yes, another rework of the u-boo-script interface. I finally realized > that the current approach of packaging the machine- or even image- > specific configuration along with the script generator is broken: It > cannot easily account for different targets requesting different > configurations. This breakes in multiconfig scenarios with different > targets of the same architecture. > > Rather than hacking further on the recipe and package, this now pushes > the /etc/default/u-boot-script generation to wic. For that, a new plugin > is introduced, rootfs-u-boot, which is inheriting the rootfs plugin. The > reason to choose rootfs as hook, rather than some bootimg plugin, is > that there are systems that do not have U-Boot in a regular partition > but still want to use u-boot-script. > > Along this change come a few directly or indirectly related cleanups. > > Jan Applied to the 'next' (except dropped patch #2 "wic: Remove obsolete reference to msger logger"). Thanks, Maxim. > Jan Kiszka (7): > wic: Move isar plugins out of example layer to core > wic: Remove obsolete reference to msger logger > meta-isar: Factor out bananapi machine config > wic: Add rootfs-u-boot > meta-isar: Switch bananapi and de0-nano-soc to rootfs-u-boot > u-boot-script: Make truly generic > meta: Fold wks-file class into wic-img > > .../bananapi.conf} | 5 +- > meta-isar/conf/machine/de0-nano-soc.conf | 2 +- > meta-isar/conf/multiconfig/bananapi-stretch.conf | 17 +--- > meta-isar/scripts/lib/wic/canned-wks/bananapi.wks | 2 +- > .../scripts/lib/wic/canned-wks/de0-nano-soc.wks | 2 +- > meta/classes/wic-img.bbclass | 26 ++++++- > meta/classes/wks-file.bbclass | 30 ------- > .../recipes-bsp/u-boot-script/u-boot-script_1.0.bb | 81 ------------------- > .../recipes-bsp/u-boot-script/u-boot-script_1.1.bb | 28 +++++++ > .../lib/wic/plugins/source/bootimg-efi-isar.py | 0 > .../lib/wic/plugins/source/bootimg-pcbios-isar.py | 0 > .../lib/wic/plugins/source/rootfs-u-boot.py | 91 ++++++++++++++++++++++ > scripts/lib/wic/plugins/source/rootfs.py | 7 +- > 13 files changed, 152 insertions(+), 139 deletions(-) > copy meta-isar/conf/{multiconfig/bananapi-stretch.conf => machine/bananapi.conf} (79%) > delete mode 100644 meta/classes/wks-file.bbclass > delete mode 100644 meta/recipes-bsp/u-boot-script/u-boot-script_1.0.bb > create mode 100644 meta/recipes-bsp/u-boot-script/u-boot-script_1.1.bb > rename {meta-isar => meta}/scripts/lib/wic/plugins/source/bootimg-efi-isar.py (100%) > rename {meta-isar => meta}/scripts/lib/wic/plugins/source/bootimg-pcbios-isar.py (100%) > create mode 100644 meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov