Re: [PATCH 2/2] centralize multistrap configuration generation

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Baurzhan,

On 02/15/2018 12:42 PM, Baurzhan Ismagulov wrote:
> On Wed, Feb 14, 2018 at 02:15:09PM +0100, claudius.heine.ext@siemens.com wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>> Previous there was redundant code between the buildchroot and
>> isar-image-base recipe.
>>
>> This patch moves the generation of the multistrap configuration to a
>> central python script that can be parametrized by both recipes.
>>
>> Signed-off-by: Claudius Heine <ch@denx.de>
>> ---
>>   .../recipes-core/images/files/multistrap.conf.in   | 38 ----------
>>   meta/lib/isar/multistrap.py                        | 80 ++++++++++++++++++++++
>>   .../buildchroot/files/multistrap.conf.in           | 37 ----------
> 
> Could you please post two final multistrap.confs you'd like to get with your
> changes?

'like to get'? I don't want to get any other multistrap.conf than 
before. This is not a change of the multistrap.conf files, but just how 
they are generated. The python configparser created ini-file format only 
puts spaces around the '=' characters, but the resulting deserialized 
objects is the same.

Ok, that is not 100% true, I changed the name of the isar repository 
section. Now its called 'isar' in the image (previously 'Isar') and 
buildchroot (previously 'isar-apt') multiconfig. But that is it. It has 
no different effect outside of multistrap.

> I'd like to understand the reasons for moving from templates to a magic
> generator.
> 
> In my experience, magic is usually poorly documented (if at all) and very
> ununderstandable for users. Simple change of a line requires locating the
> generator, understanding what it does (they tend to be hairy with tons of
> conditions) and patching the upstream [Isar] code. Templates have their
> disadvantages, but are straightforward for users. In general, I'd like to keep
> the current UX and stick with templates, which is possible most of the time.

You prefer duplicated code? Two slightly different templates for two 
buildchroot and image recipe?

Also this patch is only an intermediate step of the way for multi-repo 
support. IMO it has value on its own, since it centralized the 
generation of the multistrap configuration.
The current kind of 'template' does not support creating repository 
entries on the fly. It might be possible to extent the multiconfig with 
shell scripting, but I prefer using python for such advanced logic.

regards,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de