public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Bezdeka, Florian" <florian.bezdeka@siemens.com>
To: "roberto.foglietta@gmail.com" <roberto.foglietta@gmail.com>,
	"Schmidt, Adriaan" <adriaan.schmidt@siemens.com>
Cc: "ubely@ilbers.de" <ubely@ilbers.de>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"Kiszka, Jan" <jan.kiszka@siemens.com>,
	"MOESSBAUER, FELIX JONATHAN" <felix.moessbauer@siemens.com>,
	"Schild, Henning" <henning.schild@siemens.com>
Subject: Re: [PATCH 1/1] Reduce disk usage during build by avoiding copies of apt cache
Date: Wed, 4 Jan 2023 11:00:55 +0000	[thread overview]
Message-ID: <d5a86d7a1be19274f85e8497ea0f5b959006f23a.camel@siemens.com> (raw)
In-Reply-To: <CAJGKYO5nBJYoSwG6eN3GFsbwpjZttWXYQC1ygJW=3pnyXNVCFA@mail.gmail.com>

On Wed, 2023-01-04 at 11:26 +0100, Roberto A. Foglietta wrote:
> On Wed, 4 Jan 2023 at 07:10, Schmidt, Adriaan
> <adriaan.schmidt@siemens.com> wrote:
> 
> > > @@ -308,7 +307,8 @@ rootfs_install_sstate_prepare() {
> > >      # so we use some mount magic to prevent that
> > >      mkdir -p ${WORKDIR}/mnt/rootfs
> > >      sudo mount --bind ${WORKDIR}/rootfs ${WORKDIR}/mnt/rootfs -o ro
> > > -    sudo tar -C ${WORKDIR}/mnt -cpSf rootfs.tar --one-file-system rootfs
> > > +    lopts="--one-file-system --exclude-caches --exclude=var/cache/apt/archives"
> > 
> > (several locations):
> > With the creation of CACHEDIR.TAG, and --exclude-caches, isn't the --exclude=
> > of that same path redundant?
> 
> Hi Adriaan,
> 
> if you look at this, everything has been achieved using exclude option
> 
>  sudo tar --one-file-system --exclude="var/log/*" \
> --exclude="var/cache/*" --exclude="var/backups/*" \
> --exclude="var/tmp/*" --exclude="var/crash/*" \
> --exclude="var/spool/*" --exclude="var/lib/apt/*" \
> --exclude-caches --exclude-backups -C ${WORKDIR}/mnt \
> -cpSf rootfs.tar rootfs
> 
> however exclude backups and caches are still in place because the user
> might define further ignoring locations using different ways.
> 
> P.S.: I have updated and rebased the cherry picking on my 'next'
> branch and it works pretty well despite is just a subset of all the
> patches I am experimenting.

Roberto, 

nice to see you working on that, but: if you want us to look at
something (especially on code/patches) please send them - with the
right version tag - to the list. We can't go and check your repo every
time and follow all the activity (especially rebasing) that is going on
there.

Someone already mentioned that: We need to look at patches that are
based on current Isar next branch. Everything else is basically
unusable for us.

Best regards,
Florian

> 
> Best regards, R-


  reply	other threads:[~2023-01-04 11:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04  2:31 Felix Moessbauer
2023-01-04  3:36 ` Roberto A. Foglietta
2023-01-04  3:45   ` Roberto A. Foglietta
2023-01-04  6:10 ` Schmidt, Adriaan
2023-01-04 10:26   ` Roberto A. Foglietta
2023-01-04 11:00     ` Bezdeka, Florian [this message]
2023-01-04 11:15       ` Roberto A. Foglietta
2023-01-04  8:15 ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5a86d7a1be19274f85e8497ea0f5b959006f23a.camel@siemens.com \
    --to=florian.bezdeka@siemens.com \
    --cc=adriaan.schmidt@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=roberto.foglietta@gmail.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox