From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6920502129401528320 X-Received: by 2002:a05:651c:2049:: with SMTP id t9mr11120623ljo.505.1612800425048; Mon, 08 Feb 2021 08:07:05 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:4adc:: with SMTP id m28ls4368024lfp.0.gmail; Mon, 08 Feb 2021 08:07:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzUnMxC46NSxBvRhR+iVEp8HLSG/Hi8JwKgElfLLDQl6u+5UMnEmfqfuI+5YZooSIwmj4m2 X-Received: by 2002:ac2:53b1:: with SMTP id j17mr11762248lfh.477.1612800423975; Mon, 08 Feb 2021 08:07:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612800423; cv=none; d=google.com; s=arc-20160816; b=hCBfeGPTe3USFfDijlsZMIeoVD5xRfE/Sj+VXBPZk7y6WFmJH2scM+YxPZsK02oQDo kvjSVW2UPUZroCgEf4ry3eBrnkEqh5Ay4v3ClWQgB2wDo6NsiEBNDJtv0wGWDYun8BoD IEwNsp/56+lR5lWUoVERCeMU4NucTrC8pzS5qbdM7crFhbMd1qi5+Ijg0rezvE+w4w2e ZhIV2a4+wP34Q0tjR6ZSZejo+aOeYVawaskfO1rNHjbmngdv1suMqVBKXDkuCPm7P4X6 EFCjfNcVlsV6bhZ7JudHad+8TtMDQkKhD5tfNdHng9+9mIOjzWFZbYXolpLMOZNsHilq P3Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=5TPSB7+3saNvzap80NsXvdPX9VBp3ByJHTSKUFZpES0=; b=nSMsrL+z3sCWU3LmaCizL9WlM0R44Xg5BXMrtyegQo6irV4mUbxyUUTdprE1n5TChO TcyV5wnFH5RRCc2aCGqqy/Kr/a0pN7evYhtSvaazeTJYZ+2P0WfUumh5JB2dWHpMrJW9 H3w5aU1w3R5fTUyECuZL5SpGR3DuXYPWSjpxe1/yz9jAZyaqyczuLLjS86Cz3FTBVh3b iqU+K2+cpN/mvO4c6oUJVoUdWSaI5ZnTL5kHZb+1D+MxEw3KDUXlI5guHWUgYJKrV+6o SfEvUcxHpgb500vvTuuChpSKIEy9PBqNyv5QAnnsHaCG2nCqz87fFHQftX5+VqfnzIgO UJ3w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 191si279143lfa.4.2021.02.08.08.07.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Feb 2021 08:07:03 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [192.168.67.164] (mm-203-30-214-37.mgts.dynamic.pppoe.byfly.by [37.214.30.203] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 118G71rm003229 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 Feb 2021 17:07:02 +0100 Subject: Re: [PATCH 1/3] dpkg: adjust task order to allow using "git" for patching To: Henning Schild , Jan Kiszka Cc: isar-users References: <20210122084241.10573-1-henning.schild@siemens.com> <20210122084241.10573-2-henning.schild@siemens.com> <2a620d4e-3b5d-65fa-5af5-cd656c448e6b@siemens.com> <20210122144046.363d033a@md1za8fc.ad001.siemens.net> From: Anton Mikanovich Message-ID: Date: Mon, 8 Feb 2021 19:06:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210122144046.363d033a@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: ipL4H3RpgGnc 22.01.2021 16:40, Henning Schild wrote: > Am Fri, 22 Jan 2021 11:53:58 +0100 > schrieb Jan Kiszka : > >> On 22.01.21 09:42, [ext] Henning Schild wrote: >>> From: Henning Schild >>> >>> The adjust_git task breaks the git tree for use outside the >>> buildchroot. And our patch implementation supports using "git am" >>> when setting PATCHTOOL = "git". In order to actually apply git >>> patches we have to adjust after patching. >> That will likely not work as is when rerunning the job for a partial >> rebuild, e.g. after adding a patch and not changing the git URL. We >> now need a "restore_git" prior to patch, no? > I was also afraid of that. So i tried modifying a patch, which triggerd > a new fetch/unpack cycle and was fine. I guess adding a patch will do > the same. > Changing the patch function would become problematic, but that is a > task for isar developers. > > So i am almost certain that will not cause fun on partial rebuilds. > > Henning > If you've already tested partial rebuild and there is no issues can we proceed with apply? -- Anton Mikanovich Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov