From: Jan Kiszka <jan.kiszka@siemens.com>
To: "[ext] Silvano Cirujano Cuesta"
<silvano.cirujano-cuesta@siemens.com>,
isar-users@googlegroups.com, Anton Mikanovich <amikan@ilbers.de>
Subject: Re: [PATCH v2] fix: remove unneeded unconditional recipes
Date: Thu, 15 Apr 2021 09:35:03 +0200 [thread overview]
Message-ID: <d6aafd1b-5fa6-12df-9622-d1d2c8fea814@siemens.com> (raw)
In-Reply-To: <20210414151806.56876-1-silvano.cirujano-cuesta@siemens.com>
On 14.04.21 17:18, [ext] Silvano Cirujano Cuesta wrote:
> Commit 9c3499adf91 introduced the unconditional inclusion of the recipes
> isar-exclude-docs and isar-disable-apt-cache, but they would only needed
> for container images.
>
> That would have been anyway an optimization with questionable demand,
> therefore removing it.
>
> Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
> ---
> meta/classes/image-container-extension.bbclass | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/meta/classes/image-container-extension.bbclass b/meta/classes/image-container-extension.bbclass
> index f693627..e26604a 100644
> --- a/meta/classes/image-container-extension.bbclass
> +++ b/meta/classes/image-container-extension.bbclass
> @@ -6,7 +6,6 @@
> # This class extends the image.bbclass for containerizing the root filesystem.
>
> CONTAINER_FORMATS ?= "docker-archive"
> -IMAGE_INSTALL += "isar-exclude-docs isar-disable-apt-cache"
>
> containerize_rootfs() {
> local cmd="/bin/dash"
>
Thanks!
This is a high-prio regression fix IMHO.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2021-04-15 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 15:18 Silvano Cirujano Cuesta
2021-04-15 7:35 ` Jan Kiszka [this message]
2021-04-22 10:29 ` Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6aafd1b-5fa6-12df-9622-d1d2c8fea814@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=silvano.cirujano-cuesta@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox