From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6950664923339816960 X-Received: by 2002:a17:906:2a16:: with SMTP id j22mr2051426eje.247.1618472549148; Thu, 15 Apr 2021 00:42:29 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:ca0c:: with SMTP id jt12ls2243492ejb.11.gmail; Thu, 15 Apr 2021 00:42:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5m4oA40EmnK241L7begmu62/S17YQ9QUPpk3nr3hv1Chag8VKQN8sqqbz3xEb0+ZQYza6 X-Received: by 2002:a17:906:3544:: with SMTP id s4mr2103961eja.73.1618472548206; Thu, 15 Apr 2021 00:42:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618472548; cv=none; d=google.com; s=arc-20160816; b=v5C5VhVKJSm2r8xztLAbkrtS+3PgdbLxxctQALHm1ebzQo3JVFB4v1IY52Gs/d8fMX lU+4g+oMYGOt9GIW1k1+4Lhqp6xxh6S3RIWVTeiJG1VgXen9kHv9gsn26RyRfcNoo6OL 2hm05Vhkuo979Nh+ucEZbm3ovLjHaGixxpzPW0ZG+D04apt7FRf8OH9zZN73NP7gr5+R TyXG9G14BiAkPBAu8pGfdDertrm4so4dbLxHKQrcjCWe/TG1cYkBjFL4Xwm3SMrap9oh DE9b0wlfwbX/wVvWwfFhjPfGp+ew/cVSlkuIEQNvpIydCgkooQ/0PcAT8vAar7yop1m3 9dbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=Prkj6/4F/Z2RL6mKGArIePdGN7zFa8vFb+HURFYGnMo=; b=GWTNMGLpuRM14AC5+kWEbide48gbVGKka9wAC7KLesrfIq1MAcaEx1N5O1fHFDFrvi Uu8lI7YIA91DtiLxd41hzjrvyu74OGnJ9Xg+qxCVpQOJrViZQHHET89WNqxz7uhEn6u+ I6SXJRvjsvrfJccaKwZypi1T5Dp1wFCXqRLdMD5VHt96jLYIDzsmVXYWE/BtnAcgqwhS PRebQeQvloGwwe3UU31GAEFtVPszwi9f8gArVB3zKwdDy0hkCypxjGnELdL6e4V8ZOKc uudr5qDzH202CSLYXzFuWvUxIroJmYmzGcrZftQQdAB/94tc4Q4AwuDpEprYEFmyNMK2 NswQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id c12si106985eds.0.2021.04.15.00.42.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Apr 2021 00:42:28 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 13F7gRq1022463 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Apr 2021 09:42:27 +0200 Received: from [167.87.9.80] ([167.87.9.80]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 13F7Z44k022215; Thu, 15 Apr 2021 09:35:04 +0200 Subject: Re: [PATCH v2] fix: remove unneeded unconditional recipes To: "[ext] Silvano Cirujano Cuesta" , isar-users@googlegroups.com, Anton Mikanovich References: <20210414151806.56876-1-silvano.cirujano-cuesta@siemens.com> From: Jan Kiszka Message-ID: Date: Thu, 15 Apr 2021 09:35:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210414151806.56876-1-silvano.cirujano-cuesta@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 45pRGc9KzgnV On 14.04.21 17:18, [ext] Silvano Cirujano Cuesta wrote: > Commit 9c3499adf91 introduced the unconditional inclusion of the recipes > isar-exclude-docs and isar-disable-apt-cache, but they would only needed > for container images. > > That would have been anyway an optimization with questionable demand, > therefore removing it. > > Signed-off-by: Silvano Cirujano Cuesta > --- > meta/classes/image-container-extension.bbclass | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/meta/classes/image-container-extension.bbclass b/meta/classes/image-container-extension.bbclass > index f693627..e26604a 100644 > --- a/meta/classes/image-container-extension.bbclass > +++ b/meta/classes/image-container-extension.bbclass > @@ -6,7 +6,6 @@ > # This class extends the image.bbclass for containerizing the root filesystem. > > CONTAINER_FORMATS ?= "docker-archive" > -IMAGE_INSTALL += "isar-exclude-docs isar-disable-apt-cache" > > containerize_rootfs() { > local cmd="/bin/dash" > Thanks! This is a high-prio regression fix IMHO. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux