Re: [PATCH] recipes-support: add fsck to initramfs

[Quirin Gylstorff <quirin.gylstorff@siemens.com>]

On 8/14/19 6:31 PM, Henning Schild wrote:
> Am Tue, 13 Aug 2019 17:01:16 +0200
> schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> 
>> On 13.08.19 16:36, [ext] Henning Schild wrote:
>>> Well it looks like the problem is the missing fstab
>>> line. /usr/share/initramfs-tools/hooks/fsck is looking for that to
>>> decide which fsck to include.
>>>
>>> There also seems to be /etc/fstab.d/*.fstab that can be used if we
>>> do not like touching the original fstab. I think Claudius once
>>> removed / from fstab claiming that it was not required.
>>>
>>> The package you get from that changes content based on an image
>>> variable. That must not be done. The fstypes would have to become
>>> part of PN or PV ...
>>>
>>> I think we should get that fstab line back.
>>
>> / is in fstab, but in a generic form. If you add a specific one, you
>> easily start duplicating wic. It's a chicken-egg thing: You need the
>> information during package installation, but you only have it after
>> imaging.
>>
>> BTW, there is enable-fsck for partially the same reason (there other
>> is that you do want to control whether fsck is run in embedded
>> scenarios).
> 
> Fair enough. Let is control which fscks go into the initrd. But i am
> afraid we will need one package per file-system. I guess that should be
> easy to do with one recipe providing many packages.
> And which ones to include would be a matter of
> 
> IMAGE_INSTALL += <initrd-fsck-package>-<fstype>
> 
> And not a new variable.
> 
> At least that sounds like a viable way to implement it.
> 

I will look into it.

Quirin

> Henning
> 
>> Jan
>>
>