From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6722331622445678592 X-Received: by 2002:a2e:3608:: with SMTP id d8mr12006685lja.140.1566198117552; Mon, 19 Aug 2019 00:01:57 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:87d5:: with SMTP id v21ls1579021ljj.5.gmail; Mon, 19 Aug 2019 00:01:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqwYs81P4W6CybLU2VsyAANkEwctUcdPdxooycpaCSNyQ4qJCDuw+sp62g9SRV6aJPpkDTCp X-Received: by 2002:a2e:a16d:: with SMTP id u13mr11842677ljl.55.1566198117109; Mon, 19 Aug 2019 00:01:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566198117; cv=none; d=google.com; s=arc-20160816; b=TXInIbYKjgavkmzqDA9lnWyf2FE3NS8r0p/oUFl/2J0EiLF7D3pUNuJZ+kO0BuzIqN PUrQAioLardAudH1uVImb5R2d/SXIb57+tQork7lcL5eU2VIJpLlw3wMvJsA8KwgnZxc mWXWSdzQ3wB/MM1BAVV99bDK3zuPob0mT0SlzbwogRZeFTegU4iMVrO0pSUANYEyGXVy aDp8HYvKeBztp9ymYKrWyd3APSblKqUmTq35RG70Fw9qBPKiTzsLADU2R9G41UlW2vUV S9aXUSajyjBN7oAGXSkfgs2y+WMcesG1t5DufOQL8rARrvrwphPQl7SXRGtmFoEsoMiI Ic3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=0wH6ijGGWK4AXDnlU9B8Gl27/NlG4utzGd/aubAMsNE=; b=ZXOPYCB4gEUmU4dsSIFyibiYfS+QRn1r38pDmMA2CMwHNHGQwRNahe9R3+OBpmuhR1 DI/2GcgevdiAqse/2OI4CJarGsDmVztzj2iEfYfM4MTd8smA+UDecwPPFWNnJIE+CPPq BkP7TEujhNwj+89lWTX1UmA47iA+3ygwk0CxczrbEJ86/3GZ1OWwbm/E2zwsWE9xuoHx R53I8S7RjI/1zxJ8A0pJ+TYpZ60vOaE1f+G/WLQ3H+LG9oY+uEqvS2CvRzx3sB7Wl2VC ik9dYAFvxCV4Hsr2to3MXc7f9wPWx7lzpEizXzi1d9Xn+zTDpQva8JgLgMfb/Tyt2k1a L8eA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id c12si190092lji.0.2019.08.19.00.01.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 00:01:57 -0700 (PDT) Received-SPF: pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x7J71tlx015337 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 19 Aug 2019 09:01:56 +0200 Received: from [139.23.74.64] ([139.23.74.64]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x7J71t6I027081; Mon, 19 Aug 2019 09:01:55 +0200 Subject: Re: [PATCH] recipes-support: add fsck to initramfs To: Henning Schild , Jan Kiszka Cc: isar-users@googlegroups.com, "[ext] Claudius Heine" References: <20190807075908.17902-1-Quirin.Gylstorff@siemens.com> <20190813163615.0edcfa7c@md1za8fc.ad001.siemens.net> <389814ef-bbb9-32f7-e7b6-d5dba934bcaa@siemens.com> <20190814183119.740050e0@md1za8fc.ad001.siemens.net> From: Quirin Gylstorff Message-ID: Date: Mon, 19 Aug 2019 09:00:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190814183119.740050e0@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: yzwSBybqiLyp On 8/14/19 6:31 PM, Henning Schild wrote: > Am Tue, 13 Aug 2019 17:01:16 +0200 > schrieb Jan Kiszka : > >> On 13.08.19 16:36, [ext] Henning Schild wrote: >>> Well it looks like the problem is the missing fstab >>> line. /usr/share/initramfs-tools/hooks/fsck is looking for that to >>> decide which fsck to include. >>> >>> There also seems to be /etc/fstab.d/*.fstab that can be used if we >>> do not like touching the original fstab. I think Claudius once >>> removed / from fstab claiming that it was not required. >>> >>> The package you get from that changes content based on an image >>> variable. That must not be done. The fstypes would have to become >>> part of PN or PV ... >>> >>> I think we should get that fstab line back. >> >> / is in fstab, but in a generic form. If you add a specific one, you >> easily start duplicating wic. It's a chicken-egg thing: You need the >> information during package installation, but you only have it after >> imaging. >> >> BTW, there is enable-fsck for partially the same reason (there other >> is that you do want to control whether fsck is run in embedded >> scenarios). > > Fair enough. Let is control which fscks go into the initrd. But i am > afraid we will need one package per file-system. I guess that should be > easy to do with one recipe providing many packages. > And which ones to include would be a matter of > > IMAGE_INSTALL += - > > And not a new variable. > > At least that sounds like a viable way to implement it. > I will look into it. Quirin > Henning > >> Jan >> >