From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6460145511672315904 X-Received: by 10.25.84.7 with SMTP id i7mr162867lfb.12.1504860283457; Fri, 08 Sep 2017 01:44:43 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.30.7 with SMTP id e7ls234961wme.20.canary-gmail; Fri, 08 Sep 2017 01:44:43 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDbBkXoeRXNS7NwQqbItkaKenj/gz1dVVofQXxbbiVDfbb5VxhqgfqAh86eUroxshxERlWb X-Received: by 10.28.133.68 with SMTP id h65mr141036wmd.1.1504860283146; Fri, 08 Sep 2017 01:44:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504860283; cv=none; d=google.com; s=arc-20160816; b=HhNYYl5agBkHxDWkow/Er5PpmLoalsXBJta5T4YuN2+xTCwHPh6UuUrf7meHnR2DHD V4S6+ugdGPzaOJjSBD97c1ZdQicm2VxZsH2owweVg19+G9d3cFbyfNu2fDtuc1B8e98V p5u2Zfw6qXmyQEXk4+3ZjzFfg1wPkII9x1mkOkghnrHZvAcJIf2WJv0/Nrw1AGoY70Hp +HUlb4zbk8P+kNMpWahE+xoFYv/L70P68dey8FPM1tUE+Scq+FFJL6NcHCBrReMed+i7 07DCYXSklF0WxwxjXd3u2a5w2QXmU271wqYflYbbGthkvxKm/OC1ijVZUXncGJlrcLVq YLOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:mime-version:user-agent:date:message-id:openpgp:from :references:cc:to:subject:arc-authentication-results; bh=1bTGLEgCX+3ef6wiGqA+PcpDlB8HcRgYvZbNsrJsbAY=; b=FuPpyYouDaJ4yJOwWaEUW5xKwoJSHXByyzI9JuTKbGrvFznUhV2rs7SiV+3lxedaH5 nsSfZlXqkLofsDP9d31ZcHObmNck2pIob80OD9k3jiLLp576JluzFsebf56J3xnH3r9c LKr2Fcor/Qq1L2Afl+qhtfQIo4RWIxaKi03Yw8dvWYttniqEXDuum2RBOXbaF12ulX3y fCiMpfoc+Wycopb/cmsOlh/i173W3xmzQ+iPsAimqgZBLLrVn69+Jl+AGtja5UzKZQw3 GxgCRxlV8tf4aIuaDEI/gjiL7IofQXJpuWQ4YJjAjgkeRiAKvNVn7x2plVUT5IHAqEpm B5mQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id v23si65232wmv.0.2017.09.08.01.44.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Sep 2017 01:44:42 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3xpW8p4zVYz1qqkR; Fri, 8 Sep 2017 10:44:42 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3xpW8p3Vkjz3hjXp; Fri, 8 Sep 2017 10:44:42 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id YV69DDBenL1J; Fri, 8 Sep 2017 10:44:41 +0200 (CEST) X-Auth-Info: 45WHuXmB1SBxATik8Kpx7aqfMTU4QU4i1uzBYLqDm/Y= Received: from leda.denx.de (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 8 Sep 2017 10:44:41 +0200 (CEST) Subject: Re: [PATCH 1/6] meta/dpkg: Make 'do_unpack' more generic, prepare for pulling out To: Henning Schild , Alexander Smirnov Cc: Claudius Heine , isar-users@googlegroups.com References: <6f7b53c5-3238-1d8d-88a7-7afc3859a9ec@ilbers.de> <62849b3a-fd2f-3184-ace0-0941fd3f9325@siemens.com> <20170908103057.34462bf1@md1em3qc> From: Claudius Heine Openpgp: id=6FF2E59F00C6BC2831D864C11173CB199808B153; url=http://pool.sks-keyservers.net/pks/lookup?op=get&search=0x1173CB199808B153 Message-ID: Date: Fri, 8 Sep 2017 10:44:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170908103057.34462bf1@md1em3qc> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EoNcDe0nvPN1kbURLqQ0CbIK6T0t7Jl8t" X-TUID: 8VvAPR2UH6d+ This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EoNcDe0nvPN1kbURLqQ0CbIK6T0t7Jl8t Content-Type: multipart/mixed; boundary="UN5TNbUllDKk3KMqsi5orrUfmJdvdUC8d"; protected-headers="v1" From: Claudius Heine To: Henning Schild , Alexander Smirnov Cc: Claudius Heine , isar-users@googlegroups.com Message-ID: Subject: Re: [PATCH 1/6] meta/dpkg: Make 'do_unpack' more generic, prepare for pulling out References: <6f7b53c5-3238-1d8d-88a7-7afc3859a9ec@ilbers.de> <62849b3a-fd2f-3184-ace0-0941fd3f9325@siemens.com> <20170908103057.34462bf1@md1em3qc> In-Reply-To: <20170908103057.34462bf1@md1em3qc> --UN5TNbUllDKk3KMqsi5orrUfmJdvdUC8d Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: quoted-printable Hi, On 08.09.2017 10:30, Henning Schild wrote: > Am Tue, 5 Sep 2017 10:37:48 +0300 > schrieb Alexander Smirnov : >=20 >> Hi, >> >>>> On 09/04/2017 05:11 PM, Alexander Smirnov wrote: =20 >>>>> On 08/30/2017 10:03 PM, Henning Schild wrote: =20 >>>>>> Issue: >>>>>> The unpacker in dpkg is not generic since it does not unpack to >>>>>> WORKDIR, so it can not be pulled into a more generic class to >>>>>> make it available for other users. >>>>>> =20 >>>>> >>>>> As I already wrote to mail-list, WORKDIR and BUILDROOT are >>>>> different folders, and there was the reason to do so. =20 >>>> >>>> Yes we (Henning and I) get that. That is the reason why the patch=20 >>>> includes the line: >>>> >>>> +WORKDIR_task-unpack =3D "${BUILDROOT}" >>>> >>>> That means that only for the unpack task in the dpkg.bbclass the=20 >>>> variable WORKDIR is set to the BUILDROOT variable. This makes the=20 >>>> unpack step more generic so that it can be moved to the base >>>> class. Essentially removing the dependency of the unpack task to >>>> the dpkg class. =20 >>> >>> Does this mean that "log.do_unpack" and "run.do_unpack" will be >>> stored in buildchroot? Let me check this. >>> =20 >> >> Yes it does: >> >> ls=20 >> isar/build/tmp/work/buildchroot/debian-wheezy-armhf/rootfs/home/builde= r/hello/temp/ >> >> log.do_unpack >> log.do_unpack.19557 >> log.task_order >> run.do_unpack >> run.do_unpack.19557 >> >> While it's assumed that they should be stored in:=20 >> isar/build/tmp/work/hello-0.1+g7f35942-1-r0/temp/ >=20 > I think i am starting to understand the whole problem with the WORKDIR > and the BUILDROOT better. Instead of the unpacking to BUILDROOT or > messing with WORKDIR i think we should have a new task after do_unpack >=20 > So instead of do_unpack -> BUILDROOT >=20 > do_unpack archive -> WORKDIR > do_copy_to_buildroot WORKDIR -> BUILDROOT >=20 > That should keep all the logs in an unmodified WORKDIR and the unpacker= > would always extract to there. Classes that need the files to live in > BUILDROOT would have to include the task do_copy_to_buildroot. I agree with that separating those into two tasks is the better solution, but I don't like the 'copy_to_buildroot' name, because it limits possible implementations of this task by that name. For instance you could, and maybe even should, use a bind mount instead of copying the files around. Something like "populate" or "prepare" as a prefix sounds a bit better IM= O. Cheers, Claudius --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net --UN5TNbUllDKk3KMqsi5orrUfmJdvdUC8d-- --EoNcDe0nvPN1kbURLqQ0CbIK6T0t7Jl8t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlmyWG0ACgkQEXPLGZgI sVNLHxAAjS/ug6UN5EicFAF4F8apBaRlpva9nR99iSzhIFDTD+pW7AW6P0aFSxnu ZehV0nCSLCGqI8a+1Q3ls8eO2Af8S2JNawW7h0MVRQSbBxdICsBkOzZWQRrgCls5 MGmnmBBNpgchug8VCvjdgKW0sc6bFDzCiNuXo9VjICcUWDmhcaH8f75Xe02uzy2X NheVu/UW5Qs2sYtbUfr3GRezr/K8ej0QFEm0TayvCXoBiqkAkeLhDmSMav/Qs7PH oclq44rsjgVO4vzmFgRstA+pXwUa2OT7js8UYxPvhS0VIO/cDVf+aU0CniyhUBsV vnWBn64OWFDqhUbhukp6UZH/NC4k4xgT0/gH4YttMWK+YhzRArgtJl/ZGKJi/J4d kaHoxCT7MLj5nz/u2DpEsIT6pxyL0gkz2VuDh7LhATS7PvU9Xz6Tpwr9mq/Gs4KO jT/DvFJrwuhE7W2plL33SqCryemzqjQw7VR+OhHSDJefIRN64KnyE2Krmrlxsgry Y37RQ1q+ltaFMtfutZvR4KS2da84V7o9TqI7MmNOTW9O3Nq98yIbLorESinrkUXJ E8AlPqgdodv3b5JGHdosgo3X8azCb5opNjVKwd6XJnIRcUryg2mIWQKpuQLvmc7I IU0VyAtmRoGO7s9w+sIiOuXnEIJe0e45GY0UKP40H4NWg+bri7g= =Bg9d -----END PGP SIGNATURE----- --EoNcDe0nvPN1kbURLqQ0CbIK6T0t7Jl8t--