public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "MOESSBAUER, Felix" <felix.moessbauer@siemens.com>
Subject: Re: [PATCH v2 4/4] multiarch: Fix SRC_URI:remove ignoring
Date: Thu, 14 Mar 2024 10:44:58 +0200	[thread overview]
Message-ID: <d8310f83-caf4-4108-bfb1-a024289860c7@ilbers.de> (raw)
In-Reply-To: <AS4PR10MB531848BD26B9D196F24E7F3DED292@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM>

14/03/2024 10:28, Schmidt, Adriaan wrote:
> Hi Anton,
>
> Just stumbled across this when using current next:
> There is a space missing in the append:
> d.appendVar(var, ' ' + v.replace('${PN}', '${BPN}'))
>
> Also, setting variables "V:remove" (potentially multiple times) from
> Python code smells a little funny. I'm not sure about Bitbake parsing,
> and the order of execution-of-Python-blocks vs. variable-assignments vs.
> expansions vs. :remove-operators, but I'm a worried that this might
> be relying on some undocumented implementation details and only work
> by accident.
> But I admit that I didn't have a closer look at the actual problem
> you're solving here, so I also don't have a good alternative proposal.
>
> So for now, I'd suggest to just fix the missing space.
>
> Thanks,
> Adriaan

Hello Adriaan,

Thanks for notice, I will send a fix for missing space.

I'm also not satisfied with ":remove" setting but don't see better solution.
In general, it's all about Bitbake ignoring :remove overrides during getVar
with expand=False (but taking care about :append overrides), which makes us
use such a hack.


  reply	other threads:[~2024-03-14  8:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 14:10 [PATCH v2 0/4] " Anton Mikanovich
2024-02-16 14:10 ` [PATCH v2 1/4] conf: Enable bbappends Anton Mikanovich
2024-02-16 14:10 ` [PATCH v2 2/4] meta-test: Add examples of SRC_URI overrides usage Anton Mikanovich
2024-02-16 14:10 ` [PATCH v2 3/4] dpkg-base: Fix SRC_URI:remove ignoring Anton Mikanovich
2024-02-16 14:10 ` [PATCH v2 4/4] multiarch: " Anton Mikanovich
2024-03-14  8:28   ` Schmidt, Adriaan
2024-03-14  8:44     ` Anton Mikanovich [this message]
2024-02-19 18:19 ` [PATCH v2 0/4] " Jan Kiszka
2024-03-07  7:15 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8310f83-caf4-4108-bfb1-a024289860c7@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=adriaan.schmidt@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox