From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7336105500565569536 X-Forwarded-Encrypted: i=2; AJvYcCU4AIcqwBscj8TpuSCr0A3pjjx2wjF4M7hg+GaOio6En0krrLz68bQurcTQ1kafETjGrKUsyOQzBCPjWtwBgsxAsyYKew+XaWZ37dI= X-Received: by 2002:adf:a48e:0:b0:33e:929e:5366 with SMTP id g14-20020adfa48e000000b0033e929e5366mr4317156wrb.28.1710405903265; Thu, 14 Mar 2024 01:45:03 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:664a:0:b0:33e:79da:bf90 with SMTP id f10-20020a5d664a000000b0033e79dabf90ls130620wrw.1.-pod-prod-00-eu; Thu, 14 Mar 2024 01:45:01 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXnjRER8ND7dL5+kknfBDzvcVMuTyY2UaAcovJHwxGlEHUIhy2sFEeEjXeaX7QBIDJzz7NWRM2dlfn2JiWnvEKbo6IrcrwGuiTDgwI= X-Google-Smtp-Source: AGHT+IFZ3dYP9NQmOOdRfKYth1tSyCsAfYHzOfy1NN1nsa38EEAQEB25me/TtWLoRyvqRnssLLU+ X-Received: by 2002:adf:f5c6:0:b0:33e:2d7b:c5a8 with SMTP id k6-20020adff5c6000000b0033e2d7bc5a8mr2411476wrp.17.1710405901034; Thu, 14 Mar 2024 01:45:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1710405901; cv=none; d=google.com; s=arc-20160816; b=Kfm6XOpUU5BA15R51lX4JakMRujXJlyccEXjc/wTaC5rpzL1v6W8TGH4oK7rwQi3lw vpkVyCCm4hJPjETyR1WhaUOy2gMlaTuiM08hgNlBgybjkYmkoTyMCOMADhrIbhtKecxD bUPXIFO6wyPcFVJSDWNs5ClvBICP/kN5WyHYpwHxDe0R1Iaw0tPrfYxVOWd4jlRFjMZj s6zm5oLAve00H1oUMm9BPSRUQT1dPqhxDuc1YPkvg4JBQ/5/x5OgCwf2uTE0oN9Fxxmx B/1TV3Ev3xw4+Ap2JUlOCLOaeKoSPx4Bqdq2BBNZtxbrBJmLyH9fMMtb/LakZ8lshAmT S9iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id; bh=oelYCkuDUaHkkxWI1oDr1qd9Chv33ZE052Bys+6lbC8=; fh=g6VVbiCP/jnAPP6alUcV8coXGhkIlnYWJxXnLt3nCNw=; b=C+1tqX6VehXQFbpdKStoieMwaW5VGxovTBxOhpikuCePca8DFZB3dayHQ6v69NwsgJ QEuDeqvve3zzc4kGzvRaRrx9UEPcXiMkDi7SsXJL1Jxnh4b8nQHT32bRG7E1eSNyqJ5h iNV8UHBkWFNRCFHPssA1GTLzldSktEpvnDtOqHR+Y90/ogh02/5W5CoHCg7NHL6FNXTr VglDVxuQX+K8DeJ0BXgbStra5VXgvTcAluThI6IW7Bdz9SJoHltgGOtTwokohvfabZd5 f2U4eWC3fgULu9uNgyLk1GXyFrxooemPUfUi/oZ3l2xA7y0Oy4JP4M/EsYLZTH4t2oIv XGVg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id l11-20020adff48b000000b0033e7e0c1948si10189wro.3.2024.03.14.01.45.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2024 01:45:00 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 42E8iwlO022693 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Mar 2024 09:44:59 +0100 Message-ID: Date: Thu, 14 Mar 2024 10:44:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] multiarch: Fix SRC_URI:remove ignoring Content-Language: en-US, ru-RU To: "Schmidt, Adriaan" , "isar-users@googlegroups.com" Cc: "MOESSBAUER, Felix" References: <20240216141051.3490109-1-amikan@ilbers.de> <20240216141051.3490109-5-amikan@ilbers.de> From: Anton Mikanovich In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: a8KesIsTUMEf 14/03/2024 10:28, Schmidt, Adriaan wrote: > Hi Anton, > > Just stumbled across this when using current next: > There is a space missing in the append: > d.appendVar(var, ' ' + v.replace('${PN}', '${BPN}')) > > Also, setting variables "V:remove" (potentially multiple times) from > Python code smells a little funny. I'm not sure about Bitbake parsing, > and the order of execution-of-Python-blocks vs. variable-assignments vs. > expansions vs. :remove-operators, but I'm a worried that this might > be relying on some undocumented implementation details and only work > by accident. > But I admit that I didn't have a closer look at the actual problem > you're solving here, so I also don't have a good alternative proposal. > > So for now, I'd suggest to just fix the missing space. > > Thanks, > Adriaan Hello Adriaan, Thanks for notice, I will send a fix for missing space. I'm also not satisfied with ":remove" setting but don't see better solution. In general, it's all about Bitbake ignoring :remove overrides during getVar with expand=False (but taking care about :append overrides), which makes us use such a hack.