Re: [PATCH v5] dpkg: Restore support for replacing pre-installed packages in sbuild-chroot

[Uladzimir Bely <ubely@ilbers.de>]

On Thu, 2024-01-18 at 09:28 +0300, Uladzimir Bely wrote:
> On Tue, 2024-01-16 at 09:22 +0100, Jan Kiszka wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> > 
> > During the migration to sbuild, support for using self-built
> > packages
> > in
> > the build environment was lost if those were already part of the
> > sbuild-chroot. This restores it by adding --apt-distupgrade to the
> > sbuild call. But that is not enough because sbuild will only
> > upgrade
> > packages from already configured sources, not those specified via
> > --extra-repository. We therefore have to switch back to configuring
> > isar-apt during sbuild-chroot creation.
> > 
> > As rootfs_configure_isar_apt configures the isar repo under
> > /isar-apt, we bind-mount the one in /home/builder/${PN} to that
> > folder.
> > Another difference is that we now need to run apt-get update
> > explicitly,
> > but only for isar-apt.
> > 
> > And because the sbuild-chroots are now left behind with isar-apt
> > configured, the configuration in imager_run can be removed (credits
> > to
> > Srinuvasan Arjunan).
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> > 
> > Changes in v5:
> >  - also use dpkg_schroot_create_configs for apt_fetch and
> > apt_unpack
> >    (while I wasn't able to reproduce the issue, I think this should
> >    resolve the CI problems)
> > 
> 
> Unfortunately, the picture in full CI didn't change. Even worse, one
> more job (NoCrossTest.test_nocross has failed with the similar error.
> 
> tmp/work/debian-bullseye-amd64/hello/1.0-
> r0/temp/log.do_apt_unpack.1785250:
> ```
> DEBUG: Executing shell function do_apt_unpack
> cp: cannot stat '/downloads/deb-src/debian-bullseye/hello/hello_2.10-
> 2+isar.debian.tar.xz': No such file or directory
> cp: cannot stat '/downloads/deb-src/debian-bullseye/hello/hello_2.10-
> 2+isar.dsc': No such file or directory
> ```
> 
> I'm continuing debugging the issue.
> 

Just one addition: previously (in v4) builds were failing in
hello:apt_fetch, not they fail in hello:apt_unpack.

Also, now repro tests failed earlier - during base_apt:do_cache. E.g:

tmp_repro_signed/work/debian-bullseye-arm64/base-apt/1.0-
r0/temp/log.do_cache.2901916:

```
...
Exporting indices...
Error opening '/build/isar_ub_devel/359/downloads/deb-src/debian-
bullseye/hello/hello_2.10-2+isar.dsc': No such file or directory
There have been errors!
WARNING: exit code 254 from a shell command.
DEBUG: Python function do_cache finished
```